From: Bjorn Helgaas <helgaas@kernel.org>
To: Sunil Muthuswamy <sunilmut@microsoft.com>
Cc: "Marc Zyngier" <maz@kernel.org>,
"Michael Kelley" <mikelley@microsoft.com>,
"Boqun Feng" <Boqun.Feng@microsoft.com>,
"KY Srinivasan" <kys@microsoft.com>,
"Haiyang Zhang" <haiyangz@microsoft.com>,
"Stephen Hemminger" <sthemmin@microsoft.com>,
"Dexuan Cui" <decui@microsoft.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Rob Herring" <robh@kernel.org>,
"\"Krzysztof Wilczyński\"" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Wei Liu" <wei.liu@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Borislav Petkov" <bp@alien8.de>,
"\"H. Peter Anvin\"" <hpa@zytor.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] PCI: hv: Support for Hyper-V vPCI for ARM64
Date: Fri, 8 Oct 2021 14:22:59 -0500 [thread overview]
Message-ID: <20211008192259.GA1366435@bhelgaas> (raw)
In-Reply-To: <MW4PR21MB2002619B2F7EEB9B1C4F5712C0B29@MW4PR21MB2002.namprd21.prod.outlook.com>
Subject line should start with a verb telling us what this does.
On Fri, Oct 08, 2021 at 05:21:29PM +0000, Sunil Muthuswamy wrote:
> This patch adds support for Hyper-V vPCI by adding a PCI MSI
> IRQ domain specific to Hyper-V that is based on SPIs. The IRQ
> domain parents itself to the arch GIC IRQ domain for basic
> vector management.
Same "This patch adds ..." comment as for patch 1/2. You could say
something like "Add support ...". It would also be good to include
"ARM64" since I think that's the point here.
> + /* Delivery mode: Fixed */
> + *delivery_mode = 0;
Why not APIC_DELIVERY_MODE_FIXED as you used for x86?
Bjorn
next prev parent reply other threads:[~2021-10-08 19:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-08 17:21 [PATCH v2 2/2] PCI: hv: Support for Hyper-V vPCI for ARM64 Sunil Muthuswamy
2021-10-08 19:22 ` Bjorn Helgaas [this message]
2021-10-08 19:33 ` [EXTERNAL] " Sunil Muthuswamy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211008192259.GA1366435@bhelgaas \
--to=helgaas@kernel.org \
--cc=Boqun.Feng@microsoft.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=kw@linux.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=maz@kernel.org \
--cc=mikelley@microsoft.com \
--cc=mingo@redhat.com \
--cc=robh@kernel.org \
--cc=sthemmin@microsoft.com \
--cc=sunilmut@microsoft.com \
--cc=tglx@linutronix.de \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.