From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Cc: Simon Glass <sjg@chromium.org>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Alex Graf <agraf@csgraf.de>,
Sughosh Ganu <sughosh.ganu@linaro.org>,
Masami Hiramatsu <masami.hiramatsu@linaro.org>,
U-Boot Mailing List <u-boot@lists.denx.de>
Subject: Re: [PATCH v4 01/11] Revert "Revert "mkeficapsule: Remove dtb related options""
Date: Mon, 11 Oct 2021 09:29:08 +0900 [thread overview]
Message-ID: <20211011002908.GA44356@laputa> (raw)
In-Reply-To: <YWCX/9xvgfsP4fVv@apalos.home>
On Fri, Oct 08, 2021 at 10:11:59PM +0300, Ilias Apalodimas wrote:
> Hi Simon,
>
> On Fri, Oct 08, 2021 at 09:38:11AM -0600, Simon Glass wrote:
> > Hi Takahiro,
> >
> > On Thu, 7 Oct 2021 at 00:24, AKASHI Takahiro <takahiro.akashi@linaro.org> wrote:
> > >
> > > This reverts commit d428e81266a59974ade74c1ba019af39f23304ab.
> > > We have agreed with removing dtb-related stuff from mkeficapsule
> > > command even if the commit 47a25e81d35c ("Revert "efi_capsule: Move
> > > signature from DTB to .rodata"") was applied.
> >
> > Can you please explain why this is being removed? How is the public
> > key to be communicated?
>
> Via the script that Akashi-san is adding in this patch series.
Yeah, please see my patch#4 for fdtsig.sh.
The reason why I think we should remove the feature from mkeficapsule
command is partly because we can do the same task by using *existing*
fdt tools and partly because having two totally-independent functionality
(one for a capsule binary and one for fdt) in a single tool seems confusing.
> >
> > Please can you also copy me on future related patches? (thank for you
> > for the private email alerting me)
> >
> > What does "We have agreed" mean?
>
> This has nothing to do with the public key. This is only changing the tool
> we used to include the key in the DTB. It is the same patch I mentioned you
> should never have reverted in the first place on your pull request, but since
> that happened very late in the release cycle we said we would re-apply it after
> the release.
Indeed.
-Takahiro Akashi
> >
> > >
> > > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> > > ---
> > > tools/mkeficapsule.c | 229 ++-----------------------------------------
> > > 1 file changed, 7 insertions(+), 222 deletions(-)
> > >
> >
> > Regards,
> > Simon
>
> It was my patch to begin with so I am not really sure my reviewed tag has
> any value, but FWIW
>
> Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
next prev parent reply other threads:[~2021-10-11 0:29 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 6:23 [PATCH v4 00/11] efi_loader: capsule: improve capsule authentication support AKASHI Takahiro
2021-10-07 6:23 ` [PATCH v4 01/11] Revert "Revert "mkeficapsule: Remove dtb related options"" AKASHI Takahiro
2021-10-08 15:38 ` Simon Glass
2021-10-08 19:11 ` Ilias Apalodimas
2021-10-11 0:29 ` AKASHI Takahiro [this message]
2021-10-11 14:54 ` Simon Glass
2021-10-12 1:15 ` AKASHI Takahiro
2021-10-07 6:23 ` [PATCH v4 02/11] Revert "Revert "doc: Update CapsuleUpdate READMEs"" AKASHI Takahiro
2021-10-07 6:23 ` [PATCH v4 03/11] efi_loader: capsule: add back efi_get_public_key_data() AKASHI Takahiro
2021-10-08 19:25 ` Ilias Apalodimas
2021-10-15 0:40 ` Simon Glass
2021-10-20 8:18 ` Masami Hiramatsu
2021-10-20 9:08 ` François Ozog
2021-10-20 13:39 ` Simon Glass
2021-10-25 5:14 ` AKASHI Takahiro
2021-10-25 6:28 ` François Ozog
2021-10-25 7:04 ` Masami Hiramatsu
2021-10-25 7:14 ` François Ozog
2021-10-25 15:18 ` Simon Glass
2021-10-07 6:23 ` [PATCH v4 04/11] tools: add fdtsig.sh AKASHI Takahiro
2021-10-11 14:54 ` Simon Glass
2021-10-12 1:42 ` AKASHI Takahiro
2021-10-15 0:40 ` Simon Glass
2021-10-25 3:06 ` AKASHI Takahiro
2021-10-26 6:00 ` AKASHI Takahiro
2021-10-27 14:05 ` Simon Glass
2021-10-07 6:23 ` [PATCH v4 05/11] tools: mkeficapsule: add firmwware image signing AKASHI Takahiro
2021-10-20 8:17 ` Masami Hiramatsu
2021-10-25 3:12 ` AKASHI Takahiro
2021-10-25 5:40 ` Masami Hiramatsu
2021-10-25 6:09 ` AKASHI Takahiro
2021-10-25 7:04 ` Masami Hiramatsu
2021-10-25 9:58 ` Sughosh Ganu
2021-10-25 12:46 ` Masami Hiramatsu
2021-10-07 6:23 ` [PATCH v4 06/11] tools: mkeficapsule: add man page AKASHI Takahiro
2021-10-07 6:23 ` [PATCH v4 07/11] doc: update UEFI document for usage of mkeficapsule AKASHI Takahiro
2021-10-07 6:23 ` [PATCH v4 08/11] tools: mkeficapsule: allow for specifying GUID explicitly AKASHI Takahiro
2021-10-07 6:23 ` [PATCH v4 09/11] test/py: efi_capsule: align with the syntax change of mkeficapsule AKASHI Takahiro
2021-10-07 6:23 ` [PATCH v4 10/11] test/py: efi_capsule: add a test for "--guid" option AKASHI Takahiro
2021-10-07 6:23 ` [PATCH v4 11/11] test/py: efi_capsule: add image authentication test AKASHI Takahiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211011002908.GA44356@laputa \
--to=takahiro.akashi@linaro.org \
--cc=agraf@csgraf.de \
--cc=ilias.apalodimas@linaro.org \
--cc=masami.hiramatsu@linaro.org \
--cc=sjg@chromium.org \
--cc=sughosh.ganu@linaro.org \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.