From: Dan Carpenter <dan.carpenter@oracle.com>
To: Saurav Girepunje <saurav.girepunje@gmail.com>
Cc: Fabio Aiuto <fabioaiuto83@gmail.com>,
saurav.girepunje@hotmail.com, gregkh@linuxfoundation.org,
marcocesati@gmail.com, lee.jones@linaro.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: hal: remove if condition which is always false
Date: Mon, 11 Oct 2021 13:41:41 +0300 [thread overview]
Message-ID: <20211011104141.GP2083@kadam> (raw)
In-Reply-To: <9dca9f7e-f987-5be5-9523-7dd08c2b364e@gmail.com>
Yep. And please go through the function and clean up all the references
to max_rf_path. Change the "max_rf_path = 0" to 1 and delete the other
assignment. Delete the comments about "max_rf_path == 2".
regards,
dan carpenter
next prev parent reply other threads:[~2021-10-11 10:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-10 7:32 [PATCH] staging: rtl8723bs: hal: remove if condition which is always false Saurav Girepunje
2021-10-10 10:50 ` Fabio Aiuto
2021-10-10 11:02 ` Saurav Girepunje
2021-10-11 10:41 ` Dan Carpenter [this message]
2021-10-11 17:11 ` Saurav Girepunje
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211011104141.GP2083@kadam \
--to=dan.carpenter@oracle.com \
--cc=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=marcocesati@gmail.com \
--cc=saurav.girepunje@gmail.com \
--cc=saurav.girepunje@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.