From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
<linux-kernel@vger.kernel.org>,
<linux-renesas-soc@vger.kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>, <linux-iio@vger.kernel.org>
Subject: Re: [PATCH 6/9] iio: common: cros_ec_sensors: simplify getting .driver_data
Date: Tue, 12 Oct 2021 09:31:56 +0100 [thread overview]
Message-ID: <20211012093156.00006cb0@Huawei.com> (raw)
In-Reply-To: <YWU5v8aH3wtsAMlp@ninjato>
On Tue, 12 Oct 2021 09:31:11 +0200
Wolfram Sang <wsa+renesas@sang-engineering.com> wrote:
> Hi Jonathan,
>
> > It's not something that ever bothered me that much, but we have had debates in
> > the past about whether there are semantic issues around this sort of cleanup
> > as it mixes
> >
> > platform_set_drvdata() with device_get_drvdata()
>
> Yeah, I see this concern. Mixing the two makes reading the code a bit
> more difficult. As I said, it wasn't so easy to convert set_drvdata, but
> I will have another go at this.
>
> > Whilst they access the same pointer today, in theory that isn't necessarily
> > always going to be the case in future and it isn't necessarily apparent
> > to the casual reader of the code.
>
> That one I don't really see. *_get_drvdata() should always get
> 'dev->driver_data' and the prefix just tells from what namespace we
> come. If you want to change that, a lot of things will break loose, I'd
> think. Even in the unlikely case of platform_device gaining a seperate
> driver_data(?), it probably should be named *_get_pdrvdata(), or?
Agreed. Does indeed seem like any change to this would be a mess so would
require different naming etc.
Thanks,
Jonathan
>
> Thanks and happy hacking,
>
> Wolfram
>
>
next prev parent reply other threads:[~2021-10-12 8:32 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 9:05 [PATCH 0/9] treewide: simplify getting .driver_data Wolfram Sang
2021-09-20 9:05 ` Wolfram Sang
2021-09-20 9:05 ` Wolfram Sang
2021-09-20 9:05 ` [PATCH 1/9] dmaengine: stm32-dmamux: " Wolfram Sang
2021-09-20 9:05 ` Wolfram Sang
2021-09-20 9:05 ` [PATCH 2/9] firmware: meson: " Wolfram Sang
2021-09-20 9:05 ` Wolfram Sang
2021-09-20 9:05 ` Wolfram Sang
2021-09-20 12:22 ` Neil Armstrong
2021-09-20 12:22 ` Neil Armstrong
2021-09-20 12:22 ` Neil Armstrong
2021-09-20 9:05 ` [PATCH 3/9] gpio: xilinx: " Wolfram Sang
2021-09-20 9:05 ` Wolfram Sang
2021-09-22 9:48 ` Bartosz Golaszewski
2021-09-22 9:48 ` Bartosz Golaszewski
2021-09-20 9:05 ` [PATCH 4/9] drm/msm: " Wolfram Sang
2021-09-20 9:05 ` [PATCH 5/9] drm/panfrost: " Wolfram Sang
2021-09-20 11:06 ` Alyssa Rosenzweig
2021-09-20 13:33 ` Steven Price
2021-09-20 9:05 ` [PATCH 6/9] iio: common: cros_ec_sensors: " Wolfram Sang
2021-09-23 9:16 ` Enric Balletbo i Serra
2021-09-25 14:54 ` Jonathan Cameron
2021-10-12 7:31 ` Wolfram Sang
2021-10-12 8:31 ` Jonathan Cameron [this message]
2021-09-20 9:05 ` [PATCH 7/9] net: mdio: mdio-bcm-iproc: " Wolfram Sang
2021-09-20 9:05 ` Wolfram Sang
2021-09-20 21:56 ` Florian Fainelli
2021-09-20 21:56 ` Florian Fainelli
2021-09-21 5:52 ` Wolfram Sang
2021-09-21 5:52 ` Wolfram Sang
2021-09-20 9:05 ` [PATCH 8/9] platform: chrome: cros_ec_sensorhub: " Wolfram Sang
2021-09-20 9:05 ` [PATCH 9/9] remoteproc: omap_remoteproc: " Wolfram Sang
2021-10-15 17:22 ` [PATCH 0/9] treewide: " Bjorn Andersson
2021-10-15 17:22 ` Bjorn Andersson
2021-10-15 17:22 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211012093156.00006cb0@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=bleung@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.