Re: [PATCH V6 04/10] irqchip/loongson-pch-msi: Add ACPI init support

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3080 bytes --]

Hi Huacai,

I love your patch! Perhaps something to improve:

[auto build test WARNING on tip/irq/core]
[also build test WARNING on linux/master linus/master v5.15-rc5 next-20211011]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Huacai-Chen/irqchip-Add-LoongArch-related-irqchip-drivers/20211011-164738
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git b70e13885cf63b6f99cbd9a1dbb6beaa2622bf68
config: mips-loongson2k_defconfig (attached as .config)
compiler: mips64el-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/c2e672fab9842d2cfc2876a27ec4513c75347fdf
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Huacai-Chen/irqchip-Add-LoongArch-related-irqchip-drivers/20211011-164738
        git checkout c2e672fab9842d2cfc2876a27ec4513c75347fdf
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/irqchip/irq-loongson-pch-msi.c:234:5: warning: no previous prototype for 'pch_msi_of_init' [-Wmissing-prototypes]
     234 | int pch_msi_of_init(struct device_node *node, struct device_node *parent)
         |     ^~~~~~~~~~~~~~~


vim +/pch_msi_of_init +234 drivers/irqchip/irq-loongson-pch-msi.c

   233	
 > 234	int pch_msi_of_init(struct device_node *node, struct device_node *parent)
   235	{
   236		int err;
   237		int irq_base, irq_count;
   238		struct resource res;
   239		struct irq_domain *parent_domain;
   240	
   241		parent_domain = irq_find_host(parent);
   242		if (!parent_domain) {
   243			pr_err("Failed to find the parent domain\n");
   244			return -ENXIO;
   245		}
   246	
   247		if (of_address_to_resource(node, 0, &res)) {
   248			pr_err("Failed to allocate resource\n");
   249			return -EINVAL;
   250		}
   251	
   252		if (of_property_read_u32(node, "loongson,msi-base-vec", &irq_base)) {
   253			pr_err("Unable to parse MSI vec base\n");
   254			return -EINVAL;
   255		}
   256	
   257		if (of_property_read_u32(node, "loongson,msi-num-vecs", &irq_count)) {
   258			pr_err("Unable to parse MSI vec number\n");
   259			return -EINVAL;
   260		}
   261	
   262		err = pch_msi_init(res.start, irq_base, irq_count, parent_domain, of_node_to_fwnode(node));
   263		if (err < 0)
   264			return err;
   265	
   266		return 0;
   267	}
   268	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 30741 bytes --]