All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Anthony Iliopoulos <ailiop@suse.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] build: remove unused AC_PACKAGE_NEED_OPEN_BY_FSHANDLE macro
Date: Tue, 12 Oct 2021 08:39:46 -0700	[thread overview]
Message-ID: <20211012153946.GH24282@magnolia> (raw)
In-Reply-To: <20211012135057.25689-1-ailiop@suse.com>

On Tue, Oct 12, 2021 at 03:50:57PM +0200, Anthony Iliopoulos wrote:
> Commit 5868405dce1d ("Sync up different copies of the m4 macros, noop
> change for this package.") introduced this macro, by the function was
> never really used by any test, remove it.

If we're not going to keep this in sync (with what I have no idea) then
why not remove the other unused macros?

--D

> Signed-off-by: Anthony Iliopoulos <ailiop@suse.com>
> ---
>  m4/package_xfslibs.m4 | 14 --------------
>  1 file changed, 14 deletions(-)
> 
> diff --git a/m4/package_xfslibs.m4 b/m4/package_xfslibs.m4
> index 9be56e1103ac..1bfd955479b8 100644
> --- a/m4/package_xfslibs.m4
> +++ b/m4/package_xfslibs.m4
> @@ -64,20 +64,6 @@ AC_DEFUN([AC_PACKAGE_NEED_LIBXFSINIT_LIBXFS],
>      AC_SUBST(libxfs)
>    ])
>  
> -AC_DEFUN([AC_PACKAGE_NEED_OPEN_BY_FSHANDLE],
> -  [ AC_CHECK_LIB(handle, open_by_fshandle,, [
> -        echo
> -        echo 'FATAL ERROR: could not find a current XFS handle library.'
> -        echo 'Install or upgrade the XFS library package.'
> -        echo 'Alternatively, run "make install-dev" from the xfsprogs source.'
> -        exit 1
> -    ])
> -    libhdl="-lhandle"
> -    test -f ${libexecdir}${libdirsuffix}/libhandle.la && \
> -	libhdl="${libexecdir}${libdirsuffix}/libhandle.la"
> -    AC_SUBST(libhdl)
> -  ])
> -
>  AC_DEFUN([AC_PACKAGE_NEED_ATTRLIST_LIBHANDLE],
>    [ AC_CHECK_LIB(handle, attr_list_by_handle,, [
>          echo
> -- 
> 2.33.0
> 

  parent reply	other threads:[~2021-10-12 15:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-12 13:50 [PATCH] build: remove unused AC_PACKAGE_NEED_OPEN_BY_FSHANDLE macro Anthony Iliopoulos
2021-10-12 14:28 ` David Disseldorp
2021-10-12 15:39 ` Darrick J. Wong [this message]
2021-10-12 16:19   ` Anthony Iliopoulos
2021-10-24 13:57     ` Eryu Guan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211012153946.GH24282@magnolia \
    --to=djwong@kernel.org \
    --cc=ailiop@suse.com \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.