From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05319C433EF for ; Wed, 13 Oct 2021 06:14:10 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 591D060F94 for ; Wed, 13 Oct 2021 06:14:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 591D060F94 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-69-QOCIzNidMhKmKkGpG3Lwnw-1; Wed, 13 Oct 2021 02:14:05 -0400 X-MC-Unique: QOCIzNidMhKmKkGpG3Lwnw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D227E79EDC; Wed, 13 Oct 2021 06:14:00 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 801D42B060; Wed, 13 Oct 2021 06:13:59 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C58474E58E; Wed, 13 Oct 2021 06:13:57 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 19D69ifa027793 for ; Wed, 13 Oct 2021 02:09:44 -0400 Received: by smtp.corp.redhat.com (Postfix) id B7BF91111451; Wed, 13 Oct 2021 06:09:44 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B3BDE111144E for ; Wed, 13 Oct 2021 06:09:42 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E9B7F185A79C for ; Wed, 13 Oct 2021 06:09:41 +0000 (UTC) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-516-Eiv2Tkq3N66B-VhP1psslw-1; Wed, 13 Oct 2021 02:09:40 -0400 X-MC-Unique: Eiv2Tkq3N66B-VhP1psslw-1 Received: by mail-pl1-f181.google.com with SMTP id c4so1080838pls.6 for ; Tue, 12 Oct 2021 23:09:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=z0+/l2JzZcIMvRxuVnPDxpTt0N87/VTetFSC9UipIbo=; b=YWp1loRNE2+K+dw3SucavTJBijXVe0d0tVWc5vlp85zlMAtr6u8p4IUJR4ssVrGYD6 r5NHcaqZacblZqfsJFnEDozS0dx5jNAz9I421QsuF9KbrfkbnZlTj/T9+LrYHJfx2KQI spzSCRXFkkBmuNgvO09V1f49ujJknqu2EcnHQv9tkz2/I2YQgVVc/KrMATFkyV0OdxjH xdk9KIn4+3I0fpbWzEdDbOAHdf1jQfRnpCqiFRm/UV07pQtnlul2HIpUFIqGcKQTUHGR pzWzX6BaDMuPkhGPzSNk3eDo96DbzYc+WtmnccKiLy+7EgwFiQlyCCSkoKiHTPuzkKMq Rg+Q== X-Gm-Message-State: AOAM5330/Mnzp0iPxSuCJEKtkQOIfoFSxmMRkmyPWUy+wCudkBccviG4 dTv1ultUv62TnGk0Kmmt/THKMQ== X-Google-Smtp-Source: ABdhPJx1Mq3qptD5w3g2Y6okZL9tWnjLnFrTXEu5gKzk6Wq6AX2hVHSkDjnl1IkjZGDzNZT+Poo5bw== X-Received: by 2002:a17:902:b593:b0:12d:7aa5:de2d with SMTP id a19-20020a170902b59300b0012d7aa5de2dmr34892215pls.31.1634105379132; Tue, 12 Oct 2021 23:09:39 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id nn14sm5323477pjb.27.2021.10.12.23.09.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Oct 2021 23:09:38 -0700 (PDT) Date: Tue, 12 Oct 2021 23:09:38 -0700 From: Kees Cook To: Christoph Hellwig Message-ID: <202110122309.FB5CB2DE3@keescook> References: <20211013051042.1065752-1-hch@lst.de> <20211013051042.1065752-3-hch@lst.de> MIME-Version: 1.0 In-Reply-To: <20211013051042.1065752-3-hch@lst.de> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: dm-devel@redhat.com Cc: Dave Kleikamp , jfs-discussion@lists.sourceforge.net, Mike Snitzer , linux-nvme@lists.infradead.org, Konstantin Komarov , Song Liu , dm-devel@redhat.com, target-devel@vger.kernel.org, linux-mtd@lists.infradead.org, reiserfs-devel@vger.kernel.org, drbd-dev@lists.linbit.com, linux-nilfs@vger.kernel.org, linux-scsi@vger.kernel.org, OGAWA Hirofumi , linux-ext4@vger.kernel.org, Josef Bacik , Coly Li , linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, David Sterba , Ryusuke Konishi , Anton Altaparmakov , Jens Axboe , linux-block@vger.kernel.org, linux-nfs@vger.kernel.org, Theodore Ts'o , linux-ntfs-dev@lists.sourceforge.net, Jan Kara , linux-fsdevel@vger.kernel.org, Phillip Lougher , ntfs3@lists.linux.dev, linux-btrfs@vger.kernel.org Subject: Re: [dm-devel] [PATCH 02/29] drbd: use bdev_nr_sectors instead of open coding it X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Oct 13, 2021 at 07:10:15AM +0200, Christoph Hellwig wrote: > Use the proper helper to read the block device size. > > Signed-off-by: Christoph Hellwig Reviewed-by: Kees Cook -- Kees Cook -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 777C4C433FE for ; Wed, 13 Oct 2021 06:09:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5F34D60E53 for ; Wed, 13 Oct 2021 06:09:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237884AbhJMGLp (ORCPT ); Wed, 13 Oct 2021 02:11:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237837AbhJMGLm (ORCPT ); Wed, 13 Oct 2021 02:11:42 -0400 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A88DAC061570 for ; Tue, 12 Oct 2021 23:09:39 -0700 (PDT) Received: by mail-pl1-x634.google.com with SMTP id y1so1069566plk.10 for ; Tue, 12 Oct 2021 23:09:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=z0+/l2JzZcIMvRxuVnPDxpTt0N87/VTetFSC9UipIbo=; b=dDm5KKH54Cm+jQj+Mhb1k8rvRxfJNbsL/HRxrPpWdrzH1k+JCSsBgY9A1wItnAnyuP 9ultcLUzRn7czy1OW9j2NX2hgXb5hjl16HGUd04L8fCWxy7FcQb0Xj95F86MpdxVurhd +Yoq3Vcva7UyTZ4UkXIHSgLR2MTnO/N9XCsr0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=z0+/l2JzZcIMvRxuVnPDxpTt0N87/VTetFSC9UipIbo=; b=S1RPXG2+qf/sPgn4hZ0eDZVXlOtClUazdaqjWh8bX05OFvq9VGY1kOeJMxMZu4Q31X +blCUriCp7LHknqKWHgvE/vLu4ukPovdXyUq4VH1u3vjka7rw+3naFXl7uQ9T5QjW0TR qLgBaR/uH2DWEVPs2gU+d1pkm7vRXrod5eWccTIlC2CT+oIg2gLPCZq1GN2OV/kGOL3G +M1A61WQ343EO3kiokxtvoUGpnYAFR9RkBbWEONuvHJzo1mJ29xGHqHJT+uxGpBzQJAH N27SX1JI0nlNadMIXMNlpxnZ5jmrrKil40hiD0IbQDCGwQyHGOlpFz7cPOs7v3YVlSjm lfxQ== X-Gm-Message-State: AOAM5306wzG8I5MM40r7xVZf3voErjBLHdHASKRDngwtLFgzwDxJiQQ+ JSPz37EMNdFocVqeVDppdQrDeg== X-Google-Smtp-Source: ABdhPJx1Mq3qptD5w3g2Y6okZL9tWnjLnFrTXEu5gKzk6Wq6AX2hVHSkDjnl1IkjZGDzNZT+Poo5bw== X-Received: by 2002:a17:902:b593:b0:12d:7aa5:de2d with SMTP id a19-20020a170902b59300b0012d7aa5de2dmr34892215pls.31.1634105379132; Tue, 12 Oct 2021 23:09:39 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id nn14sm5323477pjb.27.2021.10.12.23.09.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Oct 2021 23:09:38 -0700 (PDT) Date: Tue, 12 Oct 2021 23:09:38 -0700 From: Kees Cook To: Christoph Hellwig Cc: Jens Axboe , Coly Li , Mike Snitzer , Song Liu , David Sterba , Josef Bacik , Theodore Ts'o , OGAWA Hirofumi , Dave Kleikamp , Ryusuke Konishi , Anton Altaparmakov , Konstantin Komarov , Phillip Lougher , Jan Kara , linux-block@vger.kernel.org, dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev, reiserfs-devel@vger.kernel.org Subject: Re: [PATCH 02/29] drbd: use bdev_nr_sectors instead of open coding it Message-ID: <202110122309.FB5CB2DE3@keescook> References: <20211013051042.1065752-1-hch@lst.de> <20211013051042.1065752-3-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211013051042.1065752-3-hch@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-bcache@vger.kernel.org On Wed, Oct 13, 2021 at 07:10:15AM +0200, Christoph Hellwig wrote: > Use the proper helper to read the block device size. > > Signed-off-by: Christoph Hellwig Reviewed-by: Kees Cook -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kees Cook Subject: Re: [PATCH 02/29] drbd: use bdev_nr_sectors instead of open coding it Date: Tue, 12 Oct 2021 23:09:38 -0700 Message-ID: <202110122309.FB5CB2DE3@keescook> References: <20211013051042.1065752-1-hch@lst.de> <20211013051042.1065752-3-hch@lst.de> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=z0+/l2JzZcIMvRxuVnPDxpTt0N87/VTetFSC9UipIbo=; b=dDm5KKH54Cm+jQj+Mhb1k8rvRxfJNbsL/HRxrPpWdrzH1k+JCSsBgY9A1wItnAnyuP 9ultcLUzRn7czy1OW9j2NX2hgXb5hjl16HGUd04L8fCWxy7FcQb0Xj95F86MpdxVurhd +Yoq3Vcva7UyTZ4UkXIHSgLR2MTnO/N9XCsr0= Content-Disposition: inline In-Reply-To: <20211013051042.1065752-3-hch@lst.de> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christoph Hellwig Cc: Jens Axboe , Coly Li , Mike Snitzer , Song Liu , David Sterba , Josef Bacik , Theodore Ts'o , OGAWA Hirofumi , Dave Kleikamp , Ryusuke Konishi , Anton Altaparmakov , Konstantin Komarov , Phillip Lougher , Jan Kara , linux-block@vger.kernel.org, dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org On Wed, Oct 13, 2021 at 07:10:15AM +0200, Christoph Hellwig wrote: > Use the proper helper to read the block device size. > > Signed-off-by: Christoph Hellwig Reviewed-by: Kees Cook -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C0FAC433FE for ; Wed, 13 Oct 2021 07:34:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1A00560E74 for ; Wed, 13 Oct 2021 07:34:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1A00560E74 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=t3pq9rj3mlghc+Cb9bVZPh5ox2DpFOhwr7vc5hfgOwA=; b=S7uofqCmcpjnh1 YAffWjM3AivN2+QDZgzi5UfAElfek2kQWNKRVtUfOmXl2oaWMYlBbu+jl3QMkSOTnERWn1u/gCm2c zBp97OJSdhzC3zZTBxQwpIDoqjaU/W7BJeBVz+5xDia/ghDUskVkH3b1cxwNekANS2J5y8np0olQX gjNRprtXBTGOxw57OmDlb8YreDbgtpcCtqZetdy01yPSTdH7fMQn+st3GCMWHc+TZBYTEbwGGyHRK 5CSPna3rH56Hqb94fPYO8RkVBcuGaoFJ/lZ9OMLjX4VJ7PdUjPKLTcAs6MJCoLqB3VwiJb5rhJw/p gZ/W+rsSWLbNeThV+/oQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1maYlE-00FNnr-3L; Wed, 13 Oct 2021 07:33:12 +0000 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1maXSO-00F5lt-26 for linux-mtd@lists.infradead.org; Wed, 13 Oct 2021 06:09:41 +0000 Received: by mail-pj1-x102d.google.com with SMTP id np13so1351120pjb.4 for ; Tue, 12 Oct 2021 23:09:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=z0+/l2JzZcIMvRxuVnPDxpTt0N87/VTetFSC9UipIbo=; b=dDm5KKH54Cm+jQj+Mhb1k8rvRxfJNbsL/HRxrPpWdrzH1k+JCSsBgY9A1wItnAnyuP 9ultcLUzRn7czy1OW9j2NX2hgXb5hjl16HGUd04L8fCWxy7FcQb0Xj95F86MpdxVurhd +Yoq3Vcva7UyTZ4UkXIHSgLR2MTnO/N9XCsr0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=z0+/l2JzZcIMvRxuVnPDxpTt0N87/VTetFSC9UipIbo=; b=fas+8CuYxw3maS+Fm/9pXhCZHII96V1cyL9uohDuTDc7CSiuFhH77DYHKbyFoUYTGT WZ61oNABT4krx+NC3zkdTYkYCWlGYwEniVulWFWUN/tD0XXC2HXyYjb0CdUiuCCr3Xxb AiRGRA2HexBoo0lWlF0irfCLpCZJ0x1Sdqc+CNb0QS+PUz4sEre9khXKycHsZgp6vR8v mXGfa9rGHncM5lDvKSv5VzcRNZi4wY2+ZClggrF51D6BlJ2/moHybKlHO5CijcArF/u8 mAQhSHuX134sv37GOq4s47XVaqEIFx4auL/45K/Y7O41urqVUJBU/uKD3dRih+SrdAuj qH4A== X-Gm-Message-State: AOAM533OpcW7xwt/uxjyeCELeje5RK+7BESKfou15K21WvWxazug6Y09 broGpMWPS87VmCC4MUqRPmRfyA== X-Google-Smtp-Source: ABdhPJx1Mq3qptD5w3g2Y6okZL9tWnjLnFrTXEu5gKzk6Wq6AX2hVHSkDjnl1IkjZGDzNZT+Poo5bw== X-Received: by 2002:a17:902:b593:b0:12d:7aa5:de2d with SMTP id a19-20020a170902b59300b0012d7aa5de2dmr34892215pls.31.1634105379132; Tue, 12 Oct 2021 23:09:39 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id nn14sm5323477pjb.27.2021.10.12.23.09.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Oct 2021 23:09:38 -0700 (PDT) Date: Tue, 12 Oct 2021 23:09:38 -0700 From: Kees Cook To: Christoph Hellwig Cc: Jens Axboe , Coly Li , Mike Snitzer , Song Liu , David Sterba , Josef Bacik , Theodore Ts'o , OGAWA Hirofumi , Dave Kleikamp , Ryusuke Konishi , Anton Altaparmakov , Konstantin Komarov , Phillip Lougher , Jan Kara , linux-block@vger.kernel.org, dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev, reiserfs-devel@vger.kernel.org Subject: Re: [PATCH 02/29] drbd: use bdev_nr_sectors instead of open coding it Message-ID: <202110122309.FB5CB2DE3@keescook> References: <20211013051042.1065752-1-hch@lst.de> <20211013051042.1065752-3-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211013051042.1065752-3-hch@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211012_230940_174812_286F93D2 X-CRM114-Status: GOOD ( 11.67 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Wed, Oct 13, 2021 at 07:10:15AM +0200, Christoph Hellwig wrote: > Use the proper helper to read the block device size. > > Signed-off-by: Christoph Hellwig Reviewed-by: Kees Cook -- Kees Cook ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0880C433F5 for ; Wed, 13 Oct 2021 09:02:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6D8A860E96 for ; Wed, 13 Oct 2021 09:02:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6D8A860E96 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=77jyi3V1uXh4G7arQe5Tq4Ox7Iy2QtlUQ4/LX+JSN8o=; b=iwteGLChkiLPFc w2br6XR711rHonHIiyi61xbSFxGNle00u7u3l64Hs33+97Q4f+BG7liRO1MoxlWzOXjwQizIL3IUe pFPmLzVfl061R9QctvZZTz84aPnz+kXxr+mwzUR66KYyxkM4/saMx2UsDKF6Y9MyFg61Bq8++/tEs LNi2Qnx2emZJX+Ia1wQHQn7eGyxJW+rmD+13tngCs+K51sUZGwJfyXQplaEo9GP30uZlVlQxHcv5Q gjr+thVrfJ5AnXPv5HhNi+NSmyen83UpqSzR5l8zC0C7KsUoG8wV0qyELSoNfmHbN1US16N1wmGnb MOoM3x+ETUvpPQzsj/Uw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1maa9b-00FhHc-Sg; Wed, 13 Oct 2021 09:02:28 +0000 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1maXSO-00F5lu-22 for linux-nvme@lists.infradead.org; Wed, 13 Oct 2021 06:09:41 +0000 Received: by mail-pl1-x635.google.com with SMTP id f21so1091395plb.3 for ; Tue, 12 Oct 2021 23:09:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=z0+/l2JzZcIMvRxuVnPDxpTt0N87/VTetFSC9UipIbo=; b=dDm5KKH54Cm+jQj+Mhb1k8rvRxfJNbsL/HRxrPpWdrzH1k+JCSsBgY9A1wItnAnyuP 9ultcLUzRn7czy1OW9j2NX2hgXb5hjl16HGUd04L8fCWxy7FcQb0Xj95F86MpdxVurhd +Yoq3Vcva7UyTZ4UkXIHSgLR2MTnO/N9XCsr0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=z0+/l2JzZcIMvRxuVnPDxpTt0N87/VTetFSC9UipIbo=; b=t4cYqfTEZXrJc/h9Bd5m//BQrpoRjygbh3GI3UlP/iZJYmKoGahed/S42El8gwAhVt WsmA/o9CtgiXb8/HIlG3/vhEsvoJTi238SkMhWW6S+ENTgYOQuyKHzLd6zi/mje7t86X xmoAjMxClgpqWEpJ/LSF66fCGlsbMQA6unTMkWyTaNSUN79DhH9l43HRnmoPFZxLk9Wx kfQDvKvsXhh/zT3ZLl4SbvaxBt6IidhWqEPLvoHUwVhV0nPCVbdXU5rdd7E+856XwjiX Xv/6ItDMTHb9ZlPuxq4vpPKFoZpSPmFlfcMChAA5aJ/4pjn3Ybp2k0h5Y3O6aylW04zw OngQ== X-Gm-Message-State: AOAM530qBEhL/EJnTClZDZVn4ilq9Jzu5cKJ9R5asbiEhBnCHCdILxOJ Ehy4ehCekbBmwoYgAu5J3rsAHw== X-Google-Smtp-Source: ABdhPJx1Mq3qptD5w3g2Y6okZL9tWnjLnFrTXEu5gKzk6Wq6AX2hVHSkDjnl1IkjZGDzNZT+Poo5bw== X-Received: by 2002:a17:902:b593:b0:12d:7aa5:de2d with SMTP id a19-20020a170902b59300b0012d7aa5de2dmr34892215pls.31.1634105379132; Tue, 12 Oct 2021 23:09:39 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id nn14sm5323477pjb.27.2021.10.12.23.09.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Oct 2021 23:09:38 -0700 (PDT) Date: Tue, 12 Oct 2021 23:09:38 -0700 From: Kees Cook To: Christoph Hellwig Cc: Jens Axboe , Coly Li , Mike Snitzer , Song Liu , David Sterba , Josef Bacik , Theodore Ts'o , OGAWA Hirofumi , Dave Kleikamp , Ryusuke Konishi , Anton Altaparmakov , Konstantin Komarov , Phillip Lougher , Jan Kara , linux-block@vger.kernel.org, dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev, reiserfs-devel@vger.kernel.org Subject: Re: [PATCH 02/29] drbd: use bdev_nr_sectors instead of open coding it Message-ID: <202110122309.FB5CB2DE3@keescook> References: <20211013051042.1065752-1-hch@lst.de> <20211013051042.1065752-3-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211013051042.1065752-3-hch@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211012_230940_194606_8AB0780D X-CRM114-Status: GOOD ( 12.30 ) X-Mailman-Approved-At: Wed, 13 Oct 2021 01:15:58 -0700 X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Wed, Oct 13, 2021 at 07:10:15AM +0200, Christoph Hellwig wrote: > Use the proper helper to read the block device size. > > Signed-off-by: Christoph Hellwig Reviewed-by: Kees Cook -- Kees Cook _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id 4EDA4420FD6 for ; Wed, 13 Oct 2021 08:09:39 +0200 (CEST) Received: by mail-pj1-f54.google.com with SMTP id pf6-20020a17090b1d8600b0019fa884ab85so3590131pjb.5 for ; Tue, 12 Oct 2021 23:09:39 -0700 (PDT) Date: Tue, 12 Oct 2021 23:09:38 -0700 From: Kees Cook To: Christoph Hellwig Message-ID: <202110122309.FB5CB2DE3@keescook> References: <20211013051042.1065752-1-hch@lst.de> <20211013051042.1065752-3-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211013051042.1065752-3-hch@lst.de> Cc: Dave Kleikamp , jfs-discussion@lists.sourceforge.net, Mike Snitzer , linux-nvme@lists.infradead.org, Konstantin Komarov , Song Liu , dm-devel@redhat.com, target-devel@vger.kernel.org, linux-mtd@lists.infradead.org, reiserfs-devel@vger.kernel.org, drbd-dev@lists.linbit.com, linux-nilfs@vger.kernel.org, linux-scsi@vger.kernel.org, OGAWA Hirofumi , linux-ext4@vger.kernel.org, Josef Bacik , Coly Li , linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, David Sterba , Ryusuke Konishi , Anton Altaparmakov , Jens Axboe , linux-block@vger.kernel.org, linux-nfs@vger.kernel.org, Theodore Ts'o , linux-ntfs-dev@lists.sourceforge.net, Jan Kara , linux-fsdevel@vger.kernel.org, Phillip Lougher , ntfs3@lists.linux.dev, linux-btrfs@vger.kernel.org Subject: Re: [Drbd-dev] [PATCH 02/29] drbd: use bdev_nr_sectors instead of open coding it List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Oct 13, 2021 at 07:10:15AM +0200, Christoph Hellwig wrote: > Use the proper helper to read the block device size. > > Signed-off-by: Christoph Hellwig Reviewed-by: Kees Cook -- Kees Cook