From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E425AC433EF for ; Wed, 13 Oct 2021 06:15:05 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 85F8560F11 for ; Wed, 13 Oct 2021 06:15:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 85F8560F11 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-556-9tYdlcHTPWWn8eScA2V1jA-1; Wed, 13 Oct 2021 02:15:01 -0400 X-MC-Unique: 9tYdlcHTPWWn8eScA2V1jA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DB73F91279; Wed, 13 Oct 2021 06:14:56 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C0E1260E1C; Wed, 13 Oct 2021 06:14:56 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 97DC64EA37; Wed, 13 Oct 2021 06:14:56 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 19D6CxB0027977 for ; Wed, 13 Oct 2021 02:12:59 -0400 Received: by smtp.corp.redhat.com (Postfix) id 4A7AF1111A78; Wed, 13 Oct 2021 06:12:59 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 45C571111C9E for ; Wed, 13 Oct 2021 06:12:56 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7FE7A80158D for ; Wed, 13 Oct 2021 06:12:56 +0000 (UTC) Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-582-FtVvsLroMCKIjtvM5JsUag-1; Wed, 13 Oct 2021 02:12:54 -0400 X-MC-Unique: FtVvsLroMCKIjtvM5JsUag-1 Received: by mail-pg1-f179.google.com with SMTP id 75so1319536pga.3 for ; Tue, 12 Oct 2021 23:12:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1H1JJFKjz05y5oj0p755Wd9Nps08CHOHEplJ5Y1g+2w=; b=HuB2LG1NtxjPhkR5DNe9gvbQXLv9AuNG+8wTkliLtV37RlPluClQt+3zXaSLJ4GZ4+ AxAWFE6RU8xZLqvknE4vxmClnnDKZCI5gTf44IZUdhmo5AsPpkpCCLdsuJo5SdR2cdcf I/YGRUHbZOysnlGaXHOKHNuop1O6wqTerguPk4SgFcOXp3dTMNE/5Cs4W7yjpV5BJ+h0 BPaQOA4l/7TmbdcUiZzP5rF8Z962C7++pV6s6ZAFliXZcVYVuJxS/WkSAVmtPEgXO9iC m7r4toVKIpx9Mw1Ip0moBCeAliHObtAYP4WZ1+0NpvJp3fTm7j0YkknUwa/RPZ6vd/R0 AZkw== X-Gm-Message-State: AOAM533FzcAUqdyDwxZHNQX0sH5O7lDdidNKZmscsc7UDQvDBJk8yzlk Mq3JL1YO0ubRS2n1piekOqb/mw== X-Google-Smtp-Source: ABdhPJyo2VCUKF6kjMdrI9PCDmpBjFpUCoF94Pv9htxPPsmjtX3akcms7YpvLn8ozHxuI/GsrlutsQ== X-Received: by 2002:aa7:91c2:0:b0:44c:a5a4:43d4 with SMTP id z2-20020aa791c2000000b0044ca5a443d4mr35433093pfa.20.1634105573663; Tue, 12 Oct 2021 23:12:53 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id z124sm12774767pfb.108.2021.10.12.23.12.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Oct 2021 23:12:53 -0700 (PDT) Date: Tue, 12 Oct 2021 23:12:52 -0700 From: Kees Cook To: Christoph Hellwig Message-ID: <202110122311.B43459E21@keescook> References: <20211013051042.1065752-1-hch@lst.de> <20211013051042.1065752-5-hch@lst.de> MIME-Version: 1.0 In-Reply-To: <20211013051042.1065752-5-hch@lst.de> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: dm-devel@redhat.com Cc: Dave Kleikamp , jfs-discussion@lists.sourceforge.net, Mike Snitzer , linux-nvme@lists.infradead.org, Konstantin Komarov , Song Liu , dm-devel@redhat.com, target-devel@vger.kernel.org, linux-mtd@lists.infradead.org, reiserfs-devel@vger.kernel.org, drbd-dev@lists.linbit.com, linux-nilfs@vger.kernel.org, linux-scsi@vger.kernel.org, OGAWA Hirofumi , linux-ext4@vger.kernel.org, Josef Bacik , Coly Li , linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, David Sterba , Ryusuke Konishi , Anton Altaparmakov , Jens Axboe , linux-block@vger.kernel.org, linux-nfs@vger.kernel.org, Theodore Ts'o , linux-ntfs-dev@lists.sourceforge.net, Jan Kara , linux-fsdevel@vger.kernel.org, Phillip Lougher , ntfs3@lists.linux.dev, linux-btrfs@vger.kernel.org Subject: Re: [dm-devel] [PATCH 04/29] md: use bdev_nr_sectors instead of open coding it X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Oct 13, 2021 at 07:10:17AM +0200, Christoph Hellwig wrote: > Use the proper helper to read the block device size. > > Signed-off-by: Christoph Hellwig I think it might make sense, as you suggest earlier, to add a "bytes" helper. This is the first user in the series needing: bdev_nr_sectors(...bdev) << SECTOR_SHIFT Reviewed-by: Kees Cook -- Kees Cook -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91955C43217 for ; Wed, 13 Oct 2021 06:12:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7329761074 for ; Wed, 13 Oct 2021 06:12:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229582AbhJMGO5 (ORCPT ); Wed, 13 Oct 2021 02:14:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229991AbhJMGO5 (ORCPT ); Wed, 13 Oct 2021 02:14:57 -0400 Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42CA9C061570 for ; Tue, 12 Oct 2021 23:12:54 -0700 (PDT) Received: by mail-pf1-x42d.google.com with SMTP id q19so1529488pfl.4 for ; Tue, 12 Oct 2021 23:12:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1H1JJFKjz05y5oj0p755Wd9Nps08CHOHEplJ5Y1g+2w=; b=FnlM9CdvccmU4HmqmwsZQ6mwcBwOhpuSMmvAcPJz12hGrzMLx0wE72HESKXT/FSdf4 7+542Lua7V4TbazDGNap5DO9Pfw7c/uG+qyBy3qJkapOn+6ER85tMNMzt8DzCatnHQL8 8qEBnbzhJGY53T8EWVA6JlX/GqGluU0pFlO7o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1H1JJFKjz05y5oj0p755Wd9Nps08CHOHEplJ5Y1g+2w=; b=7yrhHOzyrSYSUCgjFBTCaPhhGsCGqqbq0zZgQbPGmgY5T4F0g9vdovDalZaLyg1qbi 2df7h00RvnzJSR+88k9Nm8lNRq7EdFL/BK90OXE3TCok6nbDBbK0Im1IsYFiajwBh2sk AGs9kgosSNU1s0kt8lzt47j946cjEUJSHLKwkNf8BjPu/pupkhmbw9qLiNoF9QLS3i4g SNTTYpAHdTFHVncTrMdscTxA0QKWRvENKIEutw1kP1kL29E4zU8P1oOjj4QDnJZCQK+H 0bri78oqbH5i2LE/8uSRDlsB37AhiAgOlfT6IvCkujxRzw7ZlnSShAlx6z+YENmWMyvd 6AaQ== X-Gm-Message-State: AOAM530VgfpeMzE8suQT6uWvlsspnMz9RbDKA4lS5Xd0uOj/It63E+AD 1lOvl7zdikcff4Hm+dnjB27NFT0Kxeuo4g== X-Google-Smtp-Source: ABdhPJyo2VCUKF6kjMdrI9PCDmpBjFpUCoF94Pv9htxPPsmjtX3akcms7YpvLn8ozHxuI/GsrlutsQ== X-Received: by 2002:aa7:91c2:0:b0:44c:a5a4:43d4 with SMTP id z2-20020aa791c2000000b0044ca5a443d4mr35433093pfa.20.1634105573663; Tue, 12 Oct 2021 23:12:53 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id z124sm12774767pfb.108.2021.10.12.23.12.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Oct 2021 23:12:53 -0700 (PDT) Date: Tue, 12 Oct 2021 23:12:52 -0700 From: Kees Cook To: Christoph Hellwig Cc: Jens Axboe , Coly Li , Mike Snitzer , Song Liu , David Sterba , Josef Bacik , Theodore Ts'o , OGAWA Hirofumi , Dave Kleikamp , Ryusuke Konishi , Anton Altaparmakov , Konstantin Komarov , Phillip Lougher , Jan Kara , linux-block@vger.kernel.org, dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev, reiserfs-devel@vger.kernel.org Subject: Re: [PATCH 04/29] md: use bdev_nr_sectors instead of open coding it Message-ID: <202110122311.B43459E21@keescook> References: <20211013051042.1065752-1-hch@lst.de> <20211013051042.1065752-5-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211013051042.1065752-5-hch@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-bcache@vger.kernel.org On Wed, Oct 13, 2021 at 07:10:17AM +0200, Christoph Hellwig wrote: > Use the proper helper to read the block device size. > > Signed-off-by: Christoph Hellwig I think it might make sense, as you suggest earlier, to add a "bytes" helper. This is the first user in the series needing: bdev_nr_sectors(...bdev) << SECTOR_SHIFT Reviewed-by: Kees Cook -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kees Cook Subject: Re: [PATCH 04/29] md: use bdev_nr_sectors instead of open coding it Date: Tue, 12 Oct 2021 23:12:52 -0700 Message-ID: <202110122311.B43459E21@keescook> References: <20211013051042.1065752-1-hch@lst.de> <20211013051042.1065752-5-hch@lst.de> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1H1JJFKjz05y5oj0p755Wd9Nps08CHOHEplJ5Y1g+2w=; b=FnlM9CdvccmU4HmqmwsZQ6mwcBwOhpuSMmvAcPJz12hGrzMLx0wE72HESKXT/FSdf4 7+542Lua7V4TbazDGNap5DO9Pfw7c/uG+qyBy3qJkapOn+6ER85tMNMzt8DzCatnHQL8 8qEBnbzhJGY53T8EWVA6JlX/GqGluU0pFlO7o= Content-Disposition: inline In-Reply-To: <20211013051042.1065752-5-hch@lst.de> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christoph Hellwig Cc: Jens Axboe , Coly Li , Mike Snitzer , Song Liu , David Sterba , Josef Bacik , Theodore Ts'o , OGAWA Hirofumi , Dave Kleikamp , Ryusuke Konishi , Anton Altaparmakov , Konstantin Komarov , Phillip Lougher , Jan Kara , linux-block@vger.kernel.org, dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org On Wed, Oct 13, 2021 at 07:10:17AM +0200, Christoph Hellwig wrote: > Use the proper helper to read the block device size. > > Signed-off-by: Christoph Hellwig I think it might make sense, as you suggest earlier, to add a "bytes" helper. This is the first user in the series needing: bdev_nr_sectors(...bdev) << SECTOR_SHIFT Reviewed-by: Kees Cook -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1CD9C433EF for ; Wed, 13 Oct 2021 07:38:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B8F8A60C4B for ; Wed, 13 Oct 2021 07:38:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B8F8A60C4B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=myn8e+kdCs0t6S+vtUINR3stR2HUZpyeSh6vHfahrTc=; b=iIh9QRQB2A8mK+ SNzB2x7Jpp5oNvrChQZkNxyphj7c6zJNElyAhh7ANCxHGz4+pJfInqDrST6UobeBKhzA7A4lDGmd3 7TLt9zjD8JkSnm3YcBKLOE7mJVuccTeGZJXyv1dCJrCGwvjKoLr9ozZEimwptaHun9h2eGQOTQG6U 5TazU3z98tg8fdWJLw75nEuBObnRadPfNM9+QFyzeQky19idw4iuRq7NZapEX54G/gMpAIliZH5b+ ZK/ZwWLUYhWYQt7HD3aApwLalE0fbt5OXLBeOWYmVNqvZ9uHVE/QolDVT5EY0uhNdU+XDH6xeuZ2p dLl03cQy5RjgytppQlng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1maYp6-00FOzi-Vo; Wed, 13 Oct 2021 07:37:13 +0000 Received: from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1maXVW-00F6RW-QU for linux-mtd@lists.infradead.org; Wed, 13 Oct 2021 06:12:56 +0000 Received: by mail-pg1-x52b.google.com with SMTP id f5so1278012pgc.12 for ; Tue, 12 Oct 2021 23:12:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1H1JJFKjz05y5oj0p755Wd9Nps08CHOHEplJ5Y1g+2w=; b=FnlM9CdvccmU4HmqmwsZQ6mwcBwOhpuSMmvAcPJz12hGrzMLx0wE72HESKXT/FSdf4 7+542Lua7V4TbazDGNap5DO9Pfw7c/uG+qyBy3qJkapOn+6ER85tMNMzt8DzCatnHQL8 8qEBnbzhJGY53T8EWVA6JlX/GqGluU0pFlO7o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1H1JJFKjz05y5oj0p755Wd9Nps08CHOHEplJ5Y1g+2w=; b=j7tSQvT+D5vE3C23+XziUfw8P8uq33gRnmzjJyIOJkjNk4rQBXyj97hC5O14a/w8HY kuOqmdc+sRM084bPHvBOXuYKciPk3OEmzD67riEVtRZurq1iFnvlnxYr6zKjtXia6eb4 6yi42PpKMS9U7mL8OVWfcWxjVKkJXMzWryPKuxWgq1XHVYit4I/v+4OJXysfXZWPhrAn NtX2+YY0KUWFK0xw37a2UmXF5Tx6dtPO/RBIDDAr/W0FymjfvYQHBXMaR3PiBDwGcuOQ JK7cRKgAB7U3JlmJ/FwcBHc4AvkDJRHVm51PnG2FViwfcH8sbcNEBzDlQEtvCA0oCl4W RWZw== X-Gm-Message-State: AOAM530cBBf2+4FWbSrjtzzb7dieACMTcUWt1HEPbGggkaP+2I/DaIO4 Cr/B+qF5mbP1p2h6slc32NMJ2A== X-Google-Smtp-Source: ABdhPJyo2VCUKF6kjMdrI9PCDmpBjFpUCoF94Pv9htxPPsmjtX3akcms7YpvLn8ozHxuI/GsrlutsQ== X-Received: by 2002:aa7:91c2:0:b0:44c:a5a4:43d4 with SMTP id z2-20020aa791c2000000b0044ca5a443d4mr35433093pfa.20.1634105573663; Tue, 12 Oct 2021 23:12:53 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id z124sm12774767pfb.108.2021.10.12.23.12.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Oct 2021 23:12:53 -0700 (PDT) Date: Tue, 12 Oct 2021 23:12:52 -0700 From: Kees Cook To: Christoph Hellwig Cc: Jens Axboe , Coly Li , Mike Snitzer , Song Liu , David Sterba , Josef Bacik , Theodore Ts'o , OGAWA Hirofumi , Dave Kleikamp , Ryusuke Konishi , Anton Altaparmakov , Konstantin Komarov , Phillip Lougher , Jan Kara , linux-block@vger.kernel.org, dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev, reiserfs-devel@vger.kernel.org Subject: Re: [PATCH 04/29] md: use bdev_nr_sectors instead of open coding it Message-ID: <202110122311.B43459E21@keescook> References: <20211013051042.1065752-1-hch@lst.de> <20211013051042.1065752-5-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211013051042.1065752-5-hch@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211012_231254_918598_85ECD732 X-CRM114-Status: GOOD ( 12.74 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Wed, Oct 13, 2021 at 07:10:17AM +0200, Christoph Hellwig wrote: > Use the proper helper to read the block device size. > > Signed-off-by: Christoph Hellwig I think it might make sense, as you suggest earlier, to add a "bytes" helper. This is the first user in the series needing: bdev_nr_sectors(...bdev) << SECTOR_SHIFT Reviewed-by: Kees Cook -- Kees Cook ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AB6EC433EF for ; Wed, 13 Oct 2021 09:06:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 10AED60E05 for ; Wed, 13 Oct 2021 09:06:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 10AED60E05 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uAXcyvSCNyINByXnuK1JAKYq5qTnc12hLURtHH67P5Y=; b=p8JFqvFK5NrKv3 FsmRg0dIgpvLMB4GP8Mk6UGJne6MkR/68AdUsfnrFrwUDiSasrJ0FC4Kmw4y5RMXLKgADJjGhb7R6 /38XDdZlzIoVVbNJI9eW9GlpODg7pkrttNmQw+sPXl2jnQv8gu9/fijVSZLgPs5nCBQAGqJ8eeLeg JNvHQZDkTrNX0SMMv5z0CW4GFOGjGl/jWWcTZtncXqkwOFct+9+xtKwK3Zo80DDKpldw2Msg6NYLX yUgNtFQp4rFHp92GUn4qnRBJ4s57M2RQF/HgFQZ6t2q6lo3qT0fW2KiI5MWrv+gf6kOCAs4foZ+pY JsFyi8IxMfyvUFCBxFEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1maaCt-00FhtT-If; Wed, 13 Oct 2021 09:05:51 +0000 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1maXVW-00F6RU-Rw for linux-nvme@lists.infradead.org; Wed, 13 Oct 2021 06:12:56 +0000 Received: by mail-pf1-x435.google.com with SMTP id m14so1504767pfc.9 for ; Tue, 12 Oct 2021 23:12:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1H1JJFKjz05y5oj0p755Wd9Nps08CHOHEplJ5Y1g+2w=; b=FnlM9CdvccmU4HmqmwsZQ6mwcBwOhpuSMmvAcPJz12hGrzMLx0wE72HESKXT/FSdf4 7+542Lua7V4TbazDGNap5DO9Pfw7c/uG+qyBy3qJkapOn+6ER85tMNMzt8DzCatnHQL8 8qEBnbzhJGY53T8EWVA6JlX/GqGluU0pFlO7o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1H1JJFKjz05y5oj0p755Wd9Nps08CHOHEplJ5Y1g+2w=; b=7iKItDoFc3sYgWtV0TRSK3i0+VYQ7ZSipP/wpSFvDAJhxUZWrSc42NtQ6zgX6jcfXz WfPvEt3R4126sjBV32vryBX/l2hVFUgPFDzguw9VPUFUxL/dmAIZ/enCrYTHsabj6ZQn coK79r1op9yVHsCI8frIoyknZxCqzyKYcMAKm5m4hTi5iRb5arX+0lIibipNHWlV6zFv it3OLoaetJCWZxR1MX8EY46saMgFW5csWV7pw67kGeHKCL+daQj0ZHhEPBqKJJi4dDDc Y3Qs7vTK3NYCIhfd8FYnNtmtKsqccSf8bPgXTf551LenzW87K08FysQ3329AWM2Feu3f 6asw== X-Gm-Message-State: AOAM530/GtVovT9tpy9J92SHtwHQUak8JXHCILx4ilN3UhMxuxPgwadv Uk1llQftZOvk/6JApnQZAlxJlw== X-Google-Smtp-Source: ABdhPJyo2VCUKF6kjMdrI9PCDmpBjFpUCoF94Pv9htxPPsmjtX3akcms7YpvLn8ozHxuI/GsrlutsQ== X-Received: by 2002:aa7:91c2:0:b0:44c:a5a4:43d4 with SMTP id z2-20020aa791c2000000b0044ca5a443d4mr35433093pfa.20.1634105573663; Tue, 12 Oct 2021 23:12:53 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id z124sm12774767pfb.108.2021.10.12.23.12.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Oct 2021 23:12:53 -0700 (PDT) Date: Tue, 12 Oct 2021 23:12:52 -0700 From: Kees Cook To: Christoph Hellwig Cc: Jens Axboe , Coly Li , Mike Snitzer , Song Liu , David Sterba , Josef Bacik , Theodore Ts'o , OGAWA Hirofumi , Dave Kleikamp , Ryusuke Konishi , Anton Altaparmakov , Konstantin Komarov , Phillip Lougher , Jan Kara , linux-block@vger.kernel.org, dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev, reiserfs-devel@vger.kernel.org Subject: Re: [PATCH 04/29] md: use bdev_nr_sectors instead of open coding it Message-ID: <202110122311.B43459E21@keescook> References: <20211013051042.1065752-1-hch@lst.de> <20211013051042.1065752-5-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211013051042.1065752-5-hch@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211012_231254_953707_62D84CC8 X-CRM114-Status: GOOD ( 13.37 ) X-Mailman-Approved-At: Wed, 13 Oct 2021 01:15:58 -0700 X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Wed, Oct 13, 2021 at 07:10:17AM +0200, Christoph Hellwig wrote: > Use the proper helper to read the block device size. > > Signed-off-by: Christoph Hellwig I think it might make sense, as you suggest earlier, to add a "bytes" helper. This is the first user in the series needing: bdev_nr_sectors(...bdev) << SECTOR_SHIFT Reviewed-by: Kees Cook -- Kees Cook _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id AE225420FD9 for ; Wed, 13 Oct 2021 08:12:54 +0200 (CEST) Received: by mail-pf1-f178.google.com with SMTP id w6so1496229pfd.11 for ; Tue, 12 Oct 2021 23:12:54 -0700 (PDT) Date: Tue, 12 Oct 2021 23:12:52 -0700 From: Kees Cook To: Christoph Hellwig Message-ID: <202110122311.B43459E21@keescook> References: <20211013051042.1065752-1-hch@lst.de> <20211013051042.1065752-5-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211013051042.1065752-5-hch@lst.de> Cc: Dave Kleikamp , jfs-discussion@lists.sourceforge.net, Mike Snitzer , linux-nvme@lists.infradead.org, Konstantin Komarov , Song Liu , dm-devel@redhat.com, target-devel@vger.kernel.org, linux-mtd@lists.infradead.org, reiserfs-devel@vger.kernel.org, drbd-dev@lists.linbit.com, linux-nilfs@vger.kernel.org, linux-scsi@vger.kernel.org, OGAWA Hirofumi , linux-ext4@vger.kernel.org, Josef Bacik , Coly Li , linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, David Sterba , Ryusuke Konishi , Anton Altaparmakov , Jens Axboe , linux-block@vger.kernel.org, linux-nfs@vger.kernel.org, Theodore Ts'o , linux-ntfs-dev@lists.sourceforge.net, Jan Kara , linux-fsdevel@vger.kernel.org, Phillip Lougher , ntfs3@lists.linux.dev, linux-btrfs@vger.kernel.org Subject: Re: [Drbd-dev] [PATCH 04/29] md: use bdev_nr_sectors instead of open coding it List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Oct 13, 2021 at 07:10:17AM +0200, Christoph Hellwig wrote: > Use the proper helper to read the block device size. > > Signed-off-by: Christoph Hellwig I think it might make sense, as you suggest earlier, to add a "bytes" helper. This is the first user in the series needing: bdev_nr_sectors(...bdev) << SECTOR_SHIFT Reviewed-by: Kees Cook -- Kees Cook