From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44577C43219 for ; Wed, 13 Oct 2021 06:14:33 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB92060FDA for ; Wed, 13 Oct 2021 06:14:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CB92060FDA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-445-o3Mn5OvqOcScEdcQEH8jtg-1; Wed, 13 Oct 2021 02:14:30 -0400 X-MC-Unique: o3Mn5OvqOcScEdcQEH8jtg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 81E09100F953; Wed, 13 Oct 2021 06:14:25 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B83C5196F9; Wed, 13 Oct 2021 06:14:24 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7B39E4E9F5; Wed, 13 Oct 2021 06:14:24 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 19D6ENV1028069 for ; Wed, 13 Oct 2021 02:14:23 -0400 Received: by smtp.corp.redhat.com (Postfix) id 5AEC740F9D72; Wed, 13 Oct 2021 06:14:23 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 54D3240F9D69 for ; Wed, 13 Oct 2021 06:14:23 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 38DB01066689 for ; Wed, 13 Oct 2021 06:14:18 +0000 (UTC) Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-590-TmZJidKyPom8xCnYTjaKDg-1; Wed, 13 Oct 2021 02:14:16 -0400 X-MC-Unique: TmZJidKyPom8xCnYTjaKDg-1 Received: by mail-pg1-f175.google.com with SMTP id r201so1316436pgr.4 for ; Tue, 12 Oct 2021 23:14:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ohUOQyC8vv5S9fFmDSqrC2HGxb4XvUeywx+2/I7KWZo=; b=6aLRWwW5xIDurlGtgziD8VoGfinrnZMQ7PFdCgklVlYsusEtZG/9KFCqw8xnWLrMVn EqqPr90PB3mR8fYtCk3Y6xgbTOuMHqf3xhfgQBeMLudpyJU5v9ay4D1zMCORMnFT3H10 Yh6jFvPaoZeIoPzOqtBMxq8SZsozwREIrfDFrz68GoXAeRI8uxMowoWNyCwd1LRt/Qga BdGH4qBMakPtD7fLuZOdM2ciRwAqv4/l7zB8iAORdS5Fc2++9icEHJtMByHEmDASgAz8 5lnN0NDIhp/qOPbnpqNDW3nk2sBafN6KLA/qlMBgwbD3VC0St1t7fzwc6gnK0u9+qepN zFcw== X-Gm-Message-State: AOAM531lUiXeQNmLamSAY7tVtg47bdfcAh+QSDNmcSIJywuuVGl/Lx+U Ln3V2CiRNR9uQ7L8g4rsBwdQow== X-Google-Smtp-Source: ABdhPJwNMNbppcyyaPyGGktYQSHeAypT2bIkLVBhhieDA7TSPn60W6m8F7nQfgJZ/E5a6hMyK4Ynow== X-Received: by 2002:a63:e00b:: with SMTP id e11mr26380948pgh.190.1634105655240; Tue, 12 Oct 2021 23:14:15 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id t8sm10813622pgk.66.2021.10.12.23.14.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Oct 2021 23:14:15 -0700 (PDT) Date: Tue, 12 Oct 2021 23:14:14 -0700 From: Kees Cook To: Christoph Hellwig Message-ID: <202110122314.664187AA@keescook> References: <20211013051042.1065752-1-hch@lst.de> <20211013051042.1065752-10-hch@lst.de> MIME-Version: 1.0 In-Reply-To: <20211013051042.1065752-10-hch@lst.de> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-loop: dm-devel@redhat.com Cc: Dave Kleikamp , jfs-discussion@lists.sourceforge.net, Mike Snitzer , linux-nvme@lists.infradead.org, Konstantin Komarov , Song Liu , dm-devel@redhat.com, target-devel@vger.kernel.org, linux-mtd@lists.infradead.org, reiserfs-devel@vger.kernel.org, drbd-dev@lists.linbit.com, linux-nilfs@vger.kernel.org, linux-scsi@vger.kernel.org, OGAWA Hirofumi , linux-ext4@vger.kernel.org, Josef Bacik , Coly Li , linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, David Sterba , Ryusuke Konishi , Anton Altaparmakov , Jens Axboe , linux-block@vger.kernel.org, linux-nfs@vger.kernel.org, Theodore Ts'o , linux-ntfs-dev@lists.sourceforge.net, Jan Kara , linux-fsdevel@vger.kernel.org, Phillip Lougher , ntfs3@lists.linux.dev, linux-btrfs@vger.kernel.org Subject: Re: [dm-devel] [PATCH 09/29] fs: simplify init_page_buffers X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Oct 13, 2021 at 07:10:22AM +0200, Christoph Hellwig wrote: > No need to convert from bdev to inode and back. > > Signed-off-by: Christoph Hellwig Reviewed-by: Kees Cook -- Kees Cook -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8029C4321E for ; Wed, 13 Oct 2021 06:14:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9849F60C4D for ; Wed, 13 Oct 2021 06:14:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231264AbhJMGQX (ORCPT ); Wed, 13 Oct 2021 02:16:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237413AbhJMGQW (ORCPT ); Wed, 13 Oct 2021 02:16:22 -0400 Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC8E9C061753 for ; Tue, 12 Oct 2021 23:14:15 -0700 (PDT) Received: by mail-pg1-x536.google.com with SMTP id 75so1322874pga.3 for ; Tue, 12 Oct 2021 23:14:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ohUOQyC8vv5S9fFmDSqrC2HGxb4XvUeywx+2/I7KWZo=; b=frRmuaPa3nXR7lxMr1CNNPYB3c6MDWaV+IHcoR+XuNXpKLmcDJudjmJiNd/vJuYFPn yeOjEGluCsqDt4qWvY1oHVWaypcD/6hEY+cvzA7LDBwWjS32G63Wnxe8e0GGmx9dGa0p xQzhoygleJQrWshzo5X8hdFcW2UVxu2kZRAXo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ohUOQyC8vv5S9fFmDSqrC2HGxb4XvUeywx+2/I7KWZo=; b=BltkHcyijeHEFEIiCygmuWyNong4Z2cRbkCDJNFxF60sV3Qex2agdyegdZQlo2tOhO afbUrAqNwmh7z8jN+f7RP57C6kXlXcCs0suAN2V+TINtmXt2u5yLb5HODWD4GMIxgrJH H53uawes1hZfxgwiUhW1SG5+hYR9jl1BLm3Rs1wdnYu4AJ2QX6K+vJkcZ0GPH2ygrS/m +AA4ui+JN+qbGvdJDLaaAF+DJjmcAn7dfFdQePMX925V01RfrUsXuYp4ceF0t23A+Fx2 gfVlsFhddI1h515RG/1B+yrjeLR2pY+Sv3gVhpY4nvWom53wkY/a2B646nFoPUCPgBzp Q5Nw== X-Gm-Message-State: AOAM531WZgMVplGrbRuSftxuttxjOczUxMpNJ7HMtHUKM4Tz6K9aziKa 5E+1VscXpmC+m4qLnaUUIM4UXg== X-Google-Smtp-Source: ABdhPJwNMNbppcyyaPyGGktYQSHeAypT2bIkLVBhhieDA7TSPn60W6m8F7nQfgJZ/E5a6hMyK4Ynow== X-Received: by 2002:a63:e00b:: with SMTP id e11mr26380948pgh.190.1634105655240; Tue, 12 Oct 2021 23:14:15 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id t8sm10813622pgk.66.2021.10.12.23.14.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Oct 2021 23:14:15 -0700 (PDT) Date: Tue, 12 Oct 2021 23:14:14 -0700 From: Kees Cook To: Christoph Hellwig Cc: Jens Axboe , Coly Li , Mike Snitzer , Song Liu , David Sterba , Josef Bacik , Theodore Ts'o , OGAWA Hirofumi , Dave Kleikamp , Ryusuke Konishi , Anton Altaparmakov , Konstantin Komarov , Phillip Lougher , Jan Kara , linux-block@vger.kernel.org, dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev, reiserfs-devel@vger.kernel.org Subject: Re: [PATCH 09/29] fs: simplify init_page_buffers Message-ID: <202110122314.664187AA@keescook> References: <20211013051042.1065752-1-hch@lst.de> <20211013051042.1065752-10-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211013051042.1065752-10-hch@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-bcache@vger.kernel.org On Wed, Oct 13, 2021 at 07:10:22AM +0200, Christoph Hellwig wrote: > No need to convert from bdev to inode and back. > > Signed-off-by: Christoph Hellwig Reviewed-by: Kees Cook -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kees Cook Subject: Re: [PATCH 09/29] fs: simplify init_page_buffers Date: Tue, 12 Oct 2021 23:14:14 -0700 Message-ID: <202110122314.664187AA@keescook> References: <20211013051042.1065752-1-hch@lst.de> <20211013051042.1065752-10-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ohUOQyC8vv5S9fFmDSqrC2HGxb4XvUeywx+2/I7KWZo=; b=frRmuaPa3nXR7lxMr1CNNPYB3c6MDWaV+IHcoR+XuNXpKLmcDJudjmJiNd/vJuYFPn yeOjEGluCsqDt4qWvY1oHVWaypcD/6hEY+cvzA7LDBwWjS32G63Wnxe8e0GGmx9dGa0p xQzhoygleJQrWshzo5X8hdFcW2UVxu2kZRAXo= Content-Disposition: inline In-Reply-To: <20211013051042.1065752-10-hch-jcswGhMUV9g@public.gmane.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: drbd-dev-bounces-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org Errors-To: drbd-dev-bounces-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org To: Christoph Hellwig Cc: Dave Kleikamp , jfs-discussion-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Mike Snitzer , linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Konstantin Komarov , Song Liu , dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, reiserfs-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org, linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, OGAWA Hirofumi , linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Josef Bacik , Coly Li , linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, David Sterba , Ryusuke Konishi , Anton Altaparmakov , Jens Axboe , linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Theodore Ts'o , linux-ntfs-dev-5NWGOfrQmneHXe+LvDLADg@public.gmane.org On Wed, Oct 13, 2021 at 07:10:22AM +0200, Christoph Hellwig wrote: > No need to convert from bdev to inode and back. > > Signed-off-by: Christoph Hellwig Reviewed-by: Kees Cook -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F462C433EF for ; Wed, 13 Oct 2021 07:38:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0956660FDA for ; Wed, 13 Oct 2021 07:38:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0956660FDA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=W1pyAXccDx7SLl6Em66e8sAzp+pyjimyxT6WFbbYrX4=; b=yWGcTJLOM+1O/n Ydj0G/RaeQjrJiqgIw4ezeoN6MbkBHJzB5f8NEi5GjoaaBy8gp0ybjIJzYRRn1zlZCJPe9oyaHvMn 5ujzVv1kWqAq2ovm+FceX73Vc4xVQe7IFL1Z1Giqd7WcNhu5fXyn7zWrq3H2rDl14xOVuM0mRoEu0 3NhZDhl8gVmqdIHS75iq/KjNsUZblMY/bNqikrxkVPic9+hAVMdWNVcToeUO9WqJ7V8VmAGJtwRhW a5zrRcyzAFShMejJnSIvItyaF4+w5Wuhmt4IFv1wofEvWETG2xnll0WeAI8QuoeOXPsjpFmgQMbSx JKepg4FeKm6uZdDB9j6w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1maYq9-00FPIx-1s; Wed, 13 Oct 2021 07:38:17 +0000 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1maXWq-00F6oW-0a for linux-mtd@lists.infradead.org; Wed, 13 Oct 2021 06:14:18 +0000 Received: by mail-pg1-x536.google.com with SMTP id r2so1292065pgl.10 for ; Tue, 12 Oct 2021 23:14:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ohUOQyC8vv5S9fFmDSqrC2HGxb4XvUeywx+2/I7KWZo=; b=frRmuaPa3nXR7lxMr1CNNPYB3c6MDWaV+IHcoR+XuNXpKLmcDJudjmJiNd/vJuYFPn yeOjEGluCsqDt4qWvY1oHVWaypcD/6hEY+cvzA7LDBwWjS32G63Wnxe8e0GGmx9dGa0p xQzhoygleJQrWshzo5X8hdFcW2UVxu2kZRAXo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ohUOQyC8vv5S9fFmDSqrC2HGxb4XvUeywx+2/I7KWZo=; b=FF75oQ7ThvEAXdbMJeKhvfTd9gc8IzsPQXnbmJK6vKcsacB9WP+wVW7aVz+f7x0lb6 N3gIbsDxRzCZ5Z72i2xV2F+Tm74hcxWKHEgMD0HNixrf4PSNtWx5pIhmtXHJWHk6dgaT dphpMB36UoyA30giCJQeQQOidlr28S2jgYVgRuBkVrs1IsviDRD3X+DhXXUCVkYftZOu T2z18y2TfIqUJbpa0R7DA7AEMUC4MWIQvlSypiSJJm3WBSncSeXCwd4eUYj1IybXG1mR J2ZEfoGhNsfTqQFgsvYnovp0azJO0IxVe7nSC/+aENgW2Z6poHZneChEYH0V781Vclc7 z1WQ== X-Gm-Message-State: AOAM5338fm6XVLX1uqbkYJ5uKA/Ya52jXY6cZsgTq6DJFFFHJMPeJeRP Tb3m1RfjT0IuzvzVzbbjiIVYDg== X-Google-Smtp-Source: ABdhPJwNMNbppcyyaPyGGktYQSHeAypT2bIkLVBhhieDA7TSPn60W6m8F7nQfgJZ/E5a6hMyK4Ynow== X-Received: by 2002:a63:e00b:: with SMTP id e11mr26380948pgh.190.1634105655240; Tue, 12 Oct 2021 23:14:15 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id t8sm10813622pgk.66.2021.10.12.23.14.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Oct 2021 23:14:15 -0700 (PDT) Date: Tue, 12 Oct 2021 23:14:14 -0700 From: Kees Cook To: Christoph Hellwig Cc: Jens Axboe , Coly Li , Mike Snitzer , Song Liu , David Sterba , Josef Bacik , Theodore Ts'o , OGAWA Hirofumi , Dave Kleikamp , Ryusuke Konishi , Anton Altaparmakov , Konstantin Komarov , Phillip Lougher , Jan Kara , linux-block@vger.kernel.org, dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev, reiserfs-devel@vger.kernel.org Subject: Re: [PATCH 09/29] fs: simplify init_page_buffers Message-ID: <202110122314.664187AA@keescook> References: <20211013051042.1065752-1-hch@lst.de> <20211013051042.1065752-10-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211013051042.1065752-10-hch@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211012_231416_100673_C76A8655 X-CRM114-Status: GOOD ( 10.61 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Wed, Oct 13, 2021 at 07:10:22AM +0200, Christoph Hellwig wrote: > No need to convert from bdev to inode and back. > > Signed-off-by: Christoph Hellwig Reviewed-by: Kees Cook -- Kees Cook ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B27BC433EF for ; Wed, 13 Oct 2021 09:08:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2ECDA60462 for ; Wed, 13 Oct 2021 09:08:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2ECDA60462 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IjAKtqGDDa3uhliDar91jFObpb2m+JyeilGzBU+fizM=; b=yj8+jikWHzVnis eAFirTB+t3TKCw/esVfL3a4u9FkYWNqj8JQ86cWVOpNzTtIIqnzRorl886h78sEZ3mdPny4WI5F1i rA/jDmCYiqD/DRPf2vavSUZNxi9g0OwR8PcbQNuKy/ZfIboshOck67e8Wc9SvUv6yKsm6lWhyirfq 4mgBc5lvwD81E1VxFiyT4qxwjzi7svJojtGTxHW8S8G57NIQ71DRKNGz3NWM+cjoX5Xdc8Sky3+qU o7ZuTxck2inSqWDC8nvUdv9Srw00YifIGxP2nHTFGbYfDlOQI19h3W906zOdCj6zGEPTDhHRbwgFb TfRynvuiJOZwe+GlG66Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1maaEe-00FiFd-BU; Wed, 13 Oct 2021 09:07:40 +0000 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1maXWq-00F6oX-7a for linux-nvme@lists.infradead.org; Wed, 13 Oct 2021 06:14:18 +0000 Received: by mail-pg1-x532.google.com with SMTP id a73so1347255pge.0 for ; Tue, 12 Oct 2021 23:14:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ohUOQyC8vv5S9fFmDSqrC2HGxb4XvUeywx+2/I7KWZo=; b=frRmuaPa3nXR7lxMr1CNNPYB3c6MDWaV+IHcoR+XuNXpKLmcDJudjmJiNd/vJuYFPn yeOjEGluCsqDt4qWvY1oHVWaypcD/6hEY+cvzA7LDBwWjS32G63Wnxe8e0GGmx9dGa0p xQzhoygleJQrWshzo5X8hdFcW2UVxu2kZRAXo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ohUOQyC8vv5S9fFmDSqrC2HGxb4XvUeywx+2/I7KWZo=; b=Trf6T/Ii/6bCoVbzOFMYHu5B6qbxYZXjG/AISEhMpddbbYnuScI2KxKpzM6rleG91b BYUqc9Cu/6IijlpDwR1aXxnW+fIaiFLdvJB/k0gkdR6YC0EDbV4j+U+gR4xtL8hHXYXW iaqGBi0nT23ldezTDBKglheNTGGCZdwNnKhJKPps8TlMaJhvL7fP/8TzaRGQ35etHQ17 cb9VE6iSouRrnehIl/iY0pTm/0Ogk1NdtNVFt1aAX8CmHGLrSD/SeVI5rLDmUYHzcL2E uahlOsDd9TplBs2SZwU3EuZGM1yVAdiRKyZ03vUR9BOSmnuo0RG+MFg+fYrb/vjaTRZf x1GA== X-Gm-Message-State: AOAM533ozzxavTTHz73mwYbdNUTm/ImczDYv4l8urMZsNpYQyn293upz 6eCV7d+bq6ZUMS9fR/9saTwhWQ== X-Google-Smtp-Source: ABdhPJwNMNbppcyyaPyGGktYQSHeAypT2bIkLVBhhieDA7TSPn60W6m8F7nQfgJZ/E5a6hMyK4Ynow== X-Received: by 2002:a63:e00b:: with SMTP id e11mr26380948pgh.190.1634105655240; Tue, 12 Oct 2021 23:14:15 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id t8sm10813622pgk.66.2021.10.12.23.14.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Oct 2021 23:14:15 -0700 (PDT) Date: Tue, 12 Oct 2021 23:14:14 -0700 From: Kees Cook To: Christoph Hellwig Cc: Jens Axboe , Coly Li , Mike Snitzer , Song Liu , David Sterba , Josef Bacik , Theodore Ts'o , OGAWA Hirofumi , Dave Kleikamp , Ryusuke Konishi , Anton Altaparmakov , Konstantin Komarov , Phillip Lougher , Jan Kara , linux-block@vger.kernel.org, dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev, reiserfs-devel@vger.kernel.org Subject: Re: [PATCH 09/29] fs: simplify init_page_buffers Message-ID: <202110122314.664187AA@keescook> References: <20211013051042.1065752-1-hch@lst.de> <20211013051042.1065752-10-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211013051042.1065752-10-hch@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211012_231416_300993_59201E82 X-CRM114-Status: GOOD ( 11.24 ) X-Mailman-Approved-At: Wed, 13 Oct 2021 01:15:58 -0700 X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Wed, Oct 13, 2021 at 07:10:22AM +0200, Christoph Hellwig wrote: > No need to convert from bdev to inode and back. > > Signed-off-by: Christoph Hellwig Reviewed-by: Kees Cook -- Kees Cook _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id 3B945420FDF for ; Wed, 13 Oct 2021 08:14:16 +0200 (CEST) Received: by mail-pg1-f177.google.com with SMTP id r2so1292066pgl.10 for ; Tue, 12 Oct 2021 23:14:15 -0700 (PDT) Date: Tue, 12 Oct 2021 23:14:14 -0700 From: Kees Cook To: Christoph Hellwig Message-ID: <202110122314.664187AA@keescook> References: <20211013051042.1065752-1-hch@lst.de> <20211013051042.1065752-10-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211013051042.1065752-10-hch@lst.de> Cc: Dave Kleikamp , jfs-discussion@lists.sourceforge.net, Mike Snitzer , linux-nvme@lists.infradead.org, Konstantin Komarov , Song Liu , dm-devel@redhat.com, target-devel@vger.kernel.org, linux-mtd@lists.infradead.org, reiserfs-devel@vger.kernel.org, drbd-dev@lists.linbit.com, linux-nilfs@vger.kernel.org, linux-scsi@vger.kernel.org, OGAWA Hirofumi , linux-ext4@vger.kernel.org, Josef Bacik , Coly Li , linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, David Sterba , Ryusuke Konishi , Anton Altaparmakov , Jens Axboe , linux-block@vger.kernel.org, linux-nfs@vger.kernel.org, Theodore Ts'o , linux-ntfs-dev@lists.sourceforge.net, Jan Kara , linux-fsdevel@vger.kernel.org, Phillip Lougher , ntfs3@lists.linux.dev, linux-btrfs@vger.kernel.org Subject: Re: [Drbd-dev] [PATCH 09/29] fs: simplify init_page_buffers List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Oct 13, 2021 at 07:10:22AM +0200, Christoph Hellwig wrote: > No need to convert from bdev to inode and back. > > Signed-off-by: Christoph Hellwig Reviewed-by: Kees Cook -- Kees Cook