From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82489C433FE for ; Wed, 13 Oct 2021 06:16:50 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C3EF60C4D for ; Wed, 13 Oct 2021 06:16:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1C3EF60C4D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-213-uHiO9qPjMK-DmeaSR1Y1RA-1; Wed, 13 Oct 2021 02:16:45 -0400 X-MC-Unique: uHiO9qPjMK-DmeaSR1Y1RA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2BD7C802588; Wed, 13 Oct 2021 06:16:41 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E2CD85BAE2; Wed, 13 Oct 2021 06:16:40 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B1BF91806D00; Wed, 13 Oct 2021 06:16:40 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 19D6Gcck028407 for ; Wed, 13 Oct 2021 02:16:39 -0400 Received: by smtp.corp.redhat.com (Postfix) id BB5B640CFD10; Wed, 13 Oct 2021 06:16:38 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B56EE40CFD04 for ; Wed, 13 Oct 2021 06:16:38 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9CBBF100E658 for ; Wed, 13 Oct 2021 06:16:38 +0000 (UTC) Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-464-2SLFO267PwqODPR31h5Low-1; Wed, 13 Oct 2021 02:16:36 -0400 X-MC-Unique: 2SLFO267PwqODPR31h5Low-1 Received: by mail-pj1-f42.google.com with SMTP id lk8-20020a17090b33c800b001a0a284fcc2so3618293pjb.2 for ; Tue, 12 Oct 2021 23:16:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yoKDGyU1IKw4WZcPglkL9qCJyXlf9awotx8P2PTzBWs=; b=StUECv3NL8KLIPAHEZJaCAdfZgdP4lruVrq5Vh9SLVFvc1G7AYoMziu1+ZwaNlIkjx SNlUxEDWlKPJS3+Tpn3bra7DMHBP1yEH5dkebgCMoy5G9PFc21uCXiBcCdRH1LXnchn6 XCNOs3bVr7b71QTHq6u9qQYZKOO2uqleh3FldYCalfq4KXB3h0P7b7yegcPQwCGV0SSG ee0tZKY58SZyHo341qC4mHk1esm2dK+m1jpTbYl/u1dKgs2BPEG7diaEDnSZLe5VB9Mm gW9b542l1cHvFUM2S6COP++YXbNCuntkx5rlqwtcaY/nA6pJFOs2HCSlt2PUXa5J2wdP RT4Q== X-Gm-Message-State: AOAM531GGl8SAM0agSP5EGLYp27gKFbO+nozCx7uMXlQaqy4dBaQJTAh PRgrrLD0CsctrtHaYTZCrmumGg== X-Google-Smtp-Source: ABdhPJxLGyOml5lqe+K0AfHsTHYJz8Z1ysoHhzc/2/LGB5MqaATX0lTpa7QxWtRvvD8zMko7cBuZVA== X-Received: by 2002:a17:90b:3850:: with SMTP id nl16mr11065306pjb.127.1634105795098; Tue, 12 Oct 2021 23:16:35 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id c11sm4509497pji.38.2021.10.12.23.16.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Oct 2021 23:16:34 -0700 (PDT) Date: Tue, 12 Oct 2021 23:16:34 -0700 From: Kees Cook To: Christoph Hellwig Message-ID: <202110122316.8ED0742@keescook> References: <20211013051042.1065752-1-hch@lst.de> <20211013051042.1065752-14-hch@lst.de> MIME-Version: 1.0 In-Reply-To: <20211013051042.1065752-14-hch@lst.de> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-loop: dm-devel@redhat.com Cc: Dave Kleikamp , jfs-discussion@lists.sourceforge.net, Mike Snitzer , linux-nvme@lists.infradead.org, Konstantin Komarov , Song Liu , dm-devel@redhat.com, target-devel@vger.kernel.org, linux-mtd@lists.infradead.org, reiserfs-devel@vger.kernel.org, drbd-dev@lists.linbit.com, linux-nilfs@vger.kernel.org, linux-scsi@vger.kernel.org, OGAWA Hirofumi , linux-ext4@vger.kernel.org, Josef Bacik , Coly Li , linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, David Sterba , Ryusuke Konishi , Anton Altaparmakov , Jens Axboe , linux-block@vger.kernel.org, linux-nfs@vger.kernel.org, Theodore Ts'o , linux-ntfs-dev@lists.sourceforge.net, Jan Kara , linux-fsdevel@vger.kernel.org, Phillip Lougher , ntfs3@lists.linux.dev, linux-btrfs@vger.kernel.org Subject: Re: [dm-devel] [PATCH 13/29] fat: use bdev_nr_sectors instead of open coding it X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Oct 13, 2021 at 07:10:26AM +0200, Christoph Hellwig wrote: > Use the proper helper to read the block device size. > > Signed-off-by: Christoph Hellwig Reviewed-by: Kees Cook -- Kees Cook -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33B32C4167B for ; Wed, 13 Oct 2021 06:16:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1732E60C4D for ; Wed, 13 Oct 2021 06:16:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237413AbhJMGSk (ORCPT ); Wed, 13 Oct 2021 02:18:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237916AbhJMGSi (ORCPT ); Wed, 13 Oct 2021 02:18:38 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84AA6C061762 for ; Tue, 12 Oct 2021 23:16:35 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id ls18-20020a17090b351200b001a00250584aso3599307pjb.4 for ; Tue, 12 Oct 2021 23:16:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yoKDGyU1IKw4WZcPglkL9qCJyXlf9awotx8P2PTzBWs=; b=CfsfnomPleYW4GBsBhk8H6G76FqS7CJ1hCWsqRQNWdP3gBxNE2zoVJGIUrEHECfVKa v2cK96TEo8Mw5Ik4Y/ADCAfA/3y7sebWHT8J/KK4oeu3vgk08FAOGIJ4+lA7q9hiMA29 r2H7qpegYylGn4mcpKE0+qgwtq9QgI8dolIgs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yoKDGyU1IKw4WZcPglkL9qCJyXlf9awotx8P2PTzBWs=; b=5sgxNATQF0+d37og/HO6wWMitk/WuM4rIv5KPlrtCtrzexRYV/VZgtOdlAnjrgQliE YnIzObfADjey0DBPJoZGz0bdkyVFpISYsK54k7DXInnjNqFDQ8jPTl261u1+QgS6uuQw YkkzK/rjUmi7qw1vBaPmi9tKABkfbe9Nn41UF6gApHqYJTPOmtkxNeusKHcWOuAkb6Bc Ev2iPdw83oOjpK+btFzPyg4lauXhhjR/ixrKzYLJvl6JxM+36/CHzIJFOH+9MEZ6Sap6 3aoHeu5bYrZ9NXUS6+2WaeLi7yuaiaY4liAK2LFk9F2QTp602WP+0xnWJ+EU06oBT3Qh Sgcg== X-Gm-Message-State: AOAM532+dI6C2RhmplAVH7ws6oE5uTrVmFNUjkMXZhViAscNK6310yPZ wlVwPgOc8MbjHtfj9XhLY+t6wQ== X-Google-Smtp-Source: ABdhPJxLGyOml5lqe+K0AfHsTHYJz8Z1ysoHhzc/2/LGB5MqaATX0lTpa7QxWtRvvD8zMko7cBuZVA== X-Received: by 2002:a17:90b:3850:: with SMTP id nl16mr11065306pjb.127.1634105795098; Tue, 12 Oct 2021 23:16:35 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id c11sm4509497pji.38.2021.10.12.23.16.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Oct 2021 23:16:34 -0700 (PDT) Date: Tue, 12 Oct 2021 23:16:34 -0700 From: Kees Cook To: Christoph Hellwig Cc: Jens Axboe , Coly Li , Mike Snitzer , Song Liu , David Sterba , Josef Bacik , Theodore Ts'o , OGAWA Hirofumi , Dave Kleikamp , Ryusuke Konishi , Anton Altaparmakov , Konstantin Komarov , Phillip Lougher , Jan Kara , linux-block@vger.kernel.org, dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev, reiserfs-devel@vger.kernel.org Subject: Re: [PATCH 13/29] fat: use bdev_nr_sectors instead of open coding it Message-ID: <202110122316.8ED0742@keescook> References: <20211013051042.1065752-1-hch@lst.de> <20211013051042.1065752-14-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211013051042.1065752-14-hch@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-bcache@vger.kernel.org On Wed, Oct 13, 2021 at 07:10:26AM +0200, Christoph Hellwig wrote: > Use the proper helper to read the block device size. > > Signed-off-by: Christoph Hellwig Reviewed-by: Kees Cook -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kees Cook Subject: Re: [PATCH 13/29] fat: use bdev_nr_sectors instead of open coding it Date: Tue, 12 Oct 2021 23:16:34 -0700 Message-ID: <202110122316.8ED0742@keescook> References: <20211013051042.1065752-1-hch@lst.de> <20211013051042.1065752-14-hch@lst.de> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yoKDGyU1IKw4WZcPglkL9qCJyXlf9awotx8P2PTzBWs=; b=CfsfnomPleYW4GBsBhk8H6G76FqS7CJ1hCWsqRQNWdP3gBxNE2zoVJGIUrEHECfVKa v2cK96TEo8Mw5Ik4Y/ADCAfA/3y7sebWHT8J/KK4oeu3vgk08FAOGIJ4+lA7q9hiMA29 r2H7qpegYylGn4mcpKE0+qgwtq9QgI8dolIgs= Content-Disposition: inline In-Reply-To: <20211013051042.1065752-14-hch-jcswGhMUV9g@public.gmane.org> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christoph Hellwig Cc: Jens Axboe , Coly Li , Mike Snitzer , Song Liu , David Sterba , Josef Bacik , Theodore Ts'o , OGAWA Hirofumi , Dave Kleikamp , Ryusuke Konishi , Anton Altaparmakov , Konstantin Komarov , Phillip Lougher , Jan Kara , linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org, linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Wed, Oct 13, 2021 at 07:10:26AM +0200, Christoph Hellwig wrote: > Use the proper helper to read the block device size. > > Signed-off-by: Christoph Hellwig Reviewed-by: Kees Cook -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5564FC433EF for ; Wed, 13 Oct 2021 07:43:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 16FB460EDF for ; Wed, 13 Oct 2021 07:43:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 16FB460EDF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KR6y238g6OKl6n9ayzm9Z1cQfuDcEdqYagrqkbeTzUI=; b=ZTPgYAJ7bKv8lk 2SWk+yEn1eus2TRHKdgzYkpemjA2gv8ogAAfBUAoKt3+FgHl6o8uSXqIMe1g569lTtQKchF3Dk1H/ Gqg2ZlYOuSJLudnraSWKaUISngwW2NHhSpjOqKw/DTZNItJG7vwNDzRNse2oEIekl2tYqkZxiX+CU xRVYC3aV0tPHD0uMLKwyZItX28UzvO3DLcGQwfRoVRUp6uht5ndhuqWcT4xfppl/T3QZWTBJmowT5 Fian2YE0RlcLyLk3gfRIbDEmj9ZdBbzUE+yP7r5Cf0M4Ifhf9KuRqSzCP7ORChHVo9SzKbp6llkKN em0T28z6YxdjWHdTdx3Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1maYuz-00FQXN-EG; Wed, 13 Oct 2021 07:43:17 +0000 Received: from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1maXZ5-00F7Ke-S6 for linux-mtd@lists.infradead.org; Wed, 13 Oct 2021 06:16:37 +0000 Received: by mail-pj1-x1033.google.com with SMTP id lk8-20020a17090b33c800b001a0a284fcc2so3618294pjb.2 for ; Tue, 12 Oct 2021 23:16:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yoKDGyU1IKw4WZcPglkL9qCJyXlf9awotx8P2PTzBWs=; b=CfsfnomPleYW4GBsBhk8H6G76FqS7CJ1hCWsqRQNWdP3gBxNE2zoVJGIUrEHECfVKa v2cK96TEo8Mw5Ik4Y/ADCAfA/3y7sebWHT8J/KK4oeu3vgk08FAOGIJ4+lA7q9hiMA29 r2H7qpegYylGn4mcpKE0+qgwtq9QgI8dolIgs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yoKDGyU1IKw4WZcPglkL9qCJyXlf9awotx8P2PTzBWs=; b=dHdxUioI6mWVDe+/p1cXMoJacCY8AUJ37PCAYsRnThMxUdfWRATFlmuxAv+Zf5f6qH HIMnQfzfM6QEAc4j1vVh6AgOJY5/cmrsUtDozKtubFrxyw+Ko/d0H4vLxgLQTftxlZAW gZRJLZVltH27QArp62nv0meJrzJunGxIJvQ1rxy3KebAxRn6YX8WrJ6zoYet492rYEH7 Y6vGzuzQlctM3EpoCebW3FzSvaF4ZOsPqB0a5HXT5sV6HmnywkyxNAfRFLAM680uvCJH 1YCto51LOI5JnRX0pRewSnm1x9gotogybTNwZPjJmqaCtrcFjn/GKEtTD+wzGpKFQw8b QHwQ== X-Gm-Message-State: AOAM530aeBHKvjhmy4YllHXAH2mCjIGf+21kpYtOTppmOQ3kx7XkaE4n 9cGQciRLp1UablOTqwWo+IKJ0A== X-Google-Smtp-Source: ABdhPJxLGyOml5lqe+K0AfHsTHYJz8Z1ysoHhzc/2/LGB5MqaATX0lTpa7QxWtRvvD8zMko7cBuZVA== X-Received: by 2002:a17:90b:3850:: with SMTP id nl16mr11065306pjb.127.1634105795098; Tue, 12 Oct 2021 23:16:35 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id c11sm4509497pji.38.2021.10.12.23.16.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Oct 2021 23:16:34 -0700 (PDT) Date: Tue, 12 Oct 2021 23:16:34 -0700 From: Kees Cook To: Christoph Hellwig Cc: Jens Axboe , Coly Li , Mike Snitzer , Song Liu , David Sterba , Josef Bacik , Theodore Ts'o , OGAWA Hirofumi , Dave Kleikamp , Ryusuke Konishi , Anton Altaparmakov , Konstantin Komarov , Phillip Lougher , Jan Kara , linux-block@vger.kernel.org, dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev, reiserfs-devel@vger.kernel.org Subject: Re: [PATCH 13/29] fat: use bdev_nr_sectors instead of open coding it Message-ID: <202110122316.8ED0742@keescook> References: <20211013051042.1065752-1-hch@lst.de> <20211013051042.1065752-14-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211013051042.1065752-14-hch@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211012_231636_019794_A474A782 X-CRM114-Status: GOOD ( 11.67 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Wed, Oct 13, 2021 at 07:10:26AM +0200, Christoph Hellwig wrote: > Use the proper helper to read the block device size. > > Signed-off-by: Christoph Hellwig Reviewed-by: Kees Cook -- Kees Cook ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 106E1C433EF for ; Wed, 13 Oct 2021 09:12:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C37BD60524 for ; Wed, 13 Oct 2021 09:12:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C37BD60524 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EjL61VVMPXrCCs2TcOppWl7L2Ek9ijRG3SgOen7F6zs=; b=qeeiqB0QezoQu7 4XWu3EfHsOXv+Fkh04nPS9bciYbHCVVf29rxF57YWxWrPijjv+x9PS7iI8amIgsHKl3QMusXZU6y2 /6drIzhPiWZPL7eG0AlLboJxgnCvgLLDvdQyUyzs3CJBC+xxj/mSc24lTHVKkbD+HLYHHRNQahAF1 r2AUDdG98mqoRirrP2GI1TR00GWZOXSkgHgEw0BqCXMi8dIZgDGs/AUXRCneZLg4FuAR5t5wg5z22 FrAFqZC+4dBF0MmYgN+pc4dKd96Cr9OZbYmVkakWYsAakloWXSWLi29KA+lRTpSQAD4fnTSUa6I+r VVHADEQw9DtKQMC2QOwg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1maaJR-00Fj9J-UM; Wed, 13 Oct 2021 09:12:38 +0000 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1maXZ5-00F7Kd-S2 for linux-nvme@lists.infradead.org; Wed, 13 Oct 2021 06:16:37 +0000 Received: by mail-pl1-x62c.google.com with SMTP id f21so1102019plb.3 for ; Tue, 12 Oct 2021 23:16:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yoKDGyU1IKw4WZcPglkL9qCJyXlf9awotx8P2PTzBWs=; b=CfsfnomPleYW4GBsBhk8H6G76FqS7CJ1hCWsqRQNWdP3gBxNE2zoVJGIUrEHECfVKa v2cK96TEo8Mw5Ik4Y/ADCAfA/3y7sebWHT8J/KK4oeu3vgk08FAOGIJ4+lA7q9hiMA29 r2H7qpegYylGn4mcpKE0+qgwtq9QgI8dolIgs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yoKDGyU1IKw4WZcPglkL9qCJyXlf9awotx8P2PTzBWs=; b=VDZx7KumabHTZ50p3y8oHSPC+OcSMYO6hI5GG9UA2Pmhs7ZaKrvt5Iqobcu25BmXBR LW9s7enErm0vX0QVFmy9F+0ZQzbnYEyAD90HE5gAHFus6GG2k8vjuFYjwFjKr+K0j2BF QOcJ/ufOpw169B9ynDPG6AfwSLvqMrC6oa1XJvkGcbuFmTxRmCAnCrWuI8H2FsArDh4X lnYVfgqvb2HGo4F0Cm0wxiqKVJL0K2oCBTGG4hQELrjNEdy6sY545Wbjb82Z4ejC0HNy XM7KrylOD+du1ml3KualSSjj9GM6sFH0rUGU8xnE8efW2OooyXws94AHCPIVxRDmJY4J XxeA== X-Gm-Message-State: AOAM531eo+j+r6oKPEwBF6bnwPV2XXdXY5yn238flO3h1k/Mj89q+ZU0 yDGZGJ+Cji36jSc7MpKYIT1l5w== X-Google-Smtp-Source: ABdhPJxLGyOml5lqe+K0AfHsTHYJz8Z1ysoHhzc/2/LGB5MqaATX0lTpa7QxWtRvvD8zMko7cBuZVA== X-Received: by 2002:a17:90b:3850:: with SMTP id nl16mr11065306pjb.127.1634105795098; Tue, 12 Oct 2021 23:16:35 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id c11sm4509497pji.38.2021.10.12.23.16.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Oct 2021 23:16:34 -0700 (PDT) Date: Tue, 12 Oct 2021 23:16:34 -0700 From: Kees Cook To: Christoph Hellwig Cc: Jens Axboe , Coly Li , Mike Snitzer , Song Liu , David Sterba , Josef Bacik , Theodore Ts'o , OGAWA Hirofumi , Dave Kleikamp , Ryusuke Konishi , Anton Altaparmakov , Konstantin Komarov , Phillip Lougher , Jan Kara , linux-block@vger.kernel.org, dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev, reiserfs-devel@vger.kernel.org Subject: Re: [PATCH 13/29] fat: use bdev_nr_sectors instead of open coding it Message-ID: <202110122316.8ED0742@keescook> References: <20211013051042.1065752-1-hch@lst.de> <20211013051042.1065752-14-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211013051042.1065752-14-hch@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211012_231636_019788_37DB360A X-CRM114-Status: GOOD ( 12.30 ) X-Mailman-Approved-At: Wed, 13 Oct 2021 01:15:58 -0700 X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Wed, Oct 13, 2021 at 07:10:26AM +0200, Christoph Hellwig wrote: > Use the proper helper to read the block device size. > > Signed-off-by: Christoph Hellwig Reviewed-by: Kees Cook -- Kees Cook _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id 32144420FED for ; Wed, 13 Oct 2021 08:16:35 +0200 (CEST) Received: by mail-pl1-f173.google.com with SMTP id t11so1076775plq.11 for ; Tue, 12 Oct 2021 23:16:35 -0700 (PDT) Date: Tue, 12 Oct 2021 23:16:34 -0700 From: Kees Cook To: Christoph Hellwig Message-ID: <202110122316.8ED0742@keescook> References: <20211013051042.1065752-1-hch@lst.de> <20211013051042.1065752-14-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211013051042.1065752-14-hch@lst.de> Cc: Dave Kleikamp , jfs-discussion@lists.sourceforge.net, Mike Snitzer , linux-nvme@lists.infradead.org, Konstantin Komarov , Song Liu , dm-devel@redhat.com, target-devel@vger.kernel.org, linux-mtd@lists.infradead.org, reiserfs-devel@vger.kernel.org, drbd-dev@lists.linbit.com, linux-nilfs@vger.kernel.org, linux-scsi@vger.kernel.org, OGAWA Hirofumi , linux-ext4@vger.kernel.org, Josef Bacik , Coly Li , linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, David Sterba , Ryusuke Konishi , Anton Altaparmakov , Jens Axboe , linux-block@vger.kernel.org, linux-nfs@vger.kernel.org, Theodore Ts'o , linux-ntfs-dev@lists.sourceforge.net, Jan Kara , linux-fsdevel@vger.kernel.org, Phillip Lougher , ntfs3@lists.linux.dev, linux-btrfs@vger.kernel.org Subject: Re: [Drbd-dev] [PATCH 13/29] fat: use bdev_nr_sectors instead of open coding it List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Oct 13, 2021 at 07:10:26AM +0200, Christoph Hellwig wrote: > Use the proper helper to read the block device size. > > Signed-off-by: Christoph Hellwig Reviewed-by: Kees Cook -- Kees Cook