From: Herve Codina <herve.codina@bootlin.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/dtbocfg: add missing comment about kernel dependency
Date: Wed, 13 Oct 2021 18:33:30 +0200 [thread overview]
Message-ID: <20211013183330.7374b348@bootlin.com> (raw)
In-Reply-To: <20211013162410.520492-1-yann.morin.1998@free.fr>
Hi Yann, Fabrice,
On Wed, 13 Oct 2021 18:24:10 +0200
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> Commit b00b9c865d21 (package/dtbocfg: depends on kernel) forgot to add a
> comment when the kernel is not enabled.
>
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> Cc: Herve Codina <herve.codina@bootlin.com>
> ---
> package/dtbocfg/Config.in | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/package/dtbocfg/Config.in b/package/dtbocfg/Config.in
> index 862dc0ccc5..2b2a8538a3 100644
> --- a/package/dtbocfg/Config.in
> +++ b/package/dtbocfg/Config.in
> @@ -7,3 +7,6 @@ config BR2_PACKAGE_DTBOCFG
> as a userspace API of Device Tree Overlay.
>
> https://github.com/ikwzm/dtbocfg
> +
> +comment "dtbocfg needs a kernel to be built"
> + depends on !BR2_LINUX_KERNEL
I think the right sentence is "dtbocfg needs a Linux kernel to be built"
(ie s/a kernel/a Linux kernel/)
Best regards,
Herve
--
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-10-13 16:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 16:24 [Buildroot] [PATCH] package/dtbocfg: add missing comment about kernel dependency Yann E. MORIN
2021-10-13 16:33 ` Herve Codina [this message]
2021-10-16 7:36 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211013183330.7374b348@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.