From: Drew Fustini <dfustini@baylibre.com>
To: Johan Hovold <johan@kernel.org>
Cc: Benoit Cousson <bcousson@baylibre.com>,
Dave Gerlach <d-gerlach@ti.com>, Keerthy <j-keerthy@ti.com>,
Tony Lindgren <tony@atomide.com>,
Rob Herring <robh+dt@kernel.org>,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: am335x: Add rtc node as system-power-controller
Date: Wed, 13 Oct 2021 14:41:03 -0700 [thread overview]
Message-ID: <20211013214103.GA10628@x1> (raw)
In-Reply-To: <YWaJfofs8QAtBnVu@hovoldconsulting.com>
On Wed, Oct 13, 2021 at 09:23:42AM +0200, Johan Hovold wrote:
> On Tue, Oct 12, 2021 at 12:13:12PM -0700, Drew Fustini wrote:
> > From: Keerthy <j-keerthy@ti.com>
> >
> > PMIC_PWR_EN pin of RTC on am335x-evm, bone, and boneblack is connected to
> > PMIC on board, so flag rtc node as system-power-controller to allow
> > software to poweroff boards.
>
> The "system-power-controller" property is already set in
> bone-common.dtsi since
>
> 2876cc4a773c ("ARM: dts: Move most of am335x-boneblack.dts to am335x-boneblack-common.dtsi")
>
> so this probably only affects am335x-evm and that should be reflected in
> the commit message.
>
> Also, should you now remove the property from boneblack-common? Or just
> add it to am335x-evm instead?
Thank you for reviewing. Yes, I should improve the commit message as the
BeagleBone Black is already covered for the rtc system-power-controller
in am335x-boneblack-common.dtsi.
I believe it would be ok to remove system-power-controller from
am335x-boneblack-common.dtsi and have it in am335x-bone-common.dtsi.
These are the files that include am335x-boneblack-common.dtsi:
arch/arm/boot/dts/am335x-boneblack-wireless.dts
arch/arm/boot/dts/am335x-boneblack.dts
arch/arm/boot/dts/am335x-sancloud-bbe-lite.dts
arch/arm/boot/dts/am335x-sancloud-bbe.dts
But they all also include am335x-bone-common.dtsi.
However, I just noticed that am335x-evm.dts does not include either
am335x-boneblack-common.dtsi or am335x-boneblack-common.dtsi. Thus
rtc system-power-controller should be directly inserted into
am335x-evm.dts.
I considered just moving system-power-controller to the rtc node in
am33xx-l4.dtsi but I don't think that would be correct as this would not
be valid for all am33xx devices.
Does that seem correct to you?
Thank you,
Drew
next prev parent reply other threads:[~2021-10-13 21:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 19:13 [PATCH] ARM: dts: am335x: Add rtc node as system-power-controller Drew Fustini
2021-10-13 7:23 ` Johan Hovold
2021-10-13 21:41 ` Drew Fustini [this message]
2021-10-14 10:42 ` Johan Hovold
[not found] ` <CA+T6QPkUSJZ9Pb8JvfuVuGzfv0cX-HQcT3eALN5Y9882r676MA@mail.gmail.com>
2021-10-16 5:04 ` Drew Fustini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211013214103.GA10628@x1 \
--to=dfustini@baylibre.com \
--cc=bcousson@baylibre.com \
--cc=d-gerlach@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=j-keerthy@ti.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.