From: SeongJae Park <sj@kernel.org>
To: Rongwei Wang <rongwei.wang@linux.alibaba.com>
Cc: sj@kernel.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v2] mm/damon/dbgfs: remove unnecessary variables
Date: Thu, 14 Oct 2021 07:21:58 +0000 [thread overview]
Message-ID: <20211014072158.35478-1-sj@kernel.org> (raw)
In-Reply-To: <20211014020333.10330-1-rongwei.wang@linux.alibaba.com>
On Thu, 14 Oct 2021 10:03:33 +0800 Rongwei Wang <rongwei.wang@linux.alibaba.com> wrote:
> In some functions, it's unnecessary to declare 'err'
> and 'ret' variables at the same time. This patch mainly
> to simplify the issue of such declarations by reusing
> one variable.
>
> Signed-off-by: Rongwei Wang <rongwei.wang@linux.alibaba.com>
Looks good to me. However, this doesn't cleanly applicable on latest -mm tree.
I will post a rebased version as a reply to this.
Thanks,
SJ
[...]
next prev parent reply other threads:[~2021-10-14 7:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 2:03 [PATCH v2] mm/damon/dbgfs: remove unnecessary variables Rongwei Wang
2021-10-14 7:21 ` SeongJae Park [this message]
2021-10-14 7:30 ` [PATCH v3] " SeongJae Park
2021-10-14 7:30 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211014072158.35478-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rongwei.wang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.