From: Christoph Hellwig <hch@lst.de>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] btrfs: update device path inode time instead of bd_inode
Date: Thu, 14 Oct 2021 17:33:47 +0200 [thread overview]
Message-ID: <20211014153347.GA30555@lst.de> (raw)
In-Reply-To: <00b8cf32502e30403b9849a73e62f4ad5175fded.1634224611.git.josef@toxicpanda.com>
On Thu, Oct 14, 2021 at 11:17:08AM -0400, Josef Bacik wrote:
> + now = current_time(d_inode(path.dentry));
> + generic_update_time(d_inode(path.dentry), &now, S_MTIME | S_CTIME);
This is still broken as it won't call into ->update_time.
generic_update_time is a helper/default for ->update_time, not something
for an external caller.
next prev parent reply other threads:[~2021-10-14 15:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 15:17 [PATCH] btrfs: update device path inode time instead of bd_inode Josef Bacik
2021-10-14 15:27 ` David Sterba
2021-10-14 15:33 ` Christoph Hellwig [this message]
2021-10-14 15:50 ` Josef Bacik
2021-10-14 15:53 ` Christoph Hellwig
2021-10-14 16:00 ` Josef Bacik
2021-10-14 16:05 ` Christoph Hellwig
2021-10-14 16:32 ` Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211014153347.GA30555@lst.de \
--to=hch@lst.de \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.