From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41320C4332F for ; Fri, 15 Oct 2021 16:54:39 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A4D8611C3 for ; Fri, 15 Oct 2021 16:54:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7A4D8611C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-331-RswRkjeOMLGFjL21T9ULUQ-1; Fri, 15 Oct 2021 12:54:34 -0400 X-MC-Unique: RswRkjeOMLGFjL21T9ULUQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DD909100D681; Fri, 15 Oct 2021 16:54:29 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 89C6E5C1A3; Fri, 15 Oct 2021 16:54:29 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 317754E590; Fri, 15 Oct 2021 16:54:29 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 19FGs5Su012296 for ; Fri, 15 Oct 2021 12:54:05 -0400 Received: by smtp.corp.redhat.com (Postfix) id 3ACA02026D48; Fri, 15 Oct 2021 16:54:05 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3687D2026D46 for ; Fri, 15 Oct 2021 16:54:05 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 126F9802A5E for ; Fri, 15 Oct 2021 16:54:05 +0000 (UTC) Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-241-j2CQ3sidPTGgdrQemLamiw-1; Fri, 15 Oct 2021 12:54:03 -0400 X-MC-Unique: j2CQ3sidPTGgdrQemLamiw-1 Received: by mail-pf1-f174.google.com with SMTP id q19so8866415pfl.4 for ; Fri, 15 Oct 2021 09:54:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+MbYp/9I6HwSPkAmORgtqKp7aAXKpROAHsI0KkahVSk=; b=ncSoe1Oe4GlFqfOfkZmTY4ai+0SQ6QkMiHCB0Dm7E25oCpfpKk6ftY+FcxuyVH5GBz SfbX/XGUpRvQBy5adbCIMI86/gTAOkn78z08oMZ5hu2gYN5XCbq0gb1G0WEldYFD7g7B HK4IKL3hcRUUo9308BV1ALFgizG6avMtEPAbTdVTEUknDelCOPZy46xfC0dv0NVNPGWd axiAeQ1xK2H9fMVCVe8aI4W0z/vJ1AHOscGtU4CPVLkRE1dxgfs3oVPmKLx9gM1ntsFR m3bIF7mf+upxqKHluHvUCakAPN1CjqVtrwqKrBnTHFC2wpbQB7seq9xLJd8UtOdL/f9p N9JA== X-Gm-Message-State: AOAM530snd1GRQccez3nmokMXkbqCdaCpw9pbi8lAgaraWhkuWQCQupZ awOAi/aRIvq6o5ELGZ6DiikaXA== X-Google-Smtp-Source: ABdhPJxRzD0WBfqSsRnsWWctoiC4ZL/68Vbzs2wYW5pL6AgqTKpTz7zCXFAYZWzBRrc637AgBAl43A== X-Received: by 2002:a63:7f0e:: with SMTP id a14mr3656783pgd.390.1634316842164; Fri, 15 Oct 2021 09:54:02 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id b8sm5387267pfi.103.2021.10.15.09.54.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Oct 2021 09:54:01 -0700 (PDT) Date: Fri, 15 Oct 2021 09:54:01 -0700 From: Kees Cook To: Christoph Hellwig Message-ID: <202110150953.4A7CC49DC@keescook> References: <20211015132643.1621913-1-hch@lst.de> <20211015132643.1621913-19-hch@lst.de> MIME-Version: 1.0 In-Reply-To: <20211015132643.1621913-19-hch@lst.de> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: dm-devel@redhat.com Cc: Dave Kleikamp , jfs-discussion@lists.sourceforge.net, Mike Snitzer , linux-nvme@lists.infradead.org, Konstantin Komarov , Song Liu , dm-devel@redhat.com, target-devel@vger.kernel.org, reiserfs-devel@vger.kernel.org, drbd-dev@lists.linbit.com, linux-nilfs@vger.kernel.org, linux-scsi@vger.kernel.org, OGAWA Hirofumi , linux-ext4@vger.kernel.org, Josef Bacik , Coly Li , linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, David Sterba , Ryusuke Konishi , Anton Altaparmakov , Jens Axboe , linux-block@vger.kernel.org, linux-nfs@vger.kernel.org, Theodore Ts'o , linux-ntfs-dev@lists.sourceforge.net, Jan Kara , linux-fsdevel@vger.kernel.org, Phillip Lougher , ntfs3@lists.linux.dev, linux-btrfs@vger.kernel.org Subject: Re: [dm-devel] [PATCH 18/30] nfs/blocklayout: use bdev_nr_bytes instead of open coding it X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, Oct 15, 2021 at 03:26:31PM +0200, Christoph Hellwig wrote: > Use the proper helper to read the block device size. > > Signed-off-by: Christoph Hellwig Reviewed-by: Kees Cook -- Kees Cook -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 041BBC43217 for ; Fri, 15 Oct 2021 16:54:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E4A0A611C3 for ; Fri, 15 Oct 2021 16:54:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241766AbhJOQ4P (ORCPT ); Fri, 15 Oct 2021 12:56:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241769AbhJOQ4J (ORCPT ); Fri, 15 Oct 2021 12:56:09 -0400 Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C96FC061767 for ; Fri, 15 Oct 2021 09:54:02 -0700 (PDT) Received: by mail-pg1-x52a.google.com with SMTP id e65so6716466pgc.5 for ; Fri, 15 Oct 2021 09:54:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+MbYp/9I6HwSPkAmORgtqKp7aAXKpROAHsI0KkahVSk=; b=ikEdVtNf9eRQss1RELdYd+gQGtRkJJNUyxABmsyhavxmXS/GWW1GmjaIFqcZC+V7d0 jxPVuirO3PDa+xeNqLrVJO8s8KcCPrKVcuz5mnU+QJTWjswUytrClmIjf52ECv87VZwj IWYURypnyInULxZ6QO8cmc8sNxz7IQsLEMu78= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+MbYp/9I6HwSPkAmORgtqKp7aAXKpROAHsI0KkahVSk=; b=GII4POAWq/uYCQjWKjF7dKXuHSQEb+bA5auPyavjXHCj8FnibfUBfooud2HwMBONuI MO6PiOBGflfJW9roV6yXoMro1G8DjJ2igZnsR2PZJfwyXfsgagPsdaqEr7KDMsWAhHtm DlxufYM8b1bmn2s754AvTcKM7H/3iqerqxmBKRboZYBPHnxc7pmXNSlPlxY6g3ZyiTVq tzOkDp71+VPkN7iND4wTdm+ghwlkhR4G+3yqTJ79TQuGckA4mCZYQY1imvIEYqPdX5AT hcU6r1LhFkNN6Hc42gKBH9PE5S9lNeVwyNqU9p2H4PnYas3Z30afvdYstaBIYTlGfOXP xdqg== X-Gm-Message-State: AOAM5332QNtSH7usnfJmD/XZ5jIwnReiT43AUDnHxg8RuY05VQ1JDfHe B+k6+xkEW72TbISV98jrfX1xOA== X-Google-Smtp-Source: ABdhPJxRzD0WBfqSsRnsWWctoiC4ZL/68Vbzs2wYW5pL6AgqTKpTz7zCXFAYZWzBRrc637AgBAl43A== X-Received: by 2002:a63:7f0e:: with SMTP id a14mr3656783pgd.390.1634316842164; Fri, 15 Oct 2021 09:54:02 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id b8sm5387267pfi.103.2021.10.15.09.54.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Oct 2021 09:54:01 -0700 (PDT) Date: Fri, 15 Oct 2021 09:54:01 -0700 From: Kees Cook To: Christoph Hellwig Cc: Jens Axboe , Coly Li , Mike Snitzer , Song Liu , David Sterba , Josef Bacik , Theodore Ts'o , OGAWA Hirofumi , Dave Kleikamp , Ryusuke Konishi , Anton Altaparmakov , Konstantin Komarov , Phillip Lougher , Jan Kara , linux-block@vger.kernel.org, dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev, reiserfs-devel@vger.kernel.org Subject: Re: [PATCH 18/30] nfs/blocklayout: use bdev_nr_bytes instead of open coding it Message-ID: <202110150953.4A7CC49DC@keescook> References: <20211015132643.1621913-1-hch@lst.de> <20211015132643.1621913-19-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211015132643.1621913-19-hch@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-bcache@vger.kernel.org On Fri, Oct 15, 2021 at 03:26:31PM +0200, Christoph Hellwig wrote: > Use the proper helper to read the block device size. > > Signed-off-by: Christoph Hellwig Reviewed-by: Kees Cook -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kees Cook Subject: Re: [PATCH 18/30] nfs/blocklayout: use bdev_nr_bytes instead of open coding it Date: Fri, 15 Oct 2021 09:54:01 -0700 Message-ID: <202110150953.4A7CC49DC@keescook> References: <20211015132643.1621913-1-hch@lst.de> <20211015132643.1621913-19-hch@lst.de> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+MbYp/9I6HwSPkAmORgtqKp7aAXKpROAHsI0KkahVSk=; b=ikEdVtNf9eRQss1RELdYd+gQGtRkJJNUyxABmsyhavxmXS/GWW1GmjaIFqcZC+V7d0 jxPVuirO3PDa+xeNqLrVJO8s8KcCPrKVcuz5mnU+QJTWjswUytrClmIjf52ECv87VZwj IWYURypnyInULxZ6QO8cmc8sNxz7IQsLEMu78= Content-Disposition: inline In-Reply-To: <20211015132643.1621913-19-hch@lst.de> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christoph Hellwig Cc: Jens Axboe , Coly Li , Mike Snitzer , Song Liu , David Sterba , Josef Bacik , Theodore Ts'o , OGAWA Hirofumi , Dave Kleikamp , Ryusuke Konishi , Anton Altaparmakov , Konstantin Komarov , Phillip Lougher , Jan Kara , linux-block@vger.kernel.org, dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org On Fri, Oct 15, 2021 at 03:26:31PM +0200, Christoph Hellwig wrote: > Use the proper helper to read the block device size. > > Signed-off-by: Christoph Hellwig Reviewed-by: Kees Cook -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id 2CDE9421064 for ; Fri, 15 Oct 2021 18:54:02 +0200 (CEST) Received: by mail-pf1-f169.google.com with SMTP id o133so8848248pfg.7 for ; Fri, 15 Oct 2021 09:54:02 -0700 (PDT) Date: Fri, 15 Oct 2021 09:54:01 -0700 From: Kees Cook To: Christoph Hellwig Message-ID: <202110150953.4A7CC49DC@keescook> References: <20211015132643.1621913-1-hch@lst.de> <20211015132643.1621913-19-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211015132643.1621913-19-hch@lst.de> Cc: Dave Kleikamp , jfs-discussion@lists.sourceforge.net, Mike Snitzer , linux-nvme@lists.infradead.org, Konstantin Komarov , Song Liu , dm-devel@redhat.com, target-devel@vger.kernel.org, reiserfs-devel@vger.kernel.org, drbd-dev@lists.linbit.com, linux-nilfs@vger.kernel.org, linux-scsi@vger.kernel.org, OGAWA Hirofumi , linux-ext4@vger.kernel.org, Josef Bacik , Coly Li , linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, David Sterba , Ryusuke Konishi , Anton Altaparmakov , Jens Axboe , linux-block@vger.kernel.org, linux-nfs@vger.kernel.org, Theodore Ts'o , linux-ntfs-dev@lists.sourceforge.net, Jan Kara , linux-fsdevel@vger.kernel.org, Phillip Lougher , ntfs3@lists.linux.dev, linux-btrfs@vger.kernel.org Subject: Re: [Drbd-dev] [PATCH 18/30] nfs/blocklayout: use bdev_nr_bytes instead of open coding it List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, Oct 15, 2021 at 03:26:31PM +0200, Christoph Hellwig wrote: > Use the proper helper to read the block device size. > > Signed-off-by: Christoph Hellwig Reviewed-by: Kees Cook -- Kees Cook