From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 493D3C433F5 for ; Fri, 15 Oct 2021 16:56:49 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B6089611C1 for ; Fri, 15 Oct 2021 16:56:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B6089611C1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-390-3l5Ygj3SMy6mnzYpR4a18Q-1; Fri, 15 Oct 2021 12:56:44 -0400 X-MC-Unique: 3l5Ygj3SMy6mnzYpR4a18Q-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 008E7EC1A1; Fri, 15 Oct 2021 16:56:40 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CFA2119736; Fri, 15 Oct 2021 16:56:39 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9E8F44EA31; Fri, 15 Oct 2021 16:56:39 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 19FGu7mY012611 for ; Fri, 15 Oct 2021 12:56:07 -0400 Received: by smtp.corp.redhat.com (Postfix) id 23B5D40CFD11; Fri, 15 Oct 2021 16:56:07 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1EAAE40CFD0D for ; Fri, 15 Oct 2021 16:56:07 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 06245811E7F for ; Fri, 15 Oct 2021 16:56:07 +0000 (UTC) Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-125-kirDL5jHOO6flV7jX0hE7Q-1; Fri, 15 Oct 2021 12:56:05 -0400 X-MC-Unique: kirDL5jHOO6flV7jX0hE7Q-1 Received: by mail-pf1-f179.google.com with SMTP id y7so8851780pfg.8 for ; Fri, 15 Oct 2021 09:56:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dBqAYLNOJEEerwqZkr8h1WW5rIZpnbVROvIlOTScyoI=; b=H439pZoFXCRUsSJJwJ4b/qUI4g6SU4CFzhPepDFaPPxGlyn8YED1xaWvGnlcPhWcXT WcrtBa94E6aRd0x8jGNfmqVNNh3f/xzAUFoFi5ITN5B01nvCScCPeYs64BNuJjDKdupQ 5rWpAF25juovb/Yvq7e/2kky1Yd2pIPLu9WRwFETVgkP/yv5BWVNgGRRBjJLr91LZcy1 8/ue7h3KYgwJ1TdSW1CXcOcVUvj6NAkkCZMshYFN3fplCJJLdPxy3mA02oSfpXaDx44U HyZiTSZer1Qtu5iRh4yc3pjro6PK42C4xeCclcC/9VcTo1zAb2TsU93P9ax/Q52Odt86 OkzA== X-Gm-Message-State: AOAM532NtnBj+8GWkea0+qvCw0raD/oZVZodQUIu6sO0tdxdzPTcuwqa jNaqYfpxqI3lH6m49cS99Td1lw== X-Google-Smtp-Source: ABdhPJwArKSP1GbQ25tbhNDvzZCNcxogaP2mPI5IH6CBqZA2sACP5s1J2IGQKikEyZ/PadmXHII8iA== X-Received: by 2002:a63:1266:: with SMTP id 38mr9960371pgs.219.1634316964288; Fri, 15 Oct 2021 09:56:04 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id m12sm5254518pjv.29.2021.10.15.09.56.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Oct 2021 09:56:04 -0700 (PDT) Date: Fri, 15 Oct 2021 09:56:03 -0700 From: Kees Cook To: Christoph Hellwig Message-ID: <202110150955.495735B@keescook> References: <20211015132643.1621913-1-hch@lst.de> <20211015132643.1621913-22-hch@lst.de> MIME-Version: 1.0 In-Reply-To: <20211015132643.1621913-22-hch@lst.de> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-loop: dm-devel@redhat.com Cc: Dave Kleikamp , jfs-discussion@lists.sourceforge.net, Mike Snitzer , linux-nvme@lists.infradead.org, Konstantin Komarov , Song Liu , dm-devel@redhat.com, target-devel@vger.kernel.org, reiserfs-devel@vger.kernel.org, drbd-dev@lists.linbit.com, linux-nilfs@vger.kernel.org, linux-scsi@vger.kernel.org, OGAWA Hirofumi , linux-ext4@vger.kernel.org, Josef Bacik , Coly Li , linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, David Sterba , Ryusuke Konishi , Anton Altaparmakov , Jens Axboe , linux-block@vger.kernel.org, linux-nfs@vger.kernel.org, Theodore Ts'o , linux-ntfs-dev@lists.sourceforge.net, Jan Kara , linux-fsdevel@vger.kernel.org, Phillip Lougher , ntfs3@lists.linux.dev, linux-btrfs@vger.kernel.org Subject: Re: [dm-devel] [PATCH 21/30] pstore/blk: use bdev_nr_bytes instead of open coding it X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, Oct 15, 2021 at 03:26:34PM +0200, Christoph Hellwig wrote: > Use the proper helper to read the block device size. > > Signed-off-by: Christoph Hellwig Thanks for the bdev_by_bytes() helper; this is more readable now. :) Acked-by: Kees Cook -- Kees Cook -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCAAEC4332F for ; Fri, 15 Oct 2021 16:56:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C164F611C1 for ; Fri, 15 Oct 2021 16:56:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241804AbhJOQ6N (ORCPT ); Fri, 15 Oct 2021 12:58:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241807AbhJOQ6L (ORCPT ); Fri, 15 Oct 2021 12:58:11 -0400 Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B00CEC061765 for ; Fri, 15 Oct 2021 09:56:04 -0700 (PDT) Received: by mail-pf1-x42a.google.com with SMTP id c29so8885953pfp.2 for ; Fri, 15 Oct 2021 09:56:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=dBqAYLNOJEEerwqZkr8h1WW5rIZpnbVROvIlOTScyoI=; b=a7qtweAUbS8K+NvWs4UCJMddQ3rECf/7QZ6zgMst5BcQ7TbdTIW8B/A36zncKdA0GG 8KMhkxj+OzPkhorCWgeiV72Q4Wcq28WkBpsAyjDJDIhvh57vqCJGOPQwvw9YxRM4d1BS rdcHafc3+6KUZpEfQohGLoX5kTVxG/qsPhu90= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dBqAYLNOJEEerwqZkr8h1WW5rIZpnbVROvIlOTScyoI=; b=mtUs8EM7TVYBJDnM6TQabFBxj4/NmH9Elp1kvmMlf0lTTgGqAnHOvQ5h+g5lDSsEZk Kt0wfy/nhlME0miy/b2Q+u4FwJ+TaIbEnKcGdMEbhuFhxuFdVsUS+YW5ks0MA5oNuwPh ETRTtt6gv6s/vcI0ET3kj5i0s1XJeHqidNEHTsXVHh+X+KM7iIJwn04R/XaLYvjHeysL F3xiVyUc39ZsiA3VGxJK3OCip5PmwBaygnXk7SJvB2k+WLRv0KtsR8VjP81oixgH7BQT lfYEvR/1ewvNLjQpYcEyJm+dpHEF6z04HbK3GivDaHz/8FJV0guT3KSjw3aBmJM8DlUB Rujg== X-Gm-Message-State: AOAM5318QD/13JO2XJLjKaEiy7+logJSm+or5LGG2a84aRZ0MAL73aOm /ehBiJcY3i/SmW+bT5gVL0+WLw== X-Google-Smtp-Source: ABdhPJwArKSP1GbQ25tbhNDvzZCNcxogaP2mPI5IH6CBqZA2sACP5s1J2IGQKikEyZ/PadmXHII8iA== X-Received: by 2002:a63:1266:: with SMTP id 38mr9960371pgs.219.1634316964288; Fri, 15 Oct 2021 09:56:04 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id m12sm5254518pjv.29.2021.10.15.09.56.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Oct 2021 09:56:04 -0700 (PDT) Date: Fri, 15 Oct 2021 09:56:03 -0700 From: Kees Cook To: Christoph Hellwig Cc: Jens Axboe , Coly Li , Mike Snitzer , Song Liu , David Sterba , Josef Bacik , Theodore Ts'o , OGAWA Hirofumi , Dave Kleikamp , Ryusuke Konishi , Anton Altaparmakov , Konstantin Komarov , Phillip Lougher , Jan Kara , linux-block@vger.kernel.org, dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev, reiserfs-devel@vger.kernel.org Subject: Re: [PATCH 21/30] pstore/blk: use bdev_nr_bytes instead of open coding it Message-ID: <202110150955.495735B@keescook> References: <20211015132643.1621913-1-hch@lst.de> <20211015132643.1621913-22-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211015132643.1621913-22-hch@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-bcache@vger.kernel.org On Fri, Oct 15, 2021 at 03:26:34PM +0200, Christoph Hellwig wrote: > Use the proper helper to read the block device size. > > Signed-off-by: Christoph Hellwig Thanks for the bdev_by_bytes() helper; this is more readable now. :) Acked-by: Kees Cook -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kees Cook Subject: Re: [PATCH 21/30] pstore/blk: use bdev_nr_bytes instead of open coding it Date: Fri, 15 Oct 2021 09:56:03 -0700 Message-ID: <202110150955.495735B@keescook> References: <20211015132643.1621913-1-hch@lst.de> <20211015132643.1621913-22-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=dBqAYLNOJEEerwqZkr8h1WW5rIZpnbVROvIlOTScyoI=; b=a7qtweAUbS8K+NvWs4UCJMddQ3rECf/7QZ6zgMst5BcQ7TbdTIW8B/A36zncKdA0GG 8KMhkxj+OzPkhorCWgeiV72Q4Wcq28WkBpsAyjDJDIhvh57vqCJGOPQwvw9YxRM4d1BS rdcHafc3+6KUZpEfQohGLoX5kTVxG/qsPhu90= Content-Disposition: inline In-Reply-To: <20211015132643.1621913-22-hch-jcswGhMUV9g@public.gmane.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: drbd-dev-bounces-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org Errors-To: drbd-dev-bounces-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org To: Christoph Hellwig Cc: Dave Kleikamp , jfs-discussion-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Mike Snitzer , linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Konstantin Komarov , Song Liu , dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, reiserfs-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org, linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, OGAWA Hirofumi , linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Josef Bacik , Coly Li , linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, David Sterba , Ryusuke Konishi , Anton Altaparmakov , Jens Axboe , linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Theodore Ts'o , linux-ntfs-dev-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Jan Kara On Fri, Oct 15, 2021 at 03:26:34PM +0200, Christoph Hellwig wrote: > Use the proper helper to read the block device size. > > Signed-off-by: Christoph Hellwig Thanks for the bdev_by_bytes() helper; this is more readable now. :) Acked-by: Kees Cook -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id 1546F421066 for ; Fri, 15 Oct 2021 18:56:05 +0200 (CEST) Received: by mail-pf1-f169.google.com with SMTP id d9so1668907pfl.6 for ; Fri, 15 Oct 2021 09:56:04 -0700 (PDT) Date: Fri, 15 Oct 2021 09:56:03 -0700 From: Kees Cook To: Christoph Hellwig Message-ID: <202110150955.495735B@keescook> References: <20211015132643.1621913-1-hch@lst.de> <20211015132643.1621913-22-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211015132643.1621913-22-hch@lst.de> Cc: Dave Kleikamp , jfs-discussion@lists.sourceforge.net, Mike Snitzer , linux-nvme@lists.infradead.org, Konstantin Komarov , Song Liu , dm-devel@redhat.com, target-devel@vger.kernel.org, reiserfs-devel@vger.kernel.org, drbd-dev@lists.linbit.com, linux-nilfs@vger.kernel.org, linux-scsi@vger.kernel.org, OGAWA Hirofumi , linux-ext4@vger.kernel.org, Josef Bacik , Coly Li , linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, David Sterba , Ryusuke Konishi , Anton Altaparmakov , Jens Axboe , linux-block@vger.kernel.org, linux-nfs@vger.kernel.org, Theodore Ts'o , linux-ntfs-dev@lists.sourceforge.net, Jan Kara , linux-fsdevel@vger.kernel.org, Phillip Lougher , ntfs3@lists.linux.dev, linux-btrfs@vger.kernel.org Subject: Re: [Drbd-dev] [PATCH 21/30] pstore/blk: use bdev_nr_bytes instead of open coding it List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, Oct 15, 2021 at 03:26:34PM +0200, Christoph Hellwig wrote: > Use the proper helper to read the block device size. > > Signed-off-by: Christoph Hellwig Thanks for the bdev_by_bytes() helper; this is more readable now. :) Acked-by: Kees Cook -- Kees Cook