From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6437FC433FE for ; Fri, 15 Oct 2021 16:57:01 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E16DC611C8 for ; Fri, 15 Oct 2021 16:57:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E16DC611C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-63-WjuZTQQmOWKtSOR_orZWAw-1; Fri, 15 Oct 2021 12:56:58 -0400 X-MC-Unique: WjuZTQQmOWKtSOR_orZWAw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8CEF1EC1A8; Fri, 15 Oct 2021 16:56:53 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7161D5DEFA; Fri, 15 Oct 2021 16:56:53 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4DDE31806D01; Fri, 15 Oct 2021 16:56:53 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 19FGupA5012651 for ; Fri, 15 Oct 2021 12:56:51 -0400 Received: by smtp.corp.redhat.com (Postfix) id 8FF6440CFD11; Fri, 15 Oct 2021 16:56:51 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8B51040CFD0D for ; Fri, 15 Oct 2021 16:56:51 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 736EB8007B1 for ; Fri, 15 Oct 2021 16:56:51 +0000 (UTC) Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-415-IPmfA_LPOA68w-F-LnVIFQ-1; Fri, 15 Oct 2021 12:56:49 -0400 X-MC-Unique: IPmfA_LPOA68w-F-LnVIFQ-1 Received: by mail-pj1-f42.google.com with SMTP id lk8-20020a17090b33c800b001a0a284fcc2so9765235pjb.2 for ; Fri, 15 Oct 2021 09:56:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vfh8ldDPWodO2+NAKgs+77i4cirGVTrsvlhR7sq6n14=; b=K396rRKGsgNOGO0hiIm/8rmMS7S4Y92Kt/3qgY45Lv4UWxFy3LlLngHW0TI30LVf1N j6U7EktB4ZCPj0fTdozKjutpT+hsONKdnWuG5Nxb3EjoFPUse3t6PxmY0t+TyzywPxzd xKC61a7IVul4AiffiGZfUnknub7WNDucCIShOeFB8dzmrq/72KDi+QH4GmH7ZDntvNTG DaTXAza58g2rNA8vh+70PCFzY5ok8sZsa/go8vRDIqb5VfxwTWwfxa8h40ONz28tp4Cr trfTiktn6U+0lVvwvC9i6igV8+4P9xKmqwfMtrvh9hpFdAacsDwOfxQrWHJcSJ0otpnx teug== X-Gm-Message-State: AOAM531Ip2XQcyt44LNDyJv0QC2+sLpTXSFoxtzWnF/gl8eC7JcMYjlU Ht/g68GlxFDO2xCuzSZLI7z/jbKIjH4vIg== X-Google-Smtp-Source: ABdhPJwnnQ3ulrXVGFg4s+UA3ddGM8HwmAEnk5XYfNq6HtGw+i5b3OvChqf29ta/Idk60aluKwm2lg== X-Received: by 2002:a17:903:18d:b0:13e:f1ef:d80c with SMTP id z13-20020a170903018d00b0013ef1efd80cmr11974419plg.63.1634317008672; Fri, 15 Oct 2021 09:56:48 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id t125sm5518370pfc.119.2021.10.15.09.56.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Oct 2021 09:56:48 -0700 (PDT) Date: Fri, 15 Oct 2021 09:56:47 -0700 From: Kees Cook To: Christoph Hellwig Message-ID: <202110150956.A0360E2D01@keescook> References: <20211015132643.1621913-1-hch@lst.de> <20211015132643.1621913-23-hch@lst.de> MIME-Version: 1.0 In-Reply-To: <20211015132643.1621913-23-hch@lst.de> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-loop: dm-devel@redhat.com Cc: Dave Kleikamp , jfs-discussion@lists.sourceforge.net, Jan Kara , Mike Snitzer , linux-nvme@lists.infradead.org, Konstantin Komarov , Song Liu , dm-devel@redhat.com, target-devel@vger.kernel.org, reiserfs-devel@vger.kernel.org, drbd-dev@lists.linbit.com, linux-nilfs@vger.kernel.org, linux-scsi@vger.kernel.org, OGAWA Hirofumi , linux-ext4@vger.kernel.org, Josef Bacik , Coly Li , linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, David Sterba , Ryusuke Konishi , Anton Altaparmakov , Jens Axboe , linux-block@vger.kernel.org, linux-nfs@vger.kernel.org, Theodore Ts'o , linux-ntfs-dev@lists.sourceforge.net, Jan Kara , linux-fsdevel@vger.kernel.org, Phillip Lougher , ntfs3@lists.linux.dev, linux-btrfs@vger.kernel.org Subject: Re: [dm-devel] [PATCH 22/30] reiserfs: use bdev_nr_bytes instead of open coding it X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, Oct 15, 2021 at 03:26:35PM +0200, Christoph Hellwig wrote: > Use the proper helper to read the block device size and remove two > cargo culted checks that can't be false. > > Signed-off-by: Christoph Hellwig Reviewed-by: Kees Cook -- Kees Cook -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E672C433F5 for ; Fri, 15 Oct 2021 16:56:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0CCFA611C8 for ; Fri, 15 Oct 2021 16:56:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241814AbhJOQ65 (ORCPT ); Fri, 15 Oct 2021 12:58:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241795AbhJOQ6z (ORCPT ); Fri, 15 Oct 2021 12:58:55 -0400 Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EBD8C061769 for ; Fri, 15 Oct 2021 09:56:49 -0700 (PDT) Received: by mail-pl1-x630.google.com with SMTP id 21so6742146plo.13 for ; Fri, 15 Oct 2021 09:56:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=vfh8ldDPWodO2+NAKgs+77i4cirGVTrsvlhR7sq6n14=; b=MF0yf140gbDAdW4BxnOXdsQIbZ1Zs20bgZWJgGQJccJRdMKWf0Z7qJMeg/xUZ/rSs6 VG3QCkdC2Gak2gGrkvLjpOyqG7g5cIFwioohIVF4DnPVlIrbB81BnizHen6OonQjrvMj EAa7kecUI8Ha/nnI/LS4mNOBQr2yiVBjBbg4U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vfh8ldDPWodO2+NAKgs+77i4cirGVTrsvlhR7sq6n14=; b=41aGz3eO0yu8OPpVNU3vHibio8SfsMIH6dahkdKyb/6gI+s44xiBP2ea4iZLoWKmDL unIuCwKlW8YS8E9OCRiwDud0MtieOlDCLQcAtWyl9oI1N3f+LvTUlCjY3Mf43d0po+oc ZdUbkA2J0z3T7AmbhBOoxYh6W8+uOFJ1O7F0fMaYIiK9zU0s/6pBeITNafe3mPwH9/9e YtTzn7pku9ngFAUncm/hIP3Us2beCwukN4zYdEiQs9GptlFv7ugz7mSItDEvwW54WDFT +S7geTyNwyhPi2X1mkvcx6JGImTDEA7F40XUPerpUkQNMNs6YstWcaxSroCVQP2xBECv 6s7Q== X-Gm-Message-State: AOAM531uxTytcb24b0/9ik5Is0g6uGiCZVVlx6LCEzP1wADTHNVufqjd U86iU3/bdRSKbxZjaxVkIFnayQ== X-Google-Smtp-Source: ABdhPJwnnQ3ulrXVGFg4s+UA3ddGM8HwmAEnk5XYfNq6HtGw+i5b3OvChqf29ta/Idk60aluKwm2lg== X-Received: by 2002:a17:903:18d:b0:13e:f1ef:d80c with SMTP id z13-20020a170903018d00b0013ef1efd80cmr11974419plg.63.1634317008672; Fri, 15 Oct 2021 09:56:48 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id t125sm5518370pfc.119.2021.10.15.09.56.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Oct 2021 09:56:48 -0700 (PDT) Date: Fri, 15 Oct 2021 09:56:47 -0700 From: Kees Cook To: Christoph Hellwig Cc: Jens Axboe , Coly Li , Mike Snitzer , Song Liu , David Sterba , Josef Bacik , Theodore Ts'o , OGAWA Hirofumi , Dave Kleikamp , Ryusuke Konishi , Anton Altaparmakov , Konstantin Komarov , Phillip Lougher , Jan Kara , linux-block@vger.kernel.org, dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev, reiserfs-devel@vger.kernel.org, Jan Kara Subject: Re: [PATCH 22/30] reiserfs: use bdev_nr_bytes instead of open coding it Message-ID: <202110150956.A0360E2D01@keescook> References: <20211015132643.1621913-1-hch@lst.de> <20211015132643.1621913-23-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211015132643.1621913-23-hch@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-bcache@vger.kernel.org On Fri, Oct 15, 2021 at 03:26:35PM +0200, Christoph Hellwig wrote: > Use the proper helper to read the block device size and remove two > cargo culted checks that can't be false. > > Signed-off-by: Christoph Hellwig Reviewed-by: Kees Cook -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kees Cook Subject: Re: [PATCH 22/30] reiserfs: use bdev_nr_bytes instead of open coding it Date: Fri, 15 Oct 2021 09:56:47 -0700 Message-ID: <202110150956.A0360E2D01@keescook> References: <20211015132643.1621913-1-hch@lst.de> <20211015132643.1621913-23-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=vfh8ldDPWodO2+NAKgs+77i4cirGVTrsvlhR7sq6n14=; b=MF0yf140gbDAdW4BxnOXdsQIbZ1Zs20bgZWJgGQJccJRdMKWf0Z7qJMeg/xUZ/rSs6 VG3QCkdC2Gak2gGrkvLjpOyqG7g5cIFwioohIVF4DnPVlIrbB81BnizHen6OonQjrvMj EAa7kecUI8Ha/nnI/LS4mNOBQr2yiVBjBbg4U= Content-Disposition: inline In-Reply-To: <20211015132643.1621913-23-hch-jcswGhMUV9g@public.gmane.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: drbd-dev-bounces-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org Errors-To: drbd-dev-bounces-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org To: Christoph Hellwig Cc: Dave Kleikamp , jfs-discussion-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Jan Kara , Mike Snitzer , linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Konstantin Komarov , Song Liu , dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, reiserfs-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org, linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, OGAWA Hirofumi , linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Josef Bacik , Coly Li , linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, David Sterba , Ryusuke Konishi , Anton Altaparmakov , Jens Axboe , linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Theodore Ts'o , linux-ntfs-dev-5NWGOfrQmndRYHbF4JBHZw@public.gmane.org On Fri, Oct 15, 2021 at 03:26:35PM +0200, Christoph Hellwig wrote: > Use the proper helper to read the block device size and remove two > cargo culted checks that can't be false. > > Signed-off-by: Christoph Hellwig Reviewed-by: Kees Cook -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id 9FD4942106F for ; Fri, 15 Oct 2021 18:56:49 +0200 (CEST) Received: by mail-pl1-f179.google.com with SMTP id i5so523406pla.5 for ; Fri, 15 Oct 2021 09:56:49 -0700 (PDT) Date: Fri, 15 Oct 2021 09:56:47 -0700 From: Kees Cook To: Christoph Hellwig Message-ID: <202110150956.A0360E2D01@keescook> References: <20211015132643.1621913-1-hch@lst.de> <20211015132643.1621913-23-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211015132643.1621913-23-hch@lst.de> Cc: Dave Kleikamp , jfs-discussion@lists.sourceforge.net, Jan Kara , Mike Snitzer , linux-nvme@lists.infradead.org, Konstantin Komarov , Song Liu , dm-devel@redhat.com, target-devel@vger.kernel.org, reiserfs-devel@vger.kernel.org, drbd-dev@lists.linbit.com, linux-nilfs@vger.kernel.org, linux-scsi@vger.kernel.org, OGAWA Hirofumi , linux-ext4@vger.kernel.org, Josef Bacik , Coly Li , linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, David Sterba , Ryusuke Konishi , Anton Altaparmakov , Jens Axboe , linux-block@vger.kernel.org, linux-nfs@vger.kernel.org, Theodore Ts'o , linux-ntfs-dev@lists.sourceforge.net, Jan Kara , linux-fsdevel@vger.kernel.org, Phillip Lougher , ntfs3@lists.linux.dev, linux-btrfs@vger.kernel.org Subject: Re: [Drbd-dev] [PATCH 22/30] reiserfs: use bdev_nr_bytes instead of open coding it List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, Oct 15, 2021 at 03:26:35PM +0200, Christoph Hellwig wrote: > Use the proper helper to read the block device size and remove two > cargo culted checks that can't be false. > > Signed-off-by: Christoph Hellwig Reviewed-by: Kees Cook -- Kees Cook