From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5E47C433EF for ; Fri, 15 Oct 2021 10:50:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9048D6105A for ; Fri, 15 Oct 2021 10:50:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238163AbhJOKw6 convert rfc822-to-8bit (ORCPT ); Fri, 15 Oct 2021 06:52:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238167AbhJOKwy (ORCPT ); Fri, 15 Oct 2021 06:52:54 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2197C061570; Fri, 15 Oct 2021 03:50:48 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1mbKnW-0000QY-AO; Fri, 15 Oct 2021 12:50:46 +0200 Date: Fri, 15 Oct 2021 12:50:46 +0200 From: Florian Westphal To: Maciej =?utf-8?Q?=C5=BBenczykowski?= Cc: Florian Westphal , Pablo Neira Ayuso , Linux Network Development Mailing List , Netfilter Development Mailing List Subject: Re: [PATCH netfilter] netfilter: conntrack: udp: generate event on switch to stream timeout Message-ID: <20211015105046.GI2942@breakpoint.cc> References: <20211015090934.2870662-1-zenczykowski@gmail.com> <20211015095716.GH2942@breakpoint.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Maciej Żenczykowski wrote: > On Fri, Oct 15, 2021 at 2:57 AM Florian Westphal wrote: > > Do you think it makes sense to just delay setting the ASSURED bit > > until after the 2s period? > > That would work for this particular use case.... but I don't know if > it's a good idea. > I did of course think of it, but the commit message seemed to imply > there's a good reason to set the assured bit earlier rather than > later... > > A udp flow becoming bidirectional seems like an important event to > notify about... > Afterall, the UDP flow might become a stream 29 seconds after it > becomes bidirectional... Oh right, never mind then. Acked-by: Florian Westphal