From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79AE8C433F5 for ; Fri, 15 Oct 2021 09:44:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 649B760EDF for ; Fri, 15 Oct 2021 09:44:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234709AbhJOJq5 convert rfc822-to-8bit (ORCPT ); Fri, 15 Oct 2021 05:46:57 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:41717 "EHLO relay8-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230013AbhJOJq4 (ORCPT ); Fri, 15 Oct 2021 05:46:56 -0400 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 73C691BF206; Fri, 15 Oct 2021 09:44:47 +0000 (UTC) Date: Fri, 15 Oct 2021 11:44:46 +0200 From: Miquel Raynal To: Paul Cercueil Cc: Richard Weinberger , Vignesh Raghavendra , Harvey Hunt , list@opendingux.net, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 2/3] mtd: rawnand: Export nand_read_page_hwecc_oob_first() Message-ID: <20211015114446.6a939367@xps13> In-Reply-To: References: <20211009184952.24591-1-paul@crapouillou.net> <20211009184952.24591-3-paul@crapouillou.net> <20211015081313.60018976@xps13> <70G01R.2VROMW06O3O83@crapouillou.net> <20211015105146.3d2fbd08@xps13> <89I01R.QTBARVYLTBT02@crapouillou.net> <20211015113515.7b10a2d5@xps13> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org Hi Paul, paul@crapouillou.net wrote on Fri, 15 Oct 2021 10:38:00 +0100: > Hi, > > Le ven., oct. 15 2021 at 11:35:15 +0200, Miquel Raynal a écrit : > > Hi Paul, > > > >> >> */ > >> >> >> >> /* An ECC layout for using 4-bit ECC with small-page >> flash, >> storing > >> >> >> @@ -648,7 +580,7 @@ static int >> davinci_nand_attach_chip(struct >> >> nand_chip *chip) > >> >> >> } else if (chunks == 4 || chunks == 8) { > >> >> >> mtd_set_ooblayout(mtd, > >> >> >> nand_get_large_page_ooblayout()); > >> >> >> - chip->ecc.read_page = >> >> nand_davinci_read_page_hwecc_oob_first; > >> >> >> + chip->ecc.read_page = nand_read_page_hwecc_oob_first; > >> >> >> } else { > >> >> >> return -EIO; > >> >> >> } > >> >> >> diff --git a/drivers/mtd/nand/raw/nand_base.c >> >> >> b/drivers/mtd/nand/raw/nand_base.c > >> >> >> index 3d6c6e880520..cb5f343b9fa2 100644 > >> >> >> --- a/drivers/mtd/nand/raw/nand_base.c > >> >> >> +++ b/drivers/mtd/nand/raw/nand_base.c > >> >> >> @@ -3160,6 +3160,75 @@ static int >> nand_read_page_hwecc(struct >> >> nand_chip *chip, uint8_t *buf, > >> >> >> return max_bitflips; > >> >> >> } > >> >> >> >> +/** > >> >> >> + * nand_read_page_hwecc_oob_first - Hardware ECC page read >> >> with ECC > >> >> >> + * data read from OOB area > >> >> >> + * @chip: nand chip info structure > >> >> >> + * @buf: buffer to store read data > >> >> >> + * @oob_required: caller requires OOB data read to >> >> chip->oob_poi > >> >> >> + * @page: page number to read > >> >> >> + * > >> >> >> + * Hardware ECC for large page chips, require OOB to be >> read >> >> first. For this > >> >> > > >> >> > requires > >> >> > > >> >> > With this ECC configuration? > >> >> > > >> >> >> + * ECC mode, the write_page method is re-used from ECC_HW. >> >> These >> methods > >> >> > > >> >> > I do not understand this sentence nor the next one about >> >> syndrome. I > >> >> > believe it is related to your engine and should not leak into >> the >> > core. > >> >> > > >> >> >> + * read/write ECC from the OOB area, unlike the >> >> ECC_HW_SYNDROME >> support with > >> >> >> + * multiple ECC steps, follows the "infix ECC" scheme and >> >> >> reads/writes ECC from > >> >> >> + * the data area, by overwriting the NAND manufacturer bad >> >> block >> markings. > >> >> > > >> >> > That's a sentence I don't like. What do you mean exactly? > >> >> > > >> >> > What "Infix ECC" scheme is? > >> >> > > >> >> > Do you mean that unlike the syndrome mode it *does not* >> >> overwrite the > >> >> > BBM ? > >> >> >> I don't mean anything. I did not write that comment. I just >> moved >> the function verbatim with no changes. If something needs >> to be >> fixed, then it needs to be fixed before/after this patch. > >> > > >> > Well, this comment should be adapted because as-is I don't think >> it's > >> > wise to move it around. > >> >> OK. > >> >> I think it says that BBM can be overwritten with this >> configuration, but that would be if the OOB layout covers the BBM >> area. > > > > If the ooblayout prevents the BBM to be smatched I'm fine and this > > sentence should disappear because it's misleading. > > > >> >> >> >> + */ > >> >> >> +int nand_read_page_hwecc_oob_first(struct nand_chip *chip, >> >> uint8_t >> *buf, > >> >> >> + int oob_required, int page) > >> >> >> +{ > >> >> >> + struct mtd_info *mtd = nand_to_mtd(chip); > >> >> >> + int i, eccsize = chip->ecc.size, ret; > >> >> >> + int eccbytes = chip->ecc.bytes; > >> >> >> + int eccsteps = chip->ecc.steps; > >> >> >> + uint8_t *p = buf; > >> >> >> + uint8_t *ecc_code = chip->ecc.code_buf; > >> >> >> + unsigned int max_bitflips = 0; > >> >> >> + > >> >> >> + /* Read the OOB area first */ > >> >> >> + ret = nand_read_oob_op(chip, page, 0, chip->oob_poi, >> >> >> mtd->oobsize); > >> >> >> + if (ret) > >> >> >> + return ret; > >> >> >> + > >> >> >> + ret = nand_read_page_op(chip, page, 0, NULL, 0); > >> >> > > >> >> > Definitely not, your are requesting the chip to do the >> read_page > >> >> > operation twice. You only need a nand_change_read_column I >> >> believe. > >> >> >> Again, this code is just being moved around - don't shoot >> the >> messenger :) > >> > > >> > haha > >> > > >> > Well, now you touch the core, so I need to be more careful, and >> the > >> > code is definitely wrong, so even if we don't move that code off, >> you > >> > definitely want to fix it in order to improve your performances. > >> >> I don't see the read_page being done twice? > >> >> There's one read_oob, one read_page, then read_data in the loop. > > > > read_oob and read_page both end up sending READ0 and READSTART so > > they do request the chip to perform an internal read twice. You > > need this only once. The call to nand_read_page_op() should be a > > nand_change_read_column() with no data requested. > > OK. > > > > >> >> >> /** > >> >> >> * nand_read_page_syndrome - [REPLACEABLE] hardware ECC >> >> syndrome >> based page read > >> >> >> * @chip: nand chip info structure > >> >> >> diff --git a/include/linux/mtd/rawnand.h >> >> >> b/include/linux/mtd/rawnand.h > >> >> >> index b2f9dd3cbd69..5b88cd51fadb 100644 > >> >> >> --- a/include/linux/mtd/rawnand.h > >> >> >> +++ b/include/linux/mtd/rawnand.h > >> >> >> @@ -1539,6 +1539,8 @@ int nand_read_data_op(struct >> nand_chip >> *chip, >> void *buf, unsigned int len, > >> >> >> bool force_8bit, bool check_only); > >> >> >> int nand_write_data_op(struct nand_chip *chip, const void >> *buf, > >> >> >> unsigned int len, bool force_8bit); > >> >> >> +int nand_read_page_hwecc_oob_first(struct nand_chip *chip, >> >> uint8_t >> *buf, > >> >> >> + int oob_required, int page); > >> >> > > >> >> > You certainly want to add this symbol closer to the other >> >> read/write > >> >> > page helpers? > >> >> >> Where would that be? The other read/write page helpers are >> all >> "static" so they don't appear in any header. > >> > > >> > I believe we should keep this header local as long as there are no > >> > other users. > >> >> I'll move it to internal.h then. > > > > Why do you want to put it there is there is only one user? > > But there are two users: davinci_nand.c and (with patch [3/3]) ingenic/ingenic_nand_drv.c. Oh right I missed that :) Then please add two preparation patches which: - fixes the comment (please reword it completely) - avoid the double reading And keep the location where you moved it (including the header) as-is. Thanks, Miquèl From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE743C433F5 for ; Fri, 15 Oct 2021 09:45:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 755AB6108B for ; Fri, 15 Oct 2021 09:45:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 755AB6108B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ff0xSXjKX0HS3OXRh7Z4rdFiGVW9CXp3Hn7ILKDoc+A=; b=IYmjRP7zSqa+VA Vmfxnm7jCiXc1hOlY9iGoBMnCvnaLlewuAfaq1sA4beQlQilk2+/rcgItbxQVp4vC5xb48KL3rdqf g0rJoJOTrOdeX/tqOR0EnEvRb92y8mSvN5qD5CzxLhyIlSkMXy9Z0LcJmPPltDX635y9/Egf6dkGm JcbU6CpPVvPcUgxSdJK0S6D2sL5iq7Mq9X3gnJlk13ZYJQusGvbj/ccbfg/UKFS94Vl3hgkDSdSEa 1GN7Dq3pCaFn/zwMCh/DG8CAFunDSdIkjnK1o8CoKss0AecP6wosMbk+bXaxf3UonW4qSCBeJhSQF nwdxSDo+exaH3zrFyKcw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mbJln-006Ms5-IS; Fri, 15 Oct 2021 09:44:55 +0000 Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mbJlj-006MqG-Im for linux-mtd@lists.infradead.org; Fri, 15 Oct 2021 09:44:53 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 73C691BF206; Fri, 15 Oct 2021 09:44:47 +0000 (UTC) Date: Fri, 15 Oct 2021 11:44:46 +0200 From: Miquel Raynal To: Paul Cercueil Cc: Richard Weinberger , Vignesh Raghavendra , Harvey Hunt , list@opendingux.net, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 2/3] mtd: rawnand: Export nand_read_page_hwecc_oob_first() Message-ID: <20211015114446.6a939367@xps13> In-Reply-To: References: <20211009184952.24591-1-paul@crapouillou.net> <20211009184952.24591-3-paul@crapouillou.net> <20211015081313.60018976@xps13> <70G01R.2VROMW06O3O83@crapouillou.net> <20211015105146.3d2fbd08@xps13> <89I01R.QTBARVYLTBT02@crapouillou.net> <20211015113515.7b10a2d5@xps13> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211015_024451_948087_C072AF7E X-CRM114-Status: GOOD ( 42.94 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgUGF1bCwKCnBhdWxAY3JhcG91aWxsb3UubmV0IHdyb3RlIG9uIEZyaSwgMTUgT2N0IDIwMjEg MTA6Mzg6MDAgKzAxMDA6Cgo+IEhpLAo+IAo+IExlIHZlbi4sIG9jdC4gMTUgMjAyMSBhdCAxMToz NToxNSArMDIwMCwgTWlxdWVsIFJheW5hbCA8bWlxdWVsLnJheW5hbEBib290bGluLmNvbT4gYSDD qWNyaXQgOgo+ID4gSGkgUGF1bCwKPiA+ICAgCj4gPj4gID4+ICAqLyAgCj4gPj4gID4+ICA+PiA+ PiAgIC8qIEFuIEVDQyBsYXlvdXQgZm9yIHVzaW5nIDQtYml0IEVDQyB3aXRoIHNtYWxsLXBhZ2Ug Pj4gZmxhc2gsID4+IHN0b3JpbmcgIAo+ID4+ICA+PiAgPj4gIEBAIC02NDgsNyArNTgwLDcgQEAg c3RhdGljIGludCA+PiBkYXZpbmNpX25hbmRfYXR0YWNoX2NoaXAoc3RydWN0ID4+ID4+IG5hbmRf Y2hpcCAqY2hpcCkKPiA+PiAgPj4gID4+ICAgCQkJfSBlbHNlIGlmIChjaHVua3MgPT0gNCB8fCBj aHVua3MgPT0gOCkgewo+ID4+ICA+PiAgPj4gICAJCQkJbXRkX3NldF9vb2JsYXlvdXQobXRkLAo+ ID4+ICA+PiAgPj4gICAJCQkJCQkgIG5hbmRfZ2V0X2xhcmdlX3BhZ2Vfb29ibGF5b3V0KCkpOwo+ ID4+ICA+PiAgPj4gIC0JCQkJY2hpcC0+ZWNjLnJlYWRfcGFnZSA9ID4+ID4+IG5hbmRfZGF2aW5j aV9yZWFkX3BhZ2VfaHdlY2Nfb29iX2ZpcnN0Owo+ID4+ICA+PiAgPj4gICsJCQkJY2hpcC0+ZWNj LnJlYWRfcGFnZSA9IG5hbmRfcmVhZF9wYWdlX2h3ZWNjX29vYl9maXJzdDsKPiA+PiAgPj4gID4+ ICAgCQkJfSBlbHNlIHsKPiA+PiAgPj4gID4+ICAgCQkJCXJldHVybiAtRUlPOwo+ID4+ICA+PiAg Pj4gICAJCQl9Cj4gPj4gID4+ICA+PiAgZGlmZiAtLWdpdCBhL2RyaXZlcnMvbXRkL25hbmQvcmF3 L25hbmRfYmFzZS5jID4+ID4+ID4+IGIvZHJpdmVycy9tdGQvbmFuZC9yYXcvbmFuZF9iYXNlLmMK PiA+PiAgPj4gID4+ICBpbmRleCAzZDZjNmU4ODA1MjAuLmNiNWYzNDNiOWZhMiAxMDA2NDQKPiA+ PiAgPj4gID4+ICAtLS0gYS9kcml2ZXJzL210ZC9uYW5kL3Jhdy9uYW5kX2Jhc2UuYwo+ID4+ICA+ PiAgPj4gICsrKyBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L25hbmRfYmFzZS5jCj4gPj4gID4+ICA+ PiAgQEAgLTMxNjAsNiArMzE2MCw3NSBAQCBzdGF0aWMgaW50ID4+IG5hbmRfcmVhZF9wYWdlX2h3 ZWNjKHN0cnVjdCA+PiA+PiBuYW5kX2NoaXAgKmNoaXAsIHVpbnQ4X3QgKmJ1ZiwKPiA+PiAgPj4g ID4+ICAgCXJldHVybiBtYXhfYml0ZmxpcHM7Cj4gPj4gID4+ICA+PiAgIH0gIAo+ID4+ICA+PiAg Pj4gPj4gICsvKiogIAo+ID4+ICA+PiAgPj4gICsgKiBuYW5kX3JlYWRfcGFnZV9od2VjY19vb2Jf Zmlyc3QgLSBIYXJkd2FyZSBFQ0MgcGFnZSByZWFkID4+ID4+IHdpdGggRUNDCj4gPj4gID4+ICA+ PiAgKyAqICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRhdGEgcmVhZCBmcm9tIE9P QiBhcmVhCj4gPj4gID4+ICA+PiAgKyAqIEBjaGlwOiBuYW5kIGNoaXAgaW5mbyBzdHJ1Y3R1cmUK PiA+PiAgPj4gID4+ICArICogQGJ1ZjogYnVmZmVyIHRvIHN0b3JlIHJlYWQgZGF0YQo+ID4+ICA+ PiAgPj4gICsgKiBAb29iX3JlcXVpcmVkOiBjYWxsZXIgcmVxdWlyZXMgT09CIGRhdGEgcmVhZCB0 byA+PiA+PiBjaGlwLT5vb2JfcG9pCj4gPj4gID4+ICA+PiAgKyAqIEBwYWdlOiBwYWdlIG51bWJl ciB0byByZWFkCj4gPj4gID4+ICA+PiAgKyAqCj4gPj4gID4+ICA+PiAgKyAqIEhhcmR3YXJlIEVD QyBmb3IgbGFyZ2UgcGFnZSBjaGlwcywgcmVxdWlyZSBPT0IgdG8gYmUgPj4gcmVhZCA+PiA+PiBm aXJzdC4gRm9yIHRoaXMgIAo+ID4+ICA+PiAgPgo+ID4+ICA+PiAgPiByZXF1aXJlcwo+ID4+ICA+ PiAgPgo+ID4+ICA+PiAgPiBXaXRoIHRoaXMgRUNDIGNvbmZpZ3VyYXRpb24/Cj4gPj4gID4+ICA+ ICAKPiA+PiAgPj4gID4+ICArICogRUNDIG1vZGUsIHRoZSB3cml0ZV9wYWdlIG1ldGhvZCBpcyBy ZS11c2VkIGZyb20gRUNDX0hXLiA+PiA+PiBUaGVzZSA+PiBtZXRob2RzICAKPiA+PiAgPj4gID4K PiA+PiAgPj4gID4gSSBkbyBub3QgdW5kZXJzdGFuZCB0aGlzIHNlbnRlbmNlIG5vciB0aGUgbmV4 dCBvbmUgYWJvdXQgPj4gPj4gc3luZHJvbWUuIEkKPiA+PiAgPj4gID4gYmVsaWV2ZSBpdCBpcyBy ZWxhdGVkIHRvIHlvdXIgZW5naW5lIGFuZCBzaG91bGQgbm90IGxlYWsgaW50byA+PiB0aGUgPj4g PiBjb3JlLgo+ID4+ICA+PiAgPiAgCj4gPj4gID4+ICA+PiAgKyAqIHJlYWQvd3JpdGUgRUNDIGZy b20gdGhlIE9PQiBhcmVhLCB1bmxpa2UgdGhlID4+ID4+IEVDQ19IV19TWU5EUk9NRSA+PiBzdXBw b3J0IHdpdGgKPiA+PiAgPj4gID4+ICArICogbXVsdGlwbGUgRUNDIHN0ZXBzLCBmb2xsb3dzIHRo ZSAiaW5maXggRUNDIiBzY2hlbWUgYW5kID4+ID4+ID4+IHJlYWRzL3dyaXRlcyBFQ0MgZnJvbQo+ ID4+ICA+PiAgPj4gICsgKiB0aGUgZGF0YSBhcmVhLCBieSBvdmVyd3JpdGluZyB0aGUgTkFORCBt YW51ZmFjdHVyZXIgYmFkID4+ID4+IGJsb2NrID4+IG1hcmtpbmdzLiAgCj4gPj4gID4+ICA+Cj4g Pj4gID4+ICA+IFRoYXQncyBhIHNlbnRlbmNlIEkgZG9uJ3QgbGlrZS4gV2hhdCBkbyB5b3UgbWVh biBleGFjdGx5Pwo+ID4+ICA+PiAgPgo+ID4+ICA+PiAgPiBXaGF0ICJJbmZpeCBFQ0MiIHNjaGVt ZSBpcz8KPiA+PiAgPj4gID4KPiA+PiAgPj4gID4gRG8geW91IG1lYW4gdGhhdCB1bmxpa2UgdGhl IHN5bmRyb21lICBtb2RlIGl0ICpkb2VzIG5vdCogPj4gPj4gb3ZlcndyaXRlIHRoZQo+ID4+ICA+ PiAgPiBCQk0gPyAgCj4gPj4gID4+ID4+ICBJIGRvbid0IG1lYW4gYW55dGhpbmcuIEkgZGlkIG5v dCB3cml0ZSB0aGF0IGNvbW1lbnQuIEkganVzdCA+PiBtb3ZlZCA+PiB0aGUgZnVuY3Rpb24gdmVy YmF0aW0gd2l0aCBubyBjaGFuZ2VzLiBJZiBzb21ldGhpbmcgbmVlZHMgPj4gdG8gYmUgPj4gZml4 ZWQsIHRoZW4gaXQgbmVlZHMgdG8gYmUgZml4ZWQgYmVmb3JlL2FmdGVyIHRoaXMgcGF0Y2guICAK PiA+PiAgPgo+ID4+ICA+IFdlbGwsIHRoaXMgY29tbWVudCBzaG91bGQgYmUgYWRhcHRlZCBiZWNh dXNlIGFzLWlzIEkgZG9uJ3QgdGhpbmsgPj4gaXQncwo+ID4+ICA+IHdpc2UgdG8gbW92ZSBpdCBh cm91bmQuICAKPiA+PiA+PiAgT0suCj4gPj4gPj4gIEkgdGhpbmsgaXQgc2F5cyB0aGF0IEJCTSBj YW4gYmUgb3ZlcndyaXR0ZW4gd2l0aCB0aGlzID4+IGNvbmZpZ3VyYXRpb24sIGJ1dCB0aGF0IHdv dWxkIGJlIGlmIHRoZSBPT0IgbGF5b3V0IGNvdmVycyB0aGUgQkJNID4+IGFyZWEuICAKPiA+IAo+ ID4gSWYgdGhlIG9vYmxheW91dCBwcmV2ZW50cyB0aGUgQkJNIHRvIGJlIHNtYXRjaGVkIEknbSBm aW5lIGFuZCB0aGlzCj4gPiBzZW50ZW5jZSBzaG91bGQgZGlzYXBwZWFyIGJlY2F1c2UgaXQncyBt aXNsZWFkaW5nLgo+ID4gICAKPiA+PiAgPj4gPj4gID4+ICArICovICAKPiA+PiAgPj4gID4+ICAr aW50IG5hbmRfcmVhZF9wYWdlX2h3ZWNjX29vYl9maXJzdChzdHJ1Y3QgbmFuZF9jaGlwICpjaGlw LCA+PiA+PiB1aW50OF90ID4+ICpidWYsCj4gPj4gID4+ICA+PiAgKwkJCQkgICBpbnQgb29iX3Jl cXVpcmVkLCBpbnQgcGFnZSkKPiA+PiAgPj4gID4+ICArewo+ID4+ICA+PiAgPj4gICsJc3RydWN0 IG10ZF9pbmZvICptdGQgPSBuYW5kX3RvX210ZChjaGlwKTsKPiA+PiAgPj4gID4+ICArCWludCBp LCBlY2NzaXplID0gY2hpcC0+ZWNjLnNpemUsIHJldDsKPiA+PiAgPj4gID4+ICArCWludCBlY2Ni eXRlcyA9IGNoaXAtPmVjYy5ieXRlczsKPiA+PiAgPj4gID4+ICArCWludCBlY2NzdGVwcyA9IGNo aXAtPmVjYy5zdGVwczsKPiA+PiAgPj4gID4+ICArCXVpbnQ4X3QgKnAgPSBidWY7Cj4gPj4gID4+ ICA+PiAgKwl1aW50OF90ICplY2NfY29kZSA9IGNoaXAtPmVjYy5jb2RlX2J1ZjsKPiA+PiAgPj4g ID4+ICArCXVuc2lnbmVkIGludCBtYXhfYml0ZmxpcHMgPSAwOwo+ID4+ICA+PiAgPj4gICsKPiA+ PiAgPj4gID4+ICArCS8qIFJlYWQgdGhlIE9PQiBhcmVhIGZpcnN0ICovCj4gPj4gID4+ICA+PiAg KwlyZXQgPSBuYW5kX3JlYWRfb29iX29wKGNoaXAsIHBhZ2UsIDAsIGNoaXAtPm9vYl9wb2ksID4+ ID4+ID4+IG10ZC0+b29ic2l6ZSk7Cj4gPj4gID4+ICA+PiAgKwlpZiAocmV0KQo+ID4+ICA+PiAg Pj4gICsJCXJldHVybiByZXQ7Cj4gPj4gID4+ICA+PiAgKwo+ID4+ICA+PiAgPj4gICsJcmV0ID0g bmFuZF9yZWFkX3BhZ2Vfb3AoY2hpcCwgcGFnZSwgMCwgTlVMTCwgMCk7ICAKPiA+PiAgPj4gID4K PiA+PiAgPj4gID4gRGVmaW5pdGVseSBub3QsIHlvdXIgYXJlIHJlcXVlc3RpbmcgdGhlIGNoaXAg dG8gZG8gdGhlID4+IHJlYWRfcGFnZQo+ID4+ICA+PiAgPiBvcGVyYXRpb24gdHdpY2UuIFlvdSBv bmx5IG5lZWQgYSBuYW5kX2NoYW5nZV9yZWFkX2NvbHVtbiBJID4+ID4+IGJlbGlldmUuICAKPiA+ PiAgPj4gPj4gIEFnYWluLCB0aGlzIGNvZGUgaXMganVzdCBiZWluZyBtb3ZlZCBhcm91bmQgLSBk b24ndCBzaG9vdCA+PiB0aGUgPj4gbWVzc2VuZ2VyIDopICAKPiA+PiAgPgo+ID4+ICA+IGhhaGEK PiA+PiAgPgo+ID4+ICA+IFdlbGwsIG5vdyB5b3UgdG91Y2ggdGhlIGNvcmUsIHNvIEkgbmVlZCB0 byBiZSBtb3JlIGNhcmVmdWwsIGFuZCA+PiB0aGUKPiA+PiAgPiBjb2RlIGlzIGRlZmluaXRlbHkg d3JvbmcsIHNvIGV2ZW4gaWYgd2UgZG9uJ3QgbW92ZSB0aGF0IGNvZGUgb2ZmLCA+PiB5b3UKPiA+ PiAgPiBkZWZpbml0ZWx5IHdhbnQgdG8gZml4IGl0IGluIG9yZGVyIHRvIGltcHJvdmUgeW91ciBw ZXJmb3JtYW5jZXMuICAKPiA+PiA+PiAgSSBkb24ndCBzZWUgdGhlIHJlYWRfcGFnZSBiZWluZyBk b25lIHR3aWNlPwo+ID4+ID4+ICBUaGVyZSdzIG9uZSByZWFkX29vYiwgb25lIHJlYWRfcGFnZSwg dGhlbiByZWFkX2RhdGEgaW4gdGhlIGxvb3AuICAKPiA+IAo+ID4gcmVhZF9vb2IgYW5kIHJlYWRf cGFnZSBib3RoIGVuZCB1cCBzZW5kaW5nIFJFQUQwIGFuZCBSRUFEU1RBUlQgc28KPiA+IHRoZXkg ZG8gcmVxdWVzdCB0aGUgY2hpcCB0byBwZXJmb3JtIGFuIGludGVybmFsIHJlYWQgdHdpY2UuIFlv dQo+ID4gbmVlZCB0aGlzIG9ubHkgb25jZS4gVGhlIGNhbGwgdG8gbmFuZF9yZWFkX3BhZ2Vfb3Ao KSBzaG91bGQgYmUgYQo+ID4gbmFuZF9jaGFuZ2VfcmVhZF9jb2x1bW4oKSB3aXRoIG5vIGRhdGEg cmVxdWVzdGVkLiAgCj4gCj4gT0suCj4gCj4gPiAgIAo+ID4+ICA+PiAgPj4gICAvKioKPiA+PiAg Pj4gID4+ICAgICogbmFuZF9yZWFkX3BhZ2Vfc3luZHJvbWUgLSBbUkVQTEFDRUFCTEVdIGhhcmR3 YXJlIEVDQyA+PiA+PiBzeW5kcm9tZSA+PiBiYXNlZCBwYWdlIHJlYWQKPiA+PiAgPj4gID4+ICAg ICogQGNoaXA6IG5hbmQgY2hpcCBpbmZvIHN0cnVjdHVyZQo+ID4+ICA+PiAgPj4gIGRpZmYgLS1n aXQgYS9pbmNsdWRlL2xpbnV4L210ZC9yYXduYW5kLmggPj4gPj4gPj4gYi9pbmNsdWRlL2xpbnV4 L210ZC9yYXduYW5kLmgKPiA+PiAgPj4gID4+ICBpbmRleCBiMmY5ZGQzY2JkNjkuLjViODhjZDUx ZmFkYiAxMDA2NDQKPiA+PiAgPj4gID4+ICAtLS0gYS9pbmNsdWRlL2xpbnV4L210ZC9yYXduYW5k LmgKPiA+PiAgPj4gID4+ICArKysgYi9pbmNsdWRlL2xpbnV4L210ZC9yYXduYW5kLmgKPiA+PiAg Pj4gID4+ICBAQCAtMTUzOSw2ICsxNTM5LDggQEAgaW50IG5hbmRfcmVhZF9kYXRhX29wKHN0cnVj dCA+PiBuYW5kX2NoaXAgPj4gKmNoaXAsID4+IHZvaWQgKmJ1ZiwgdW5zaWduZWQgaW50IGxlbiwK PiA+PiAgPj4gID4+ICAgCQkgICAgICBib29sIGZvcmNlXzhiaXQsIGJvb2wgY2hlY2tfb25seSk7 Cj4gPj4gID4+ICA+PiAgIGludCBuYW5kX3dyaXRlX2RhdGFfb3Aoc3RydWN0IG5hbmRfY2hpcCAq Y2hpcCwgY29uc3Qgdm9pZCA+PiAqYnVmLAo+ID4+ICA+PiAgPj4gICAJCSAgICAgICB1bnNpZ25l ZCBpbnQgbGVuLCBib29sIGZvcmNlXzhiaXQpOwo+ID4+ICA+PiAgPj4gICtpbnQgbmFuZF9yZWFk X3BhZ2VfaHdlY2Nfb29iX2ZpcnN0KHN0cnVjdCBuYW5kX2NoaXAgKmNoaXAsID4+ID4+IHVpbnQ4 X3QgPj4gKmJ1ZiwKPiA+PiAgPj4gID4+ICArCQkJCSAgIGludCBvb2JfcmVxdWlyZWQsIGludCBw YWdlKTsgIAo+ID4+ICA+PiAgPgo+ID4+ICA+PiAgPiBZb3UgY2VydGFpbmx5IHdhbnQgdG8gYWRk IHRoaXMgc3ltYm9sIGNsb3NlciB0byB0aGUgb3RoZXIgPj4gPj4gcmVhZC93cml0ZQo+ID4+ICA+ PiAgPiBwYWdlIGhlbHBlcnM/ICAKPiA+PiAgPj4gPj4gIFdoZXJlIHdvdWxkIHRoYXQgYmU/IFRo ZSBvdGhlciByZWFkL3dyaXRlIHBhZ2UgaGVscGVycyBhcmUgPj4gYWxsID4+ICJzdGF0aWMiIHNv IHRoZXkgZG9uJ3QgYXBwZWFyIGluIGFueSBoZWFkZXIuICAKPiA+PiAgPgo+ID4+ICA+IEkgYmVs aWV2ZSB3ZSBzaG91bGQga2VlcCB0aGlzIGhlYWRlciBsb2NhbCBhcyBsb25nIGFzIHRoZXJlIGFy ZSBubwo+ID4+ICA+IG90aGVyIHVzZXJzLiAgCj4gPj4gPj4gIEknbGwgbW92ZSBpdCB0byBpbnRl cm5hbC5oIHRoZW4uICAKPiA+IAo+ID4gV2h5IGRvIHlvdSB3YW50IHRvIHB1dCBpdCB0aGVyZSBp cyB0aGVyZSBpcyBvbmx5IG9uZSB1c2VyPyAgCj4gCj4gQnV0IHRoZXJlIGFyZSB0d28gdXNlcnM6 IGRhdmluY2lfbmFuZC5jIGFuZCAod2l0aCBwYXRjaCBbMy8zXSkgaW5nZW5pYy9pbmdlbmljX25h bmRfZHJ2LmMuCgpPaCByaWdodCBJIG1pc3NlZCB0aGF0IDopCgpUaGVuIHBsZWFzZSBhZGQgdHdv IHByZXBhcmF0aW9uIHBhdGNoZXMgd2hpY2g6Ci0gZml4ZXMgdGhlIGNvbW1lbnQgKHBsZWFzZSBy ZXdvcmQgaXQgY29tcGxldGVseSkKLSBhdm9pZCB0aGUgZG91YmxlIHJlYWRpbmcKCkFuZCBrZWVw IHRoZSBsb2NhdGlvbiB3aGVyZSB5b3UgbW92ZWQgaXQgKGluY2x1ZGluZyB0aGUgaGVhZGVyKSBh cy1pcy4KClRoYW5rcywKTWlxdcOobAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCkxpbnV4IE1URCBkaXNjdXNzaW9uIG1haWxpbmcgbGlzdApo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW10ZC8K