From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DFC7C433F5 for ; Fri, 15 Oct 2021 15:21:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0317761181 for ; Fri, 15 Oct 2021 15:21:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240963AbhJOPX6 (ORCPT ); Fri, 15 Oct 2021 11:23:58 -0400 Received: from foss.arm.com ([217.140.110.172]:44772 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232267AbhJOPX5 (ORCPT ); Fri, 15 Oct 2021 11:23:57 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7889411D4; Fri, 15 Oct 2021 08:21:50 -0700 (PDT) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A37723F66F; Fri, 15 Oct 2021 08:21:49 -0700 (PDT) Date: Fri, 15 Oct 2021 16:21:47 +0100 From: Cristian Marussi To: Sudeep Holla Cc: linux-clk@vger.kernel.org, Etienne Carriere , Gabriel Fernandez , Stephen Boyd Subject: Re: [PATCH] clk: Drop unused COMMON_CLK_STM32MP157_SCMI config Message-ID: <20211015152147.GD6376@e120937-lin> References: <20211015150043.140793-1-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211015150043.140793-1-sudeep.holla@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Fri, Oct 15, 2021 at 04:00:43PM +0100, Sudeep Holla wrote: > Commit 21e743300dd0 ("clk: stm32mp1: new compatible for secure RCC support") > introduced a new Kconfig option COMMON_CLK_STM32MP157_SCMI which is not > used anywhere. > > Further, it looks like this Kconfig option is just to select bunch of other > options which doesn't sound correct to me. There is no need for another > SCMI firmware based clock driver and hence the same applies for the config > option too. > > Let us just drop the unused COMMON_CLK_STM32MP157_SCMI before it gives > someone idea to write a specific clock driver for this SoC/platform. > > Cc: Etienne Carriere > Cc: Gabriel Fernandez > Cc: Stephen Boyd > Signed-off-by: Sudeep Holla > --- LGTM. Reviewed-by: Cristian Marussi Looking at the original commit, and guessing its original aim, is it not better to put some sort of WARN in the STM32MP157 driver when the specific "rcc-secure" compatible is found configured BUT !IS_ENABLED(COMMON_CLK_SCMI) ? Thanks, Cristian > drivers/clk/Kconfig | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > index c5b3dc97396a..b64058d1af2d 100644 > --- a/drivers/clk/Kconfig > +++ b/drivers/clk/Kconfig > @@ -339,16 +339,6 @@ config COMMON_CLK_STM32MP157 > help > Support for stm32mp157 SoC family clocks > > -config COMMON_CLK_STM32MP157_SCMI > - bool "stm32mp157 Clock driver with Trusted Firmware" > - depends on COMMON_CLK_STM32MP157 > - select COMMON_CLK_SCMI > - select ARM_SCMI_PROTOCOL > - default y > - help > - Support for stm32mp157 SoC family clocks with Trusted Firmware using > - SCMI protocol. > - > config COMMON_CLK_STM32F > def_bool COMMON_CLK && (MACH_STM32F429 || MACH_STM32F469 || MACH_STM32F746) > help > -- > 2.25.1 >