From: "Marek Behún" <kabel@kernel.org>
To: Simon Glass <sjg@chromium.org>, Tom Rini <trini@konsulko.com>
Cc: "U-Boot Mailing List" <u-boot@lists.denx.de>,
"Marek Behún" <marek.behun@nic.cz>
Subject: [PATCH v3 00/13] env_get_char() removal and env_get_f() refactor
Date: Sun, 17 Oct 2021 17:36:25 +0200 [thread overview]
Message-ID: <20211017153638.29870-1-kabel@kernel.org> (raw)
From: Marek Behún <marek.behun@nic.cz>
Hi Simon, Tom,
env_get_char() is a relic from the past when env was read char-by-char
from underlying device. Currently it only accesses in-memory arrays.
We can remove it and access the arrays directly. This simplifies the old
code of env_get_f().
Changes since v2:
- added patch
env: Simplify env_match() and inline into env_get_f()
- remove patch
env: Check for terminating null-byte in env_match()
(not needed with the above patch added)
- changed order of patches a little
- rebased to accomodate the order change and the added and removed patch
Changes since v1:
- use memcpy() instead of strncpy() when copying value to buffer
- fixed a bug in patch adding check to terminating NULL-byte
- added patch fixing documentation for env_get_f()
- added patch changing behaviour of return value of env_get_f()
- some other cosmetic changes
Marek
Marek Behún (13):
env: Fix documentation for env_get_f()
env: Drop env_get_char_spec() and old, unused .get_char()
implementations
examples: api: glue: Remove comment that does not apply anymore
env: Change env_match() to static and remove from header
env: Inline env_get_char() into its only user
env: Use string pointer instead of indexes in env_get_f()
env: Use better name for variable in env_get_f()
env: Don't match empty variable name in env_match()
env: Early return from env_get_f() on NULL name
env: Make return value of env_get_f() behave like sprintf() on success
env: Use memcpy() instead of ad-hoc code to copy variable value
env: Simplify env_match() and inline into env_get_f()
env: Move non-cli env functions to env/common.c
cmd/nvedit.c | 188 --------------------------------------------
env/common.c | 180 ++++++++++++++++++++++++++++++++++++++++++
env/eeprom.c | 18 -----
env/env.c | 13 ---
env/nowhere.c | 5 +-
env/nvram.c | 14 ----
examples/api/glue.c | 5 --
include/env.h | 24 +-----
8 files changed, 184 insertions(+), 263 deletions(-)
--
2.32.0
next reply other threads:[~2021-10-17 15:37 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-17 15:36 Marek Behún [this message]
2021-10-17 15:36 ` [PATCH v3 01/13] env: Fix documentation for env_get_f() Marek Behún
2021-10-21 18:49 ` Simon Glass
2021-10-17 15:36 ` [PATCH v3 02/13] env: Drop env_get_char_spec() and old, unused .get_char() implementations Marek Behún
2021-10-21 18:49 ` Simon Glass
2021-10-17 15:36 ` [PATCH v3 03/13] examples: api: glue: Remove comment that does not apply anymore Marek Behún
2021-10-21 18:49 ` Simon Glass
2021-10-17 15:36 ` [PATCH v3 04/13] env: Change env_match() to static and remove from header Marek Behún
2021-10-21 18:49 ` Simon Glass
2021-10-17 15:36 ` [PATCH v3 05/13] env: Inline env_get_char() into its only user Marek Behún
2021-10-21 18:49 ` Simon Glass
2021-10-17 15:36 ` [PATCH v3 06/13] env: Use string pointer instead of indexes in env_get_f() Marek Behún
2021-10-21 18:49 ` Simon Glass
2021-10-17 15:36 ` [PATCH v3 07/13] env: Use better name for variable " Marek Behún
2021-10-21 18:49 ` Simon Glass
2021-10-17 15:36 ` [PATCH v3 08/13] env: Don't match empty variable name in env_match() Marek Behún
2021-10-21 18:49 ` Simon Glass
2021-10-17 15:36 ` [PATCH v3 09/13] env: Early return from env_get_f() on NULL name Marek Behún
2021-10-21 18:49 ` Simon Glass
2021-10-17 15:36 ` [PATCH v3 10/13] env: Make return value of env_get_f() behave like sprintf() on success Marek Behún
2021-10-21 18:49 ` Simon Glass
2021-10-17 15:36 ` [PATCH v3 11/13] env: Use memcpy() instead of ad-hoc code to copy variable value Marek Behún
2021-10-21 18:49 ` Simon Glass
2021-10-17 15:36 ` [PATCH v3 12/13] env: Simplify env_match() and inline into env_get_f() Marek Behún
2021-10-18 18:12 ` Simon Glass
2021-10-19 0:49 ` Marek Behún
2021-10-19 14:11 ` Simon Glass
2021-10-21 18:49 ` Simon Glass
2021-10-17 15:36 ` [PATCH v3 13/13] env: Move non-cli env functions to env/common.c Marek Behún
2021-10-21 18:49 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211017153638.29870-1-kabel@kernel.org \
--to=kabel@kernel.org \
--cc=marek.behun@nic.cz \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.