From: Christoph Hellwig <hch@lst.de>
To: Zqiang <qiang.zhang1211@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>, Hao Sun <sunhao.th@gmail.com>,
Hillf Danton <hdanton@sina.com>,
hch@infradead.org, willy@infradead.org,
Linux MM <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
syzkaller-bugs@googlegroups.com
Subject: Re: WARNING in __init_work
Date: Mon, 18 Oct 2021 10:15:05 +0200 [thread overview]
Message-ID: <20211018081505.GA28629@lst.de> (raw)
In-Reply-To: <a46dfeb8-8217-c0cc-bdce-08a7605a5a25@gmail.com>
On Mon, Oct 18, 2021 at 03:21:18PM +0800, Zqiang wrote:
> I find in add_partition(), if the device_add() return error, we will drop
> disk object reference count,
>
> but i find put_device(pdev) (will call part_release())and put_disk(disk),
> both will reduce the reference of the disk object , however we call
> get_device(disk_to_dev(disk)) only once
>
> or Did I miss something and didn't analyze it？
Yes, this sounds correct. Do you want to send a patch or should I
prepare one?
prev parent reply other threads:[~2021-10-18 8:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 1:22 WARNING in __init_work Hao Sun
2021-09-07 7:44 ` Hillf Danton
2021-10-14 2:38 ` Hao Sun
2021-10-18 4:43 ` Zqiang
2021-10-18 4:47 ` Christoph Hellwig
2021-10-18 7:21 ` Zqiang
2021-10-18 8:15 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211018081505.GA28629@lst.de \
--to=hch@lst.de \
--cc=hch@infradead.org \
--cc=hdanton@sina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=qiang.zhang1211@gmail.com \
--cc=sunhao.th@gmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.