From: Christoph Hellwig <hch@lst.de>
To: Coly Li <colyli@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, linux-bcache@vger.kernel.org
Subject: Re: [PATCH 1/4] bcache: remove the cache_dev_name field from struct cache
Date: Mon, 18 Oct 2021 17:35:14 +0200 [thread overview]
Message-ID: <20211018153514.GA32633@lst.de> (raw)
In-Reply-To: <8c9e20f7-7a58-9ee7-c592-63d5a6162f94@suse.de>
On Mon, Oct 18, 2021 at 11:32:26PM +0800, Coly Li wrote:
> It was in Linux v4.17 time, when I did the device failure handling. If the
> underlying device broken and gone, printing the device name string will be
> a "null" string in kmesg. But the device name was necessary for proper
> device failure information, we stored the device name string when it was
> initialized.
I'm pretty sure that was before the %pg specifier and the
hd_struct/block_device unification. With the current code there is no
way it could print null.
next prev parent reply other threads:[~2021-10-18 15:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 6:09 misc bcache cleanups Christoph Hellwig
2021-10-18 6:09 ` [PATCH 1/4] bcache: remove the cache_dev_name field from struct cache Christoph Hellwig
2021-10-18 14:26 ` Coly Li
2021-10-18 15:21 ` Christoph Hellwig
2021-10-18 15:32 ` Coly Li
2021-10-18 15:35 ` Christoph Hellwig [this message]
2021-10-18 15:38 ` Coly Li
2021-10-18 6:09 ` [PATCH 2/4] bcache: remove the backing_dev_name field from struct cached_dev Christoph Hellwig
2021-10-18 14:28 ` Coly Li
2021-10-18 6:09 ` [PATCH 3/4] bcache: use bvec_kmap_local in bch_data_verify Christoph Hellwig
2021-10-18 14:31 ` Coly Li
2021-10-18 6:09 ` [PATCH 4/4] bcache: remove bch_crc64_update Christoph Hellwig
2021-10-18 14:33 ` Coly Li
2021-10-18 14:34 ` misc bcache cleanups Coly Li
2021-10-19 5:31 ` Christoph Hellwig
2021-10-19 6:21 ` Coly Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211018153514.GA32633@lst.de \
--to=hch@lst.de \
--cc=colyli@suse.de \
--cc=linux-bcache@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.