From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Michael Rommel <rommel@layer-7.net>,
Fabrice Fontaine <fontaine.fabrice@gmail.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2,2/2] package/knock: add knockd option
Date: Mon, 18 Oct 2021 22:18:08 +0200 [thread overview]
Message-ID: <20211018201808.GT2400@scaer> (raw)
In-Reply-To: <20211018220427.5971bba1@windsurf>
Thomas, All,
On 2021-10-18 22:04 +0200, Thomas Petazzoni spake thusly:
> On Sat, 16 Oct 2021 11:32:34 +0200
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> > +ifeq ($(BR2_PACKAGE_KNOCK_KNOCKD),y)
> > +KNOCK_DEPENDENCIES = libpcap
> From commit 97f3ad7af3dd54a15a10aa35786e7fa08cf5e7b1:
> Repeat after me: "Forcing the value of <pkg>_DEPENDENCIES inside a
> conditional is the root of all evil."
> Care to repeat after me ? :-)
OK, I missed that in my review of v1...
/me hides in shame...
But seriously though: why is that not caught by check-package?
Because it is not actually an override: the variable is not yet set
there, so it is valid to unconditionally set it.
check-package should probably recognise that the variable is
<FOO>_DEPENDENCIES and consider that conditional assignment should
still be forbidden in that case.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-10-18 20:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-16 9:32 [Buildroot] [PATCH v2,1/2] package/knock: bump to version 0.8 Fabrice Fontaine
2021-10-16 9:32 ` [Buildroot] [PATCH v2,2/2] package/knock: add knockd option Fabrice Fontaine
2021-10-18 20:04 ` Thomas Petazzoni
2021-10-18 20:18 ` Yann E. MORIN [this message]
2021-10-21 18:43 ` [Buildroot] conditional assigment check in check-package [was: Re: [PATCH v2, 2/2] package/knock: add knockd option] Arnout Vandecappelle
2021-10-21 20:12 ` Yann E. MORIN
2021-10-21 20:25 ` Arnout Vandecappelle
2021-10-18 20:03 ` [Buildroot] [PATCH v2,1/2] package/knock: bump to version 0.8 Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211018201808.GT2400@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=rommel@layer-7.net \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.