From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] tests: sample_python_dbus_next: ignore F821 flake8 error
Date: Mon, 18 Oct 2021 22:33:26 +0200 [thread overview]
Message-ID: <20211018203326.GU2400@scaer> (raw)
In-Reply-To: <20211018195822.2263226-1-arnout@mind.be>
Arnout, All,
On 2021-10-18 21:58 +0200, Arnout Vandecappelle (Essensium/Mind) spake thusly:
> The dbus-next package uses the Python type annotation for dbus types. This is
> not compatible with the python typing assumption that flake8 makes.
>
> Exclude F821 from this line.
>
> Fixes: https://gitlab.com/buildroot.org/buildroot/-/jobs/1687009829
> partially:
> support/testing/tests/package/sample_python_dbus_next.py:17:36: F821 undefined name 's'
> support/testing/tests/package/sample_python_dbus_next.py:17:48: F821 undefined name 's'
> support/testing/tests/package/sample_python_dbus_next.py:17:56: F821 undefined name 's'
>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
You beat me to it, but I still managed to put my little touch: I've
changed the title to: support/testing: ...
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> support/testing/tests/package/sample_python_dbus_next.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/support/testing/tests/package/sample_python_dbus_next.py b/support/testing/tests/package/sample_python_dbus_next.py
> index 1fcb76f45a..710bfa8c04 100644
> --- a/support/testing/tests/package/sample_python_dbus_next.py
> +++ b/support/testing/tests/package/sample_python_dbus_next.py
> @@ -14,7 +14,7 @@ class SampleInterface(ServiceInterface):
> pass
>
> @method()
> - def ConcatStrings(self, what1: 's', what2: 's') -> 's':
> + def ConcatStrings(self, what1: 's', what2: 's') -> 's': # noqa: F821
> return what1 + what2
>
>
> --
> 2.31.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-10-18 20:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 19:58 [Buildroot] [PATCH 1/2] tests: sample_python_dbus_next: ignore F821 flake8 error Arnout Vandecappelle (Essensium/Mind)
2021-10-18 19:58 ` [Buildroot] [PATCH 2/2] treewide: fix flake8 error E741 ambiguous variable name Arnout Vandecappelle (Essensium/Mind)
2021-10-18 20:34 ` Yann E. MORIN
2021-10-25 12:12 ` Peter Korsgaard
2021-10-18 20:33 ` Yann E. MORIN [this message]
2021-10-25 12:10 ` [Buildroot] [PATCH 1/2] tests: sample_python_dbus_next: ignore F821 flake8 error Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211018203326.GU2400@scaer \
--to=yann.morin.1998@free.fr \
--cc=arnout@mind.be \
--cc=buildroot@buildroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.