From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Alexander Dahl <post@lespocky.de>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/fastd: bump version to 22
Date: Mon, 18 Oct 2021 21:22:17 +0200 [thread overview]
Message-ID: <20211018212217.727be240@windsurf> (raw)
In-Reply-To: <20211017152511.32136-1-post@lespocky.de>
On Sun, 17 Oct 2021 17:25:11 +0200
Alexander Dahl <post@lespocky.de> wrote:
> There's a new feature to offload L2TP to the Linux kernel, which depends
> on libmnl. A new menu option was introduced for that.
>
> It's possible to link an internal version of libmnl
> statically for smaller binary size on constraint targets, but this was
> not added to the buildroot package for complexity reasons (both build
> and licensing).
>
> The COPYING file gained an additional paragraph for internal libmnl
> which does not apply, because internal libmnl is not used in the
> package.
Thanks for providing this explanation, very good!
> +config BR2_PACKAGE_FASTD_OFFLOAD_L2TP
> + bool "l2tp offload support"
> + default y
I don't think there was much reason for this option to be enabled by
default, and we try to not enable optional features by default in
Buildroot, so I dropped this "default y" when applying.
Applied to master this change. Thanks!
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2021-10-18 19:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-17 15:25 [Buildroot] [PATCH] package/fastd: bump version to 22 Alexander Dahl
2021-10-18 19:22 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211018212217.727be240@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=post@lespocky.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.