All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Tiwei Bie <tiwei.bie@intel.com>,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v4 0/2] virtio_ring: check desc == NULL when packed and indirect
Date: Tue, 19 Oct 2021 09:23:49 -0400	[thread overview]
Message-ID: <20211019092251-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20211019115235.106507-1-xuanzhuo@linux.alibaba.com>

On Tue, Oct 19, 2021 at 07:52:33PM +0800, Xuan Zhuo wrote:
> In the case of packed, use indirect desc, since desc is allocated by
> kmalloc_array(), we should check whether its return value is NULL.
> 

a better description here:

fix theoretical issues in virtio_ring (so I'm guessing - or did
you observe any null pointer dereferences?)

> v4:
>    Inside the #2 patch, virtqueue_add_indirect_packed() return -EAGAIN when
>    desc == NULL.
> 
> v3:
>     Update commit message of the #1 patch.
> 
> v2:
>     Separate the style fix into a single patch.
> 
> 
> Xuan Zhuo (2):
>   virtio_ring: fix style of virtqueue_add_indirect_packed
>   virtio_ring: check desc == NULL when using indirect with packed
> 
>  drivers/virtio/virtio_ring.c | 25 ++++++++++++++++---------
>  1 file changed, 16 insertions(+), 9 deletions(-)
> 
> --
> 2.31.0

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

      parent reply	other threads:[~2021-10-19 13:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-19 11:52 [PATCH v4 0/2] virtio_ring: check desc == NULL when packed and indirect Xuan Zhuo
2021-10-19 11:52 ` [PATCH v4 1/2] virtio_ring: fix style of virtqueue_add_indirect_packed Xuan Zhuo
2021-10-19 13:22   ` Michael S. Tsirkin
2021-10-19 11:52 ` [PATCH v4 2/2] virtio_ring: check desc == NULL when using indirect with packed Xuan Zhuo
2021-10-19 13:21   ` Michael S. Tsirkin
2021-10-20  2:19     ` Xuan Zhuo
2021-10-20  8:24       ` Michael S. Tsirkin
2021-10-20 11:07         ` Xuan Zhuo
2021-10-20 14:52           ` Michael S. Tsirkin
2021-10-21  1:54             ` Xuan Zhuo
2021-10-19 13:24   ` Michael S. Tsirkin
2021-10-19 13:23 ` Michael S. Tsirkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211019092251-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=davem@davemloft.net \
    --cc=tiwei.bie@intel.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.