diff for duplicates of <202110191022090370609@zte.com.cn> diff --git a/a/content_digest b/N1/content_digest index e5d8d91..f909786 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,6 +1,6 @@ "ref\0YW024pwrV7fLgV/2@intel.com\0" "From\0<luo.penghao@zte.com.cn>\0" - "Subject\0Re: [Intel-gfx] [PATCH linux-next] drm/i915/display: Remove unused variable and its assignment.\0" + "Subject\0Re:[PATCH linux-next] drm/i915/display: Remove unused variable and its assignment.\0" "Date\0Tue, 19 Oct 2021 10:22:09 +0800 (CST)\0" "To\0<ville.syrjala@linux.intel.com>\0" "Cc\0<cgel.zte@gmail.com>" @@ -38,4 +38,4 @@ "b\0" "<div class=\"zcontentRow\"><p style=\"font-size:14px;font-family:\345\276\256\350\275\257\351\233\205\351\273\221,Microsoft YaHei;\">> This one we could use. For some reason we hardcode it to<br></p><p style=\"font-size:14px;font-family:\345\276\256\350\275\257\351\233\205\351\273\221,Microsoft YaHei;\">> 1 now, which is correct for our use cases but I don't really<br style=\"white-space: normal;\">> see a reason to hardcode it here. We are supposed to calculate<br style=\"white-space: normal;\">> it correctly after all, and chv_crtc_clock_get() also just blindly<br style=\"white-space: normal;\">> reads it out.<br style=\"white-space: normal;\">> <br style=\"white-space: normal;\">> > bestm2_frac = crtc_state->dpll.m2 & 0x3fffff;<br style=\"white-space: normal;\">> > - bestm1 = crtc_state->dpll.m1;<br style=\"white-space: normal;\">> <br style=\"white-space: normal;\">> This one is a bit trickier since I don't think the spec even<br style=\"white-space: normal;\">> gives us other values. But we could assert that it's correct.<br style=\"white-space: normal;\">> <br style=\"white-space: normal;\">> Some something along these lines I think would be best:<br style=\"white-space: normal;\">> + drm_WARN_ON(&dev_priv->drm, bestm1 != 2);<br style=\"white-space: normal;\">> vlv_dpio_write(dev_priv, pipe, CHV_PLL_DW1(port),<br style=\"white-space: normal;\">> DPIO_CHV_M1_DIV_BY_2 |<br style=\"white-space: normal;\">> - 1 << DPIO_CHV_N_DIV_SHIFT);<br style=\"white-space: normal;\">> + bestn << DPIO_CHV_N_DIV_SHIFT);</p><p style=\"font-size:14px;font-family:\345\276\256\350\275\257\351\233\205\351\273\221,Microsoft YaHei;\"><br></p><p style=\"font-size:14px;font-family:\345\276\256\350\275\257\351\233\205\351\273\221,Microsoft YaHei;\">Thanks for your kind response ! Does that means the variable will be</p><p style=\"font-size:14px;font-family:\345\276\256\350\275\257\351\233\205\351\273\221,Microsoft YaHei;\">used by the hardware\357\274\237if so as far as I see it, I don't seem to see the</p><p style=\"font-size:14px;font-family:\345\276\256\350\275\257\351\233\205\351\273\221,Microsoft YaHei;\">relevant interface.</p><p style=\"font-size:14px;font-family:\345\276\256\350\275\257\351\233\205\351\273\221,Microsoft YaHei;\"><br></p></div>" -12056f6a5d66f36af46aa73a686fd3313976b67a7912abbf1ad7e0175f464608 +632e4c617d7cd02f6a1c69afa6209d6bba8ee5243f1cd969681877bfd9f1b424
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.