From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0C76C433F5 for ; Tue, 19 Oct 2021 12:55:12 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E5C5A6135E for ; Tue, 19 Oct 2021 12:55:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E5C5A6135E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8B9428203C; Tue, 19 Oct 2021 14:55:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="mM5ESYSm"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6782982DF6; Tue, 19 Oct 2021 14:54:48 +0200 (CEST) Received: from mail-qv1-xf34.google.com (mail-qv1-xf34.google.com [IPv6:2607:f8b0:4864:20::f34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5B15480ECC for ; Tue, 19 Oct 2021 14:54:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf34.google.com with SMTP id j12so12141461qvk.12 for ; Tue, 19 Oct 2021 05:54:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=B1aja6JBb7zwwE/ZK0JwDLQ7B7j8tBci/lYayXBOJJE=; b=mM5ESYSmqCJFojnTlOI4KLnEC2dctSjG0Shuw1tVo237DGQw3p1aVRkJ+qbNnQ+Vw2 oiOBqyeELexOtJ5eVj3Q7X87D7llj5QmoFwYwYJPhcAa9wnL6X2/Pq8NLUGjSm4bbmst wd2WCwzhZTjXRLfuc89qjS9nwuC3j4lH+pWhg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=B1aja6JBb7zwwE/ZK0JwDLQ7B7j8tBci/lYayXBOJJE=; b=afMxwanPYfCWDBLIogfW1lfkFLbu2wLSo0Pe+IBVj87scop4SRq9KE4yGkN/8UAtnk a3OkKMg/oSIT1GIBUG2IbhdMcjRNL/+OqUMB63WN6UgBOV7+WMHGmJBWAZuB1XX8iUnN TRqe0exDWVtSsHkS1GVAf5s7GwRheH6DZ0F7b1az/gIbWS6zCoRNbpnmv84IvvKdGFTQ 0dftq9tW4nRXw80RU/2f193Xat75LrCWQVM95H5HmwWNjDPTFDsNNwi/5/18V/ExfTQk IJHksjmmKRNbBky4V+voYUN9+V8owpCE6s6rkAaD3yYDm3yV3IBhois7mdNV3uZAknr/ y/fQ== X-Gm-Message-State: AOAM531JOaEmey29ac7C2l+VAzIkGPdkRjKNC4Z3yVoEet5bzvefZ347 VY36Bdw84BrDhm1kp/8RQTqxXA== X-Google-Smtp-Source: ABdhPJwdQYBqkKO46qL/0B53/QHXGwjhWmKPUjZ3UVrn3qFsockPt2oL6sfbf2czO+FeqDcGSNC3Vg== X-Received: by 2002:ad4:590e:: with SMTP id ez14mr31210255qvb.62.1634648078979; Tue, 19 Oct 2021 05:54:38 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-b5ac-d4ae-96e7-5d3d.res6.spectrum.com. [2603:6081:7b01:cbda:b5ac:d4ae:96e7:5d3d]) by smtp.gmail.com with ESMTPSA id u16sm8584448qki.47.2021.10.19.05.54.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Oct 2021 05:54:38 -0700 (PDT) Date: Tue, 19 Oct 2021 08:54:34 -0400 From: Tom Rini To: Ilias Apalodimas Cc: sjg@chromium.org, Patrick Delaunay , Patrice Chotard , Liviu Dudau , Thomas Fitzsimmons , Matthias Brugger , Michal Simek , Pali =?iso-8859-1?Q?Roh=E1r?= , Marek =?iso-8859-1?Q?Beh=FAn?= , Bin Meng , Heinrich Schuchardt , Stefan Roese , Tim Harvey , Harald Seiler , Sughosh Ganu , Priyanka Jain , Vladimir Oltean , Andre Przywara , Ramon Fried , Nicolas Saenz Julienne , Peter Robinson , "Ivan T. Ivanov" , Marek Szyprowski , Leo Yu-Chi Liang , Zong Li , Sean Anderson , Rick Chen , Green Wan , T Karthik Reddy , Ashok Reddy Soma , Alper Nebi Yasak , AKASHI Takahiro , Wasim Khan , Alexandru Gagniuc , Nandor Han , Steffen Jaeckel , Heiko Schocher , Asherah Connor , u-boot@lists.denx.de, uboot-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH v3] sandbox: Remove OF_HOSTFILE Message-ID: <20211019125434.GX7964@bill-the-cat> References: <20211015084243.285423-1-ilias.apalodimas@linaro.org> <20211018205033.GA3078606@bill-the-cat> <20211019002924.GW7964@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="0BDWBegILtPtvHW0" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-Mailman-Approved-At: Tue, 19 Oct 2021 14:55:08 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --0BDWBegILtPtvHW0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 19, 2021 at 02:16:52PM +0300, Ilias Apalodimas wrote: > On Tue, Oct 19, 2021 at 10:56:26AM +0300, Ilias Apalodimas wrote: > > On Mon, Oct 18, 2021 at 08:29:24PM -0400, Tom Rini wrote: > > > On Mon, Oct 18, 2021 at 04:50:33PM -0400, Tom Rini wrote: > > > > On Fri, Oct 15, 2021 at 11:42:40AM +0300, Ilias Apalodimas wrote: > > > >=20 > > > > > OF_HOSTFILE is used on sandbox configs only. Although it's pretty > > > > > unique and rarely causes confusion, we are better of having simp= ler > > > > > config options for the DTB. > > > > >=20 > > > > > So let's replace that with the existing OF_BOARD. U-Boot would t= hen > > > > > have only three config options for the DTB origin. > > > > > - OF_SEPARATE, build separately from U-Boot > > > > > - OF_BOARD, board specific way of providing the DTB > > > > > - OF_EMBED embedded in the u-boot binary(should not be used in pr= oduction) > > > > >=20 > > > > > Signed-off-by: Ilias Apalodimas > > > > > --- > > > > > Note that this must be applied on top of > > > > > https://lore.kernel.org/u-boot/20211011210016.135929-1-ilias.apal= odimas@linaro.org/ > > > > > changes since v2: > > > > > - Rebased on top of the updated OF_BOARD patchset > > > > > Changes since v1: > > > > > - Added internal error value on board_fdt_blob_setup(). Arguably > > > > > we can just check against NULL and simplify this even more if we > > > > > don't care about the errno > > > > > - OF_BOARD is now default for sandbox builds > > > >=20 > > > > With the previous series applied, this breaks xilinx_zynq_virt: > > > > https://source.denx.de/u-boot/u-boot/-/jobs/337428=20 > > > >=20 > > > > I had a little trouble in general getting the board to run locally,= even > > > > without the patches, so I didn't debug further yet. > > >=20 > > > Here's another thing, that might be related. The dependency series h= as > > > minor size changes, in basically expected platforms and places. This > > > patch adds tons of size changes on virtually all platforms. That mig= ht > > > provide a clue or two as to what's going on. > >=20 > > I'll have a look. What changes here is an extra argument to preserve the > > errno (which we can get rid of). > >=20 > > >=20 > >=20 > > Is it the OF_HOSTFILE patch that breaks it? There's one thing this pat= ch > > changes in functionality. In the new version fdtdec_setup() will retur= n an > > error if the DTB is not found. =20 > > Can I reproduce this locally? >=20 > Right, I did find a way to reproduce it locally. It's indeed the change = in > fdtdec_setup() that break this platform. Specifically > board_fdt_blob_setup() in board/xilinx/common/board.c will return -ENXIO = if > the DTB is not found. Apparently that's ok for this platform so returning > 0 there fixes the boot. It's also another reason why we need the errno > instead of just checking the pointer .... > Want me to send a v4 of the OF_HOSTFILE version? Yes please, thanks. --=20 Tom --0BDWBegILtPtvHW0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmFuwAcACgkQFHw5/5Y0 tyyMZwv9Eq2CxM0b3FnXjCwknoo4XkP5zQ/0tqIp/KO3X2qlusRBKYXtNy+lN2fZ cXM/xDSZDPW9Bcql8Jq3iJkiNtKm72eHJ2nWYpDujQ4Rc0l5cbZtYHZhk0ksgej2 DpdwG+n64rv6Q6v7gHCt6tuYbh8g+WQkRQHjSL3R4IQUh8SWdytU+M6zeHIlHum5 GAN+3rNp7o1JUw751BPjfIFCPT8VlgRli69lANAxS2yRsBpM2+QRXqkf7jrhfWHF lh2D8NvSKhOhJKg+QJ6SrPtMR77EbTmNNij7xCyuM7n43YUBqJFZEF2oOvZHeLy8 PjVBXHj7kUz9tRU8qRW5MUiQMLMP9xM4tGR46/DJzbtyd9aMZozuCrypckj59NKO xNY3ZdrB5uN1gZL+/cQY/p1DyCOYjHHnDKKKknplyYZsxVLfSe1TbgANxluOUYzW XQ12sqmTHyTo2KSV1+EAg/BKp2hWyqH5c1l0OtLdvOhZvCIArslQo3lCup11t8ED /YJnGoR4 =fdT2 -----END PGP SIGNATURE----- --0BDWBegILtPtvHW0--