From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, hch@lst.de
Subject: Re: [PATCH 2/2] block: attempt direct issue of plug list
Date: Tue, 19 Oct 2021 15:36:47 +0200 [thread overview]
Message-ID: <20211019133647.GB19216@lst.de> (raw)
In-Reply-To: <20211019120834.595160-3-axboe@kernel.dk>
On Tue, Oct 19, 2021 at 06:08:34AM -0600, Jens Axboe wrote:
> If we have just one queue type in the plug list, then we can extend our
> direct issue to cover a full plug list as well.
I don't think this description matches what the code does. My impression
of what the code does it:
If a plug only has requests for a single queue, and that queue does not
use an I/O scheduler, we can just issue the list of requests directly
from the plug.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2021-10-19 13:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 12:08 [PATCHSET v2] Improve plugging Jens Axboe
2021-10-19 12:08 ` [PATCH 1/2] block: change plugging to use a singly linked list Jens Axboe
2021-10-19 13:34 ` Christoph Hellwig
2021-10-19 13:45 ` Jens Axboe
2021-10-19 12:08 ` [PATCH 2/2] block: attempt direct issue of plug list Jens Axboe
2021-10-19 13:36 ` Christoph Hellwig [this message]
2021-10-19 13:45 ` Jens Axboe
2021-10-26 5:20 ` Shinichiro Kawasaki
2021-10-26 14:42 ` Jens Axboe
2021-10-27 2:16 ` Shinichiro Kawasaki
2021-10-27 1:13 ` Guenter Roeck
2021-10-27 2:36 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211019133647.GB19216@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.