All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	Petr Mladek <pmladek@suse.com>,
	linux-mm@kvack.org, Vlastimil Babka <vbabka@suse.cz>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: [PATCH v2 2/5] test_printf: Remove separate page_flags variable
Date: Tue, 19 Oct 2021 15:26:18 +0100	[thread overview]
Message-ID: <20211019142621.2810043-3-willy@infradead.org> (raw)
In-Reply-To: <20211019142621.2810043-1-willy@infradead.org>

Keep flags intact so that we also test what happens when unknown flags
are passed to %pGp.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
 lib/test_printf.c | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/lib/test_printf.c b/lib/test_printf.c
index a52c1c3a55ba..4531063afd45 100644
--- a/lib/test_printf.c
+++ b/lib/test_printf.c
@@ -605,17 +605,15 @@ static const struct page_flags_test pft[] = {
 
 static void __init
 page_flags_test(int section, int node, int zone, int last_cpupid,
-		int kasan_tag, int flags, const char *name, char *cmp_buf)
+		int kasan_tag, unsigned long flags, const char *name,
+		char *cmp_buf)
 {
 	unsigned long values[] = {section, node, zone, last_cpupid, kasan_tag};
-	unsigned long page_flags = 0;
 	unsigned long size = 0;
 	bool append = false;
 	int i;
 
-	flags &= PAGEFLAGS_MASK;
-	if (flags) {
-		page_flags |= flags;
+	if (flags & PAGEFLAGS_MASK) {
 		snprintf(cmp_buf + size, BUF_SIZE - size, "%s", name);
 		size = strlen(cmp_buf);
 #if SECTIONS_WIDTH || NODES_WIDTH || ZONES_WIDTH || \
@@ -635,7 +633,7 @@ page_flags_test(int section, int node, int zone, int last_cpupid,
 			size = strlen(cmp_buf);
 		}
 
-		page_flags |= (values[i] & pft[i].mask) << pft[i].shift;
+		flags |= (values[i] & pft[i].mask) << pft[i].shift;
 		snprintf(cmp_buf + size, BUF_SIZE - size, "%s=", pft[i].name);
 		size = strlen(cmp_buf);
 		snprintf(cmp_buf + size, BUF_SIZE - size, pft[i].fmt,
@@ -644,7 +642,7 @@ page_flags_test(int section, int node, int zone, int last_cpupid,
 		append = true;
 	}
 
-	test(cmp_buf, "%pGp", &page_flags);
+	test(cmp_buf, "%pGp", &flags);
 }
 
 static void __init
-- 
2.32.0



  parent reply	other threads:[~2021-10-19 14:30 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-19 14:26 [PATCH v2 0/5] Improvements to %pGp Matthew Wilcox (Oracle)
2021-10-19 14:26 ` [PATCH v2 1/5] test_printf: Make pft array const Matthew Wilcox (Oracle)
2021-10-19 14:26 ` Matthew Wilcox (Oracle) [this message]
2021-10-22 15:12   ` [PATCH v2 2/5] test_printf: Remove separate page_flags variable Yafang Shao
2021-10-27  9:47   ` Petr Mladek
2021-10-19 14:26 ` [PATCH v2 3/5] test_printf: Remove custom appending of '|' Matthew Wilcox (Oracle)
2021-10-19 14:26 ` [PATCH v2 4/5] test_printf: Append strings more efficiently Matthew Wilcox (Oracle)
2021-10-22 15:13   ` Yafang Shao
2021-10-27 10:14   ` Petr Mladek
2021-10-19 14:26 ` [PATCH v2 5/5] vsprintf: Make %pGp print the hex value Matthew Wilcox (Oracle)
2021-10-22 15:14   ` Yafang Shao
2021-10-27 10:27   ` Petr Mladek
2021-10-27 12:48   ` [PATCH] vsprintf: Update %pGp documentation about that it prints " Petr Mladek
2021-10-29  2:15     ` Yafang Shao
2021-10-29  2:18       ` Yafang Shao
2021-11-02  9:35         ` Petr Mladek
2021-10-27 12:09 ` [PATCH v2 0/5] Improvements to %pGp Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211019142621.2810043-3-willy@infradead.org \
    --to=willy@infradead.org \
    --cc=laoar.shao@gmail.com \
    --cc=linux-mm@kvack.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=pmladek@suse.com \
    --cc=senozhatsky@chromium.org \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.