From: "Denys Dmytriyenko" <denis@denix.org>
To: vigneshr@ti.com
Cc: yogeshs@ti.com, Praneeth Bajjuri <praneeth@ti.com>,
meta-ti@lists.yoctoproject.org
Subject: Re: [EXTERNAL] [meta-ti][master/dunfell][PATCH v2] ti-linux-fw: Support common inc for all firmware
Date: Tue, 19 Oct 2021 13:03:22 -0400 [thread overview]
Message-ID: <20211019170322.GM10132@denix.org> (raw)
In-Reply-To: <727cc120-9113-42d6-f1dd-d4d9f31d9b6f@ti.com>
On Tue, Oct 19, 2021 at 08:46:29PM +0530, Vignesh Raghavendra via lists.yoctoproject.org wrote:
>
>
> On 10/19/21 6:49 PM, Yogesh Siraswar via lists.yoctoproject.org wrote:
> > Change to support common INC for all firmware
> > This will help with:
> > 1) Eliminating requirement to change multiple recipes for firmware
> > update
> > 2) This will help support AUTOREV
> >
> > Signed-off-by: Yogesh Siraswar <yogeshs@ti.com>
> > ---
>
> [...]
> > diff --git a/recipes-bsp/prueth-fw/prueth-fw-am65x_git.bb b/recipes-bsp/prueth-fw/prueth-fw-am65x_git.bb
> > index d447df33..246b872e 100644
> > --- a/recipes-bsp/prueth-fw/prueth-fw-am65x_git.bb
> > +++ b/recipes-bsp/prueth-fw/prueth-fw-am65x_git.bb
> > @@ -1,9 +1,9 @@
> > SUMMARY = "PRU Ethernet firmware for AM65x SR1.0"
> >
> > -LICENSE = "TI-TFL"
> > -LIC_FILES_CHKSUM = "file://LICENSE.ti;md5=b5aebf0668bdf95621259288c4a46d76"
> > +require recipes-bsp/ti-linux-fw/ti-linux-fw.inc
> >
> > -PV = "08.00.00.20"
> > +PV = "${PRUETH_FW_AM65x_SR2_VERSION}"
>
> Should be
>
> PV = "${PRUETH_FW_AM65x_VERSION}"
Also, "AM65x" lower case "x" here
> > +PR = "${INC_PR}.0"
> >
> > CLEANBROKEN = "1"
> >
> [...]
> > diff --git a/recipes-bsp/ti-sci-fw/ti-sci-fw.inc b/recipes-bsp/ti-linux-fw/ti-linux-fw.inc
> > similarity index 75%
> > rename from recipes-bsp/ti-sci-fw/ti-sci-fw.inc
> > rename to recipes-bsp/ti-linux-fw/ti-linux-fw.inc
> > index 9ce9f6c8..a910af2c 100644
> > --- a/recipes-bsp/ti-sci-fw/ti-sci-fw.inc
> > +++ b/recipes-bsp/ti-linux-fw/ti-linux-fw.inc
> > @@ -4,9 +4,18 @@ LICENSE = "TI-TFL"
> > LIC_FILES_CHKSUM = "file://LICENSE.ti;md5=b5aebf0668bdf95621259288c4a46d76"
> >
> > PV = "2021.05"
> > -INC_PR = "r0"
> > -# RTOS firmware version
> > +INC_PR = "r1"
> > +
> > +# Firmware versions
> > CORESDK_RTOS_VERSION = "08.00.00.32"
> > +SERDES_FW_VERSION = "3.3.0.2c"
> > +NETCP_SA_FW_VERSION = "1.0.0"
> > +NETCP_PA_FW_VERSION = "3.0.2.3"
> > +QMSS_PDSP_FW_VERSION = "1.0.0.9"
> > +PRUETH_FW_AM65X_VERSION = "08.00.00.20"
>
> ^^^
AM65X has uppercase X here. better to be consistent.
> > +PRUETH_FW_AM65x_SR2_VERSION = "02.02.09.03"
> > +GOODIX_FW_VERSION = "1.0.0.0"
> > +CADENCE_MHDP_FW_VERSION = "1.2.17"
> >
> > SRCREV = "793309716bce2e443f798dd5c5f0d8dd310970c0"
> > BRANCH ?= "ti-linux-firmware"
>
> [...]
> Regards
> Vignesh
next prev parent reply other threads:[~2021-10-19 17:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 13:19 [meta-ti][master/dunfell][PATCH v2] ti-linux-fw: Support common inc for all firmware Yogesh Siraswar
2021-10-19 15:16 ` [EXTERNAL] " Vignesh Raghavendra
2021-10-19 15:20 ` Yogesh Siraswar
2021-10-19 17:03 ` Denys Dmytriyenko [this message]
2021-10-19 18:38 ` Yogesh Siraswar
2021-10-19 20:38 ` Denys Dmytriyenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211019170322.GM10132@denix.org \
--to=denis@denix.org \
--cc=meta-ti@lists.yoctoproject.org \
--cc=praneeth@ti.com \
--cc=vigneshr@ti.com \
--cc=yogeshs@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.