All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Marek Behún" <marek.behun@nic.cz>
To: Simon Glass <sjg@chromium.org>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
	Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
	Heinrich Schuchardt <xypron.glpk@gmx.de>,
	Wolfgang Denk <wd@denx.de>, Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH v8 5/8] sandbox: Use a text-based environment
Date: Tue, 19 Oct 2021 18:07:49 +0200	[thread overview]
Message-ID: <20211019180749.25fb5f11@thinkpad> (raw)
In-Reply-To: <CAPnjgZ30dRT=yrUzhdH0BAJvLk_83NWntpdsmZamTa7uGhJhpw@mail.gmail.com>

On Tue, 19 Oct 2021 09:52:14 -0600
Simon Glass <sjg@chromium.org> wrote:

> Hi Marek,
> 
> On Tue, 19 Oct 2021 at 08:32, Marek Behún <marek.behun@nic.cz> wrote:
> >
> > On Mon, 18 Oct 2021 12:13:19 -0600
> > Simon Glass <sjg@chromium.org> wrote:
> >  
> > > --- /dev/null
> > > +++ b/board/sandbox/sandbox.env
> > > @@ -0,0 +1,25 @@
> > > +stdin=serial
> > > +#ifdef CONFIG_SANDBOX_SDL
> > > +stdin+=,cros-ec-keyb,usbkbd  
> >
> > this was CONFIG_KEYBOARD and now is CONFIG_SANDBOX_SDL, is this okay?  
> 
> The old code is:
> 
> #ifdef CONFIG_SANDBOX_SDL
> #define LCD_BPP LCD_COLOR16
> #define CONFIG_LCD_BMP_RLE8
> 
> #define CONFIG_KEYBOARD
> 
> #define SANDBOX_SERIAL_SETTINGS "stdin=serial,cros-ec-keyb,usbkbd\0" \
> "stdout=serial,vidconsole\0" \
> "stderr=serial,vidconsole\0"
> #else
> #define SANDBOX_SERIAL_SETTINGS "stdin=serial\0" \
> "stdout=serial,vidconsole\0" \
> "stderr=serial,vidconsole\0"
> #endif
> 
> 
> so really the check is on CONFIG_SANDBOX_SDL. The setting of
> CONFIG_KEYBOARD is not related to the environment.

Ah, sorry. In that case

Reviewed-by: Marek Behún <marek.behun@nic.cz>

  reply	other threads:[~2021-10-19 16:07 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-18 18:13 [PATCH v8 0/8] env: Allow environment in text files Simon Glass
2021-10-18 18:13 ` [PATCH v8 1/8] binman: Allow timeout to occur in the image or its section Simon Glass
2021-10-19 14:19   ` Marek Behún
2021-10-31 12:57     ` Simon Glass
2021-10-18 18:13 ` [PATCH v8 2/8] sandbox: Drop distro_boot Simon Glass
2021-10-19 14:20   ` Marek Behún
2021-10-18 18:13 ` [PATCH v8 3/8] doc: Move environment documentation to rST Simon Glass
2021-10-19 14:21   ` Marek Behún
2021-10-18 18:13 ` [PATCH v8 4/8] env: Allow U-Boot scripts to be placed in a .env file Simon Glass
2021-10-19 10:57   ` Wolfgang Denk
2021-10-19 14:07   ` Tom Rini
2021-10-19 14:11     ` Simon Glass
2021-10-19 14:25       ` Tom Rini
2021-10-19 15:31         ` Simon Glass
2021-10-19 16:20           ` Wolfgang Denk
2021-10-19 16:24             ` Simon Glass
2021-10-19 16:30               ` Tom Rini
2021-10-19 16:39                 ` Simon Glass
2021-10-19 16:44                   ` Tom Rini
2021-10-19 18:21                     ` Simon Glass
2021-10-21  9:10                   ` Wolfgang Denk
2021-10-21  9:05                 ` Wolfgang Denk
2021-10-21  9:02               ` Wolfgang Denk
2021-10-19 16:05       ` Wolfgang Denk
2021-10-19 16:14         ` Simon Glass
2021-10-19 15:57     ` Wolfgang Denk
2021-10-19 15:11   ` Marek Behún
2021-10-18 18:13 ` [PATCH v8 5/8] sandbox: Use a text-based environment Simon Glass
2021-10-19 14:32   ` Marek Behún
2021-10-19 15:52     ` Simon Glass
2021-10-19 16:07       ` Marek Behún [this message]
2021-10-18 18:13 ` [PATCH v8 6/8] doc: Mention CONFIG_DEFAULT_ENV_FILE Simon Glass
2021-10-19 14:34   ` Marek Behún
2021-10-19 15:52     ` Simon Glass
2021-10-19 16:07       ` Marek Behún
2021-10-19 18:20         ` Simon Glass
2021-10-18 18:13 ` [PATCH v8 7/8] doc: Improve environment documentation Simon Glass
2021-10-19 14:36   ` Marek Behún
2021-10-18 18:13 ` [PATCH v8 8/8] bootm: Tidy up use of autostart env var Simon Glass
2021-10-19 14:38   ` Marek Behún
2021-10-19 10:48 ` [PATCH v8 0/8] env: Allow environment in text files Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211019180749.25fb5f11@thinkpad \
    --to=marek.behun@nic.cz \
    --cc=rasmus.villemoes@prevas.dk \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=wd@denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.