From: Tom Rini <trini@konsulko.com>
To: Simon Glass <sjg@chromium.org>
Cc: "Marek Vasut" <marex@denx.de>,
"Vagrant Cascadian" <vagrant@debian.org>,
"Masahiro Yamada" <yamada.masahiro@socionext.com>,
"Heinrich Schuchardt" <xypron.glpk@gmx.de>,
"Bin Meng" <bmeng.cn@gmail.com>,
"Marek Behún" <marek.behun@nic.cz>,
"Pali Rohár" <pali@kernel.org>,
u-boot@lists.denx.de
Subject: Re: [PATCH v3 2/2] Makefile: Only build dtc if needed
Date: Tue, 19 Oct 2021 20:46:03 -0400 [thread overview]
Message-ID: <20211020004603.GN7964@bill-the-cat> (raw)
In-Reply-To: <20210922173444.192256-2-sjg@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 578 bytes --]
On Wed, Sep 22, 2021 at 11:34:44AM -0600, Simon Glass wrote:
> At present U-Boot always builds dtc if CONFIG_OF_CONTROL is defined, even
> when DTC is provided. The built dtc is not actually used, so this is a
> waste of time.
>
> Update the Makefile logic to build dtc only if one is not provided to the
> build with the DTC variable. Add documentation to explain this.
>
> This saves about 3.5 seconds of elapsed time on a clean build of
> sandbox_spl for me.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2021-10-20 0:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 17:34 [PATCH v3 1/2] Revert "kbuild: remove unused dtc-version.sh script" Simon Glass
2021-09-22 17:34 ` [PATCH v3 2/2] Makefile: Only build dtc if needed Simon Glass
2021-10-20 0:46 ` Tom Rini [this message]
2021-10-20 0:45 ` [PATCH v3 1/2] Revert "kbuild: remove unused dtc-version.sh script" Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211020004603.GN7964@bill-the-cat \
--to=trini@konsulko.com \
--cc=bmeng.cn@gmail.com \
--cc=marek.behun@nic.cz \
--cc=marex@denx.de \
--cc=pali@kernel.org \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=vagrant@debian.org \
--cc=xypron.glpk@gmx.de \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.