From: Robin Jarry <robin.jarry@6wind.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, stable@dpdk.org,
Neil Horman <nhorman@tuxdriver.com>,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH] usertools/pmdinfo: fix plugin auto scan
Date: Wed, 20 Oct 2021 21:31:36 +0200 [thread overview]
Message-ID: <20211020193136.6tkty3fcxg4fk2ck@6wind.com> (raw)
In-Reply-To: <20211019125230.27480-1-david.marchand@redhat.com>
Hello,
2021-10-19, David Marchand:
> Migration to argparse was incomplete.
>
> $ dpdk-pmdinfo.py -p $(which dpdk-testpmd)
> Traceback (most recent call last):
> File "/usr/bin/dpdk-pmdinfo.py", line 626, in <module>
> main()
> File "/usr/bin/dpdk-pmdinfo.py", line 596, in main
> exit(scan_for_autoload_pmds(args[0]))
> TypeError: 'Namespace' object does not support indexing
>
> Fixes: 81255f27c65c ("usertools: replace optparse with argparse")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
It is sad that pylint does not report an error:
https://pycodequ.al/docs/pylint-messages/e1136-unsubscriptable-object.html
Anyway, this fix looks good.
Reviewed-by: Robin Jarry <robin.jarry@6wind.com>
next prev parent reply other threads:[~2021-10-20 19:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 12:52 [dpdk-dev] [PATCH] usertools/pmdinfo: fix plugin auto scan David Marchand
2021-10-20 19:31 ` Robin Jarry [this message]
2021-10-25 15:10 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211020193136.6tkty3fcxg4fk2ck@6wind.com \
--to=robin.jarry@6wind.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=nhorman@tuxdriver.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.