From: Kees Cook <keescook@chromium.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Shuah Khan <shuah@kernel.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
linux-kselftest@vger.kernel.org,
Josh Poimboeuf <jpoimboe@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Alexey Gladkov <gladkov.alexey@gmail.com>,
jannh@google.com, vcaputo@pengaru.com, mingo@redhat.com,
juri.lelli@redhat.com, vincent.guittot@linaro.org,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, bristot@redhat.com,
christian.brauner@ubuntu.com, amistry@google.com,
Kenta.Tada@sony.com, legion@kernel.org,
michael.weiss@aisec.fraunhofer.de, mhocko@suse.com,
deller@gmx.de, zhengqi.arch@bytedance.com, me@tobin.cc,
tycho@tycho.pizza, tglx@linutronix.de, bp@alien8.de,
hpa@zytor.com, axboe@kernel.dk, metze@samba.org,
laijs@linux.alibaba.com, luto@kernel.org,
dave.hansen@linux.intel.com, ebiederm@xmission.com,
ohoono.kwon@samsung.com, kaleshsingh@google.com,
yifeifz2@illinois.edu, linux-arch@vger.kernel.org,
vgupta@kernel.org, linux@armlinux.org.uk, will@kernel.org,
guoren@kernel.org, bcain@codeaurora.org, monstr@monstr.eu,
tsbogend@alpha.franken.de, nickhu@andestech.com,
jonas@southpole.se, mpe@ellerman.id.au, paul.walmsley@sifive.com,
hca@linux.ibm.com, ysato@users.sourceforge.jp,
davem@davemloft.net, chris@zankel.net,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH] selftests: proc: Make sure wchan works when it exists
Date: Thu, 21 Oct 2021 10:09:33 -0700 [thread overview]
Message-ID: <202110211008.CC8B26A@keescook> (raw)
In-Reply-To: <20211008235504.2957528-1-keescook@chromium.org>
On Fri, Oct 08, 2021 at 04:55:04PM -0700, Kees Cook wrote:
> This makes sure that wchan contains a sensible symbol when a process is
> blocked. Specifically this calls the sleep() syscall, and expects the
> architecture to have called schedule() from a function that has "sleep"
> somewhere in its name. For example, on the architectures I tested
> (x86_64, arm64, arm, mips, and powerpc) this is "hrtimer_nanosleep":
>
> $ tools/testing/selftests/proc/proc-pid-wchan
> ok: found 'sleep' in wchan 'hrtimer_nanosleep'
>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Shuah Khan <shuah@kernel.org>
> Cc: Alexey Dobriyan <adobriyan@gmail.com>
> Cc: linux-kselftest@vger.kernel.org
> Signed-off-by: Kees Cook <keescook@chromium.org>
Friendly ping.
> ---
> Hi Peter,
>
> Can you add this to the wchan series, please? This should help wchan from
> regressing in the future, and allow us to notice if the depth accidentally
> changes, like Mark saw.
> ---
I'd like to make sure we have a regression test for this. Will you add
this to the wchan series please?
-Kees
--
Kees Cook
next prev parent reply other threads:[~2021-10-21 17:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-08 23:55 [PATCH] selftests: proc: Make sure wchan works when it exists Kees Cook
2021-10-09 12:52 ` Alexey Dobriyan
2021-10-11 17:42 ` Kees Cook
2021-10-21 17:09 ` Kees Cook [this message]
2021-10-21 19:30 ` Peter Zijlstra
2021-10-21 20:10 ` Kees Cook
2021-10-21 20:03 ` Andy Lutomirski
2021-10-21 20:12 ` Kees Cook
2021-10-22 0:39 ` Andy Lutomirski
2021-10-22 3:35 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202110211008.CC8B26A@keescook \
--to=keescook@chromium.org \
--cc=Kenta.Tada@sony.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=amistry@google.com \
--cc=axboe@kernel.dk \
--cc=bcain@codeaurora.org \
--cc=bp@alien8.de \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=chris@zankel.net \
--cc=christian.brauner@ubuntu.com \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=dietmar.eggemann@arm.com \
--cc=ebiederm@xmission.com \
--cc=gladkov.alexey@gmail.com \
--cc=guoren@kernel.org \
--cc=hca@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=jannh@google.com \
--cc=jonas@southpole.se \
--cc=jpoimboe@redhat.com \
--cc=juri.lelli@redhat.com \
--cc=kaleshsingh@google.com \
--cc=laijs@linux.alibaba.com \
--cc=legion@kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=luto@kernel.org \
--cc=mark.rutland@arm.com \
--cc=me@tobin.cc \
--cc=metze@samba.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.com \
--cc=michael.weiss@aisec.fraunhofer.de \
--cc=mingo@redhat.com \
--cc=monstr@monstr.eu \
--cc=mpe@ellerman.id.au \
--cc=nickhu@andestech.com \
--cc=ohoono.kwon@samsung.com \
--cc=paul.walmsley@sifive.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=tycho@tycho.pizza \
--cc=vcaputo@pengaru.com \
--cc=vgupta@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=will@kernel.org \
--cc=yifeifz2@illinois.edu \
--cc=ysato@users.sourceforge.jp \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.