From: Simon Horman <horms@kernel.org>
To: luo penghao <cgel.zte@gmail.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
luo penghao <luo.penghao@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH linux-next] net/core: Remove unused assignment operations and variable
Date: Thu, 21 Oct 2021 12:44:17 +0200 [thread overview]
Message-ID: <20211021104412.GA26665@kernel.org> (raw)
In-Reply-To: <20211021064020.1047324-1-luo.penghao@zte.com.cn>
On Thu, Oct 21, 2021 at 06:40:20AM +0000, luo penghao wrote:
I think the bracketed part of the subject of your emails should be:
[PATCH v2 net-next]
* IIRC this is v2 of the patch
* The patch is targeted at the net-next tree
> Although if_info_size is assigned, it has not been used. And the variable
> should also be deleted.
>
> The clang_analyzer complains as follows:
>
> net/core/rtnetlink.c:3806: warning:
>
> Although the value stored to 'if_info_size' is used in the enclosing
> expression, the value is never actually read from 'if_info_size'.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: luo penghao <luo.penghao@zte.com.cn>
The above not withstanding, this patch looks correct to me.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2021-10-21 10:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 6:40 [PATCH linux-next] net/core: Remove unused assignment operations and variable luo penghao
2021-10-21 10:44 ` Simon Horman [this message]
2021-10-21 11:50 ` patchwork-bot+netdevbpf
-- strict thread matches above, loose matches on Subject: below --
2021-10-18 9:13 luo penghao
2021-10-20 9:21 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211021104412.GA26665@kernel.org \
--to=horms@kernel.org \
--cc=cgel.zte@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luo.penghao@zte.com.cn \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.