From: David Sterba <dsterba@suse.cz>
To: Omar Sandoval <osandov@osandov.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH v2] btrfs: fix deadlock when defragging transparent huge pages
Date: Thu, 21 Oct 2021 18:28:23 +0200 [thread overview]
Message-ID: <20211021162823.GG20319@twin.jikos.cz> (raw)
In-Reply-To: <321ffae6065e36a6c698912a86f8019ea00f43b4.1634700835.git.osandov@fb.com>
On Tue, Oct 19, 2021 at 08:35:01PM -0700, Omar Sandoval wrote:
> From: Omar Sandoval <osandov@fb.com>
> - Add comment to PageCompound() check. I didn't create a helper for it
> because it's not clear what function to wrap. It could be
> find_or_create_page(), find_lock_page(), or any other way we could get
> a page cache page. So, if we end up needing it anywhere else, we can
> create a common helper. For now, I think it's better to have an
> explicit check rather than obscure it behind a one-off helper.
Ok, the comment is sufficient for now. Added to misc-next, thanks.
prev parent reply other threads:[~2021-10-21 16:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 3:35 [PATCH v2] btrfs: fix deadlock when defragging transparent huge pages Omar Sandoval
2021-10-20 13:47 ` Josef Bacik
2021-10-21 16:28 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211021162823.GG20319@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.