Re: [meta-arago][dunfell/master][PATCH V4 1/2] linux-firmware: Package intel 9260 WiFi and BT firmware

["Denys Dmytriyenko" <denis@denix.org>]

On Thu, Oct 21, 2021 at 06:45:58PM +0530, Sinthu Raja via lists.yoctoproject.org wrote:
> From: Sinthu Raja <sinthu.raja@ti.com>
> 
> The Intel 9260 WiFi and BT firmware is already part of the linux-firmware
> repository, so package it to make it available.
> 
> Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>

Reviewed-by: Denys Dmytriyenko <denys@konsulko.com>

> ---
> 
> Changes in V4:
> Addressed review comments that include making changes that are consistent with 
> respect to the original recipe.

Thank you for addressing all the comments!


> V3: http://arago-project.org/pipermail/meta-arago/2021-October/013343.html
> V2: https://www.mail-archive.com/meta-arago@arago-project.org/msg12121.html
> V1: https://www.mail-archive.com/meta-arago@arago-project.org/msg12117.html
> 
>  .../linux-firmware/linux-firmware_%.bbappend       | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-arago-distro/recipes-kernel/linux-firmware/linux-firmware_%.bbappend b/meta-arago-distro/recipes-kernel/linux-firmware/linux-firmware_%.bbappend
> index 146596ad..3472f267 100644
> --- a/meta-arago-distro/recipes-kernel/linux-firmware/linux-firmware_%.bbappend
> +++ b/meta-arago-distro/recipes-kernel/linux-firmware/linux-firmware_%.bbappend
> @@ -1,4 +1,16 @@
> -PR_append = ".arago0"
> +PR_append = ".arago1"
> +
> +PACKAGES =+ "${PN}-iwlwifi-9260"
> +PACKAGES =+ "${PN}-ibt-18"
> +
> +LICENSE_${PN}-iwlwifi-9260 = "Firmware-iwlwifi_firmware"
> +LICENSE_${PN}-ibt-18 = "Firmware-ibt_firmware"
> +
> +FILES_${PN}-iwlwifi-9260 = "${nonarch_base_libdir}/firmware/iwlwifi-9260-*.ucode"
> +FILES_${PN}-ibt-18 = "${nonarch_base_libdir}/firmware/intel/ibt-18-*.sfi ${nonarch_base_libdir}/firmware/intel/ibt-18-*.ddc"
> +
> +RDEPENDS_${PN}-iwlwifi-9260 += "${PN}-iwlwifi-license"
> +RDEPENDS_${PN}-ibt-18 += "${PN}-ibt-license"
>  
>  do_install_append() {
>  	rm -rf  ${D}/lib/firmware/ti-connectivity/
> -- 
> 2.31.1

-- 
Regards,
Denys Dmytriyenko <denis@denix.org>
PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964
Fingerprint: 25FC E4A5 8A72 2F69 1186  6D76 4209 0272 9A92 C964