From: Kory Maincent <kory.maincent@bootlin.com>
To: buildroot@buildroot.org
Cc: aduskett@gmail.com, yann.morin.1998@free.fr,
thomas.petazzoni@bootlin.com
Subject: [Buildroot] [PATCH v2 1/5] boot/grub2/grub2.mk: fix the installation of target tools
Date: Fri, 22 Oct 2021 13:51:30 +0200 [thread overview]
Message-ID: <20211022115134.345595-1-kory.maincent@bootlin.com> (raw)
The tools were not installed anymore since we move from autotools to
generic-package. This patch fixes their installation.
We have decided to implement the install tool process by running the "make
install" command for each tuple. This allows to have all different
platforms Grub modules installed in the target. The drawback is the
overwrite of Grub2 binaries tools during each "make install" command. This
drawback is absolutely not important as it happens in the same package. This is
the best option to avoid unnecessary and more complexity to this package.
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Tested-by: Adam Duskett <aduskett@gmail.com>
---
boot/grub2/grub2.mk | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/boot/grub2/grub2.mk b/boot/grub2/grub2.mk
index e01ebb2edb..a18696b6cc 100644
--- a/boot/grub2/grub2.mk
+++ b/boot/grub2/grub2.mk
@@ -195,5 +195,13 @@ define GRUB2_INSTALL_IMAGES_CMDS
)
endef
+ifeq ($(BR2_TARGET_GRUB2_INSTALL_TOOLS),y)
+define GRUB2_INSTALL_TARGET_CMDS
+ $(foreach tuple, $(GRUB2_TUPLES-y), \
+ $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/build-$(tuple) DESTDIR=$(TARGET_DIR) install
+ )
+endef
+endif
+
$(eval $(generic-package))
$(eval $(host-autotools-package))
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next reply other threads:[~2021-10-22 11:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 11:51 Kory Maincent [this message]
2021-10-22 11:51 ` [Buildroot] [PATCH v2 2/5] boot/grub2/grub2.mk: remove the unnecessary \-continuations Kory Maincent
2021-10-22 11:51 ` [Buildroot] [PATCH v2 3/5] boot/grub2/grub2.mk: add more explicit build messages Kory Maincent
2021-10-22 11:51 ` [Buildroot] [PATCH v2 4/5] boot/grub2/grub2.mk: fix the cdboot.img source from host to target Kory Maincent
2021-10-22 11:51 ` [Buildroot] [PATCH v2 5/5] boot/grub2/grub2.mk: use none platform when building for host Kory Maincent
2021-10-23 22:02 ` [Buildroot] [PATCH v2 1/5] boot/grub2/grub2.mk: fix the installation of target tools Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211022115134.345595-1-kory.maincent@bootlin.com \
--to=kory.maincent@bootlin.com \
--cc=aduskett@gmail.com \
--cc=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.