From: Luo Jie <luoj@codeaurora.org>
To: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
davem@davemloft.net, kuba@kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
sricharan@codeaurora.org, Luo Jie <luoj@codeaurora.org>
Subject: [PATCH v4 02/14] net: phy: at803x: use phy_modify()
Date: Fri, 22 Oct 2021 20:06:12 +0800 [thread overview]
Message-ID: <20211022120624.18069-3-luoj@codeaurora.org> (raw)
In-Reply-To: <20211022120624.18069-1-luoj@codeaurora.org>
Convert at803x_set_wol to use phy_modify.
Signed-off-by: Luo Jie <luoj@codeaurora.org>
---
drivers/net/phy/at803x.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
index b04fb251bacb..19011c16a1da 100644
--- a/drivers/net/phy/at803x.c
+++ b/drivers/net/phy/at803x.c
@@ -349,16 +349,12 @@ static int at803x_set_wol(struct phy_device *phydev,
phy_write_mmd(phydev, MDIO_MMD_PCS, offsets[i],
mac[(i * 2) + 1] | (mac[(i * 2)] << 8));
- value = phy_read(phydev, AT803X_INTR_ENABLE);
- value |= AT803X_INTR_ENABLE_WOL;
- ret = phy_write(phydev, AT803X_INTR_ENABLE, value);
+ ret = phy_modify(phydev, AT803X_INTR_ENABLE, 0, AT803X_INTR_ENABLE_WOL);
if (ret)
return ret;
value = phy_read(phydev, AT803X_INTR_STATUS);
} else {
- value = phy_read(phydev, AT803X_INTR_ENABLE);
- value &= (~AT803X_INTR_ENABLE_WOL);
- ret = phy_write(phydev, AT803X_INTR_ENABLE, value);
+ ret = phy_modify(phydev, AT803X_INTR_ENABLE, AT803X_INTR_ENABLE_WOL, 0);
if (ret)
return ret;
value = phy_read(phydev, AT803X_INTR_STATUS);
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2021-10-22 12:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 12:06 [PATCH v4 0/14] net: phy: Add qca8081 ethernet phy driver Luo Jie
2021-10-22 12:06 ` [PATCH v4 01/14] net: phy: at803x: replace AT803X_DEVICE_ADDR with MDIO_MMD_PCS Luo Jie
2021-10-22 12:13 ` Russell King (Oracle)
2021-10-23 1:53 ` Jie Luo
2021-10-23 8:19 ` Russell King (Oracle)
2021-10-22 12:06 ` Luo Jie [this message]
2021-10-22 12:15 ` [PATCH v4 02/14] net: phy: at803x: use phy_modify() Russell King (Oracle)
2021-10-23 1:54 ` Jie Luo
2021-10-22 12:06 ` [PATCH v4 03/14] net: phy: at803x: improve the WOL feature Luo Jie
2021-10-22 12:06 ` [PATCH v4 04/14] net: phy: at803x: use GENMASK() for speed status Luo Jie
2021-10-22 12:06 ` [PATCH v4 05/14] net: phy: add qca8081 ethernet phy driver Luo Jie
2021-10-22 16:03 ` Jakub Kicinski
2021-10-23 1:55 ` Jie Luo
2021-10-22 12:06 ` [PATCH v4 06/14] net: phy: add qca8081 read_status Luo Jie
2021-10-22 12:06 ` [PATCH v4 07/14] net: phy: add qca8081 get_features Luo Jie
2021-10-22 12:06 ` [PATCH v4 08/14] net: phy: add qca8081 config_aneg Luo Jie
2021-10-22 12:06 ` [PATCH v4 09/14] net: phy: add constants for fast retrain related register Luo Jie
2021-10-22 12:06 ` [PATCH v4 10/14] net: phy: add genphy_c45_fast_retrain Luo Jie
2021-10-22 12:06 ` [PATCH v4 11/14] net: phy: add qca8081 config_init Luo Jie
2021-10-22 12:06 ` [PATCH v4 12/14] net: phy: add qca8081 soft_reset and enable master/slave seed Luo Jie
2021-10-22 12:06 ` [PATCH v4 13/14] net: phy: adjust qca8081 master/slave seed value if link down Luo Jie
2021-10-22 12:06 ` [PATCH v4 14/14] net: phy: add qca8081 cdt feature Luo Jie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211022120624.18069-3-luoj@codeaurora.org \
--to=luoj@codeaurora.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=sricharan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.