From: "Gustavo A. R. Silva" <gustavoars@kernel.org>
To: Len Baker <len.baker@gmx.com>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <kch@nvidia.com>,
Kees Cook <keescook@chromium.org>,
linux-hardening@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvmet: prefer struct_size over open coded arithmetic
Date: Sat, 23 Oct 2021 15:14:38 -0500 [thread overview]
Message-ID: <20211023201438.GA1405616@embeddedor> (raw)
In-Reply-To: <20211023112838.GB4145@titan>
On Sat, Oct 23, 2021 at 01:28:38PM +0200, Len Baker wrote:
> Hi Gustavo,
>
> first of all, thanks for this review (and all others reviews as
> well) ;)
No problem. :)
> I think that it is better to use the dynamic allocation since in the
> future the struct size could be dynamic.
Yep; that seems sensible.
> it's not one single element. The "sizeof(struct nvme_ana_group_desc)" is
> multiplied by "ctrl->nanagrpid" and then added "ctrl->max_namespaces * sizeof(__le32)".
You're right. The whole expression got me a bit confused.
> > drivers/nvme/target/admin-cmd.c:267: return sizeof(struct nvme_ana_group_desc) + count * sizeof(__le32);
>
> Ok. I forgot it. Apologies.
No apologies. Thanks for your patches.
> Again, thanks for your time and advises,
Anytime.
Thanks
--
Gustavo
next prev parent reply other threads:[~2021-10-23 20:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-17 9:56 [PATCH] nvmet: prefer struct_size over open coded arithmetic Len Baker
2021-10-17 17:23 ` Gustavo A. R. Silva
2021-10-23 11:28 ` Len Baker
2021-10-23 20:14 ` Gustavo A. R. Silva [this message]
2021-10-20 17:24 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211023201438.GA1405616@embeddedor \
--to=gustavoars@kernel.org \
--cc=hch@lst.de \
--cc=kch@nvidia.com \
--cc=keescook@chromium.org \
--cc=len.baker@gmx.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.