From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Francois Perrad <fperrad@gmail.com>
Cc: buildroot@busybox.net
Subject: Re: [Buildroot] [PATCH 2/4] configs/stm32mp157*_dk*: dk2 is a superset of dk1
Date: Sun, 24 Oct 2021 14:59:42 +0200 [thread overview]
Message-ID: <20211024145942.12b18d03@windsurf> (raw)
In-Reply-To: <20211023071201.1016688-2-francois.perrad@gadz.org>
On Sat, 23 Oct 2021 09:11:59 +0200
Francois Perrad <fperrad@gmail.com> wrote:
> the daughter board (DK2) contains a 4" LCD with backlight and touchscreen.
The DK2 is not a daughter board. The DK1 and DK2 are two separate
boards. Even though they share a lot of common aspects, the DK2 is not
a daughter board.
For example, the DK2 has a WiFi/Bluetooth chip, which the DK1 doesn't
have, and this is not on a daughter board (and actually also not
properly handled by your fragment, which only cares about the display
and not WiFi/BT).
Overall, I am not sure if this commit is a real improvement. I agree
that the two Linux kernel configuration files have a lot in common, but
switching to using a fragment makes it much harder to update the kernel
configuration file.
So I'm not fully against it, but I'm not sure this commit really
improves anything.
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-10-24 12:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-23 7:11 [Buildroot] [PATCH 1/4] configs/stm32mp157*_dk*: use recommended layout Francois Perrad
2021-10-23 7:11 ` [Buildroot] [PATCH 2/4] configs/stm32mp157*_dk*: dk2 is a superset of dk1 Francois Perrad
2021-10-24 12:59 ` Thomas Petazzoni [this message]
2021-10-23 7:12 ` [Buildroot] [PATCH 3/4] configs/stm32mp157*_dk*: bump U-Boot version Francois Perrad
2021-10-24 12:57 ` Thomas Petazzoni
2021-10-23 7:12 ` [Buildroot] [PATCH 4/4] board/stmicroelectronics/stm32mp157*-dk*: cleanup linux config Francois Perrad
2021-10-24 13:00 ` Thomas Petazzoni
2021-10-24 12:57 ` [Buildroot] [PATCH 1/4] configs/stm32mp157*_dk*: use recommended layout Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211024145942.12b18d03@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
--cc=fperrad@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.