From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BFBBC433F5 for ; Sun, 24 Oct 2021 15:38:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5E7CC60F21 for ; Sun, 24 Oct 2021 15:38:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5E7CC60F21 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ymIjed2/LFNfwRbhH+SfUFd5XTFUcFaLzxxN45+eAPs=; b=OgyNzbulx4hFVr vJ8wbpCQf24xaxDeETDdyBUzQswrTPCxjq2Nc9OjmVjhvAQOQ+F6GsMRntB64W4QJ9g0j3nAk6WUw 9+k2cJ2dsvEwflL4RaiM6yu7i9dlbGEf9/VhEP1OLedzJ58dblyr+HMcVPDO/ZaHYnbev4MVh6yqJ ZFs5rznP/BWRFwUyGJMtraVHsF4S+TKdemeM6FgU8irE0PX0yyZuBDGtxZOSRU29x4W0S97X7koM5 5aDeDBwLPQmmoALCYf1sVVHEoi7+3zPG8gNpYo365hlf8IhkxUFbAEBmftYOk9s8N1ajXGyZe993X hPTOzLsXma5uOPd46IMg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mefZ4-00EBT4-N5; Sun, 24 Oct 2021 15:37:38 +0000 Received: from elvis.franken.de ([193.175.24.41]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mefZ1-00EBRf-30 for linux-arm-kernel@lists.infradead.org; Sun, 24 Oct 2021 15:37:36 +0000 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1mefYp-0006bc-06; Sun, 24 Oct 2021 17:37:24 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 083F3C265F; Sun, 24 Oct 2021 17:31:01 +0200 (CEST) Date: Sun, 24 Oct 2021 17:31:00 +0200 From: Thomas Bogendoerfer To: Mark Rutland Cc: linux-kernel@vger.kernel.org, aou@eecs.berkeley.edu, catalin.marinas@arm.com, deanbo422@gmail.com, green.hu@gmail.com, guoren@kernel.org, jonas@southpole.se, kernelfans@gmail.com, linux-arm-kernel@lists.infradead.org, linux@armlinux.org.uk, maz@kernel.org, nickhu@andestech.com, palmer@dabbelt.com, paulmck@kernel.org, paul.walmsley@sifive.com, peterz@infradead.org, shorne@gmail.com, stefan.kristiansson@saunalahti.fi, tglx@linutronix.de, torvalds@linux-foundation.org, vgupta@kernel.org, will@kernel.org Subject: Re: [PATCH 03/15] irq: mips: simplify do_domain_IRQ() Message-ID: <20211024153100.GG4721@alpha.franken.de> References: <20211021180236.37428-1-mark.rutland@arm.com> <20211021180236.37428-4-mark.rutland@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211021180236.37428-4-mark.rutland@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211024_083735_292544_8A79C793 X-CRM114-Status: GOOD ( 18.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 21, 2021 at 07:02:24PM +0100, Mark Rutland wrote: > There's no need fpr arch/mips's do_domain_IRQ() to open-code the NULL > check performed by handle_irq_desc(), nor the resolution of the desc > performed by generic_handle_domain_irq(). > > Use generic_handle_domain_irq() directly, as this is functioanlly > equivalent and clearer. > > There should be no functional change as a result of this patch. > > Signed-off-by: Mark Rutland > Cc: Marc Zyngier > Cc: Thomas Bogendoerfer > Cc: Thomas Gleixner > --- > arch/mips/kernel/irq.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/arch/mips/kernel/irq.c b/arch/mips/kernel/irq.c > index d20e002b3246..1fee96ef8059 100644 > --- a/arch/mips/kernel/irq.c > +++ b/arch/mips/kernel/irq.c > @@ -115,11 +115,7 @@ void __irq_entry do_domain_IRQ(struct irq_domain *domain, unsigned int hwirq) > > irq_enter(); > check_stack_overflow(); > - > - desc = irq_resolve_mapping(domain, hwirq); > - if (likely(desc)) > - handle_irq_desc(desc); > - > + generic_handle_domain_irq(domain, hwirq); > irq_exit(); > } > #endif > -- > 2.11.0 Acked-by: Thomas Bogendoerfer -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E9ABC433EF for ; Sun, 24 Oct 2021 15:37:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ECB9860F6F for ; Sun, 24 Oct 2021 15:37:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231951AbhJXPkC (ORCPT ); Sun, 24 Oct 2021 11:40:02 -0400 Received: from elvis.franken.de ([193.175.24.41]:37656 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231779AbhJXPjw (ORCPT ); Sun, 24 Oct 2021 11:39:52 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1mefYp-0006bc-06; Sun, 24 Oct 2021 17:37:24 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 083F3C265F; Sun, 24 Oct 2021 17:31:01 +0200 (CEST) Date: Sun, 24 Oct 2021 17:31:00 +0200 From: Thomas Bogendoerfer To: Mark Rutland Cc: linux-kernel@vger.kernel.org, aou@eecs.berkeley.edu, catalin.marinas@arm.com, deanbo422@gmail.com, green.hu@gmail.com, guoren@kernel.org, jonas@southpole.se, kernelfans@gmail.com, linux-arm-kernel@lists.infradead.org, linux@armlinux.org.uk, maz@kernel.org, nickhu@andestech.com, palmer@dabbelt.com, paulmck@kernel.org, paul.walmsley@sifive.com, peterz@infradead.org, shorne@gmail.com, stefan.kristiansson@saunalahti.fi, tglx@linutronix.de, torvalds@linux-foundation.org, vgupta@kernel.org, will@kernel.org Subject: Re: [PATCH 03/15] irq: mips: simplify do_domain_IRQ() Message-ID: <20211024153100.GG4721@alpha.franken.de> References: <20211021180236.37428-1-mark.rutland@arm.com> <20211021180236.37428-4-mark.rutland@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211021180236.37428-4-mark.rutland@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 21, 2021 at 07:02:24PM +0100, Mark Rutland wrote: > There's no need fpr arch/mips's do_domain_IRQ() to open-code the NULL > check performed by handle_irq_desc(), nor the resolution of the desc > performed by generic_handle_domain_irq(). > > Use generic_handle_domain_irq() directly, as this is functioanlly > equivalent and clearer. > > There should be no functional change as a result of this patch. > > Signed-off-by: Mark Rutland > Cc: Marc Zyngier > Cc: Thomas Bogendoerfer > Cc: Thomas Gleixner > --- > arch/mips/kernel/irq.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/arch/mips/kernel/irq.c b/arch/mips/kernel/irq.c > index d20e002b3246..1fee96ef8059 100644 > --- a/arch/mips/kernel/irq.c > +++ b/arch/mips/kernel/irq.c > @@ -115,11 +115,7 @@ void __irq_entry do_domain_IRQ(struct irq_domain *domain, unsigned int hwirq) > > irq_enter(); > check_stack_overflow(); > - > - desc = irq_resolve_mapping(domain, hwirq); > - if (likely(desc)) > - handle_irq_desc(desc); > - > + generic_handle_domain_irq(domain, hwirq); > irq_exit(); > } > #endif > -- > 2.11.0 Acked-by: Thomas Bogendoerfer -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]