From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 911B1C433F5 for ; Sun, 24 Oct 2021 16:44:18 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7B9CF61039 for ; Sun, 24 Oct 2021 16:44:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7B9CF61039 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7B16B8291E; Sun, 24 Oct 2021 18:44:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="RELt1S3w"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 537B882DD7; Sun, 24 Oct 2021 18:44:12 +0200 (CEST) Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C3D9D82128 for ; Sun, 24 Oct 2021 18:44:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x832.google.com with SMTP id y11so8210197qtn.13 for ; Sun, 24 Oct 2021 09:44:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yGqS+Po4a3+mBBT/cFZ/do4BA/0l7e4zAKvLRQjMi6Y=; b=RELt1S3wZ4hR+SGLLNIaVsQj7QjimuC8VarchO6QrNLLDeG5rtc0jxe75Jnm4zOpRh tPjSy0tWKAMltEXkOvumAMVygijBTeQJOKVp47ElvKaw4XFscbigvO3xqR2dV84TW4Gg zi9IC90j3+RNAdjnVziS/qFtbMLSVhqt3QnK8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yGqS+Po4a3+mBBT/cFZ/do4BA/0l7e4zAKvLRQjMi6Y=; b=7r6mI3RZB0DEVuLgSqO5ov/OvJ6XUWXynvIsDcYn2Y68zgzAdfq0/bKsWtUOadcAzF 0Lo0V8TNGfPksXLIesJ7KM8Ed0li13yaKU3xiGRGty77VwAnbnAD9O/koZ7hj5EQjcJw nXbE5g/7XhFWRpwGknJD4oe7twLgS8s7h/fenKU8wA83bJ8cjG95bUEruMQjjDswJz08 FUPzAP49VHz7uIpUVPiusyLVpWOfdMMC6Tw7E3TfB2hKZN+5+uTMfnR01TWE1H2FA5K5 kEER4In1kU/JJxlXIV7adOkbb0xkwwHsBJ2I/lo5olty8D6WVdE/4YH1OFJgZzwzuZb3 ElKA== X-Gm-Message-State: AOAM5303zDRKrwPzTiDohBrTyQ/6XqHs7FTjmuSsG9Z2sGF9iMZKlVAl K+v2ac0LYVjmxMNhcHrb3g4vvQ== X-Google-Smtp-Source: ABdhPJw/t6y8oQXFfNcqjQW/lq7wVLFW6fWK5q2dpZp3Oa+AinQRQt6aM2qTcPpJQ0ySYp5kcAvnJA== X-Received: by 2002:ac8:40d3:: with SMTP id f19mr12936277qtm.344.1635093847474; Sun, 24 Oct 2021 09:44:07 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-3118-5d12-7698-b973.res6.spectrum.com. [2603:6081:7b01:cbda:3118:5d12:7698:b973]) by smtp.gmail.com with ESMTPSA id 6sm7832827qtz.13.2021.10.24.09.44.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Oct 2021 09:44:06 -0700 (PDT) Date: Sun, 24 Oct 2021 12:44:04 -0400 From: Tom Rini To: Wolfgang Denk Cc: Simon Glass , Marek =?iso-8859-1?Q?Beh=FAn?= , U-Boot Mailing List , Rasmus Villemoes , Heinrich Schuchardt , Joe Hershberger Subject: Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file Message-ID: <20211024164404.GQ3577824@bill-the-cat> References: <3682215.1634809802@gemini.denx.de> <20211021122325.GX7964@bill-the-cat> <3695947.1634821611@gemini.denx.de> <20211021152537.441c37b9@thinkpad> <20211021152831.15524883@thinkpad> <20211021160311.GC3577824@bill-the-cat> <3763481.1634890085@gemini.denx.de> <20211022144759.GG3577824@bill-the-cat> <3903411.1635090360@gemini.denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kZU6r8y0YpRwyDfh" Content-Disposition: inline In-Reply-To: <3903411.1635090360@gemini.denx.de> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --kZU6r8y0YpRwyDfh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Oct 24, 2021 at 05:46:00PM +0200, Wolfgang Denk wrote: > Dear Tom, >=20 > In message <20211022144759.GG3577824@bill-the-cat> you wrote: > >=20 > > > Any escape character is also a legal name character. > > > > I am struggling to have a non-meme reaction to this. Perhaps the best > > step is just earlier on in the series note that variable names need to > > fit within the broadly and commonly used set of characters and assorted > > funny business you can do historically needs to be migrated. >=20 > Indeed I think this is the most reasonable approach. >=20 > Like you cannot write any aritrary code in plain C and have to fall > back to assembler in a few places, this patch series should simply > not claim to be able to support all legal environment settings. >=20 > It is a convenience tool, and it is OK if it has a few restrictions, > like for the character set of supported variable names. >=20 > But: >=20 > 1) These restrictions must be clearly documented, both in the commit > message and in the related documentation/readme. > 2) There should be another, more primitive way to generate > environment settings without these restrictions.. First, in that we don't have tests today for any of the "interesting" possible variable options, I have no clue which ones even work as intended. Second, yes, an end result here should be that yes, the default environment should be more easily buildable and integrated with arbitrary tools, so if something else can parse it (libubootenv?) it can be done. --=20 Tom --kZU6r8y0YpRwyDfh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmF1jVEACgkQFHw5/5Y0 tyyIngwAuji4x7Hc++ckg96/5Q57OjOnFqWra3mfaXs58qyWi2NOmNXw4jNNUKpX e54wC7pj52Ra5mbrJHI8QVMzzQOdTTRu5PxPvDg9zfa37U+jmw1PUdSpn/5QYxF1 LPBKKEKlp1nwjFXaBtia4sZ/pTavP4Or+KsQxd/UjDhCFLQMZdayym37TYfBb0Tx Dh8jD6KfYahiWA7083Elb0INW+e0QVUY0/V+ftCakUB9+fJRP2It8WSYz8UNIlSF S08TlpO0aNcboazBaKNINSoBUaLaUagF70naSLQokqZVVMfEDrPtypcYdoNsIPDp IVaBWYR2dJsdOv/atFNnFwinsnv2aTL8Sh17j69lCM0RgKk7YRRWDxUYhfXoPAZD oRQp6hgBu1bhnR9tooB76GAvmbKKBVF31VmGUlN9WlE2BJ29ffmhg5wTJY5/bCy7 4V1lU6O0LOtV2A3zZhXWoc7r3rIkIvyu9KhsAtjkqNpROzUQsWuinlfrQ1pKzvbe 5HTsumLP =8ttB -----END PGP SIGNATURE----- --kZU6r8y0YpRwyDfh--