All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: CHEN Xiangyu <xiangyu.chen@aol.com>
Cc: Simon Dawson <spdawson@gmail.com>,
	"buildroot@buildroot.org" <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH] boot/at91bootstrap3: add svn repository method
Date: Sun, 24 Oct 2021 18:49:23 +0200	[thread overview]
Message-ID: <20211024184923.6a70028a@windsurf> (raw)
In-Reply-To: <20211019080514.6189-1-xiangyu.chen@aol.com>

Hello Chen,

Thanks for this patch. However, I see a problem, see below.

On Tue, 19 Oct 2021 16:05:14 +0800
CHEN Xiangyu via buildroot <buildroot@buildroot.org> wrote:


>  config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_PATCH_DIR
> diff --git a/boot/at91bootstrap3/at91bootstrap3.mk b/boot/at91bootstrap3/at91bootstrap3.mk
> index 1e2a3a44b0..f609176a3f 100644
> --- a/boot/at91bootstrap3/at91bootstrap3.mk
> +++ b/boot/at91bootstrap3/at91bootstrap3.mk
> @@ -15,6 +15,9 @@ else ifeq ($(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT),y)
>  AT91BOOTSTRAP3_SITE = $(call qstrip,$(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL))
>  AT91BOOTSTRAP3_SITE_METHOD = git
>  BR_NO_CHECK_HASH_FOR += $(AT91BOOTSTRAP3_SOURCE)
> +else ifeq ($(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_SVN),y)
> +AT91BOOTSTRAP3_SITE_METHOD = svn
> +BR_NO_CHECK_HASH_FOR += $(AT91BOOTSTRAP3_SOURCE)

You're not defining AT91BOOTSTRAP3_SITE anywhere, so in fact it is
never assigned. The current code goes like this:

ifeq ($(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_TARBALL),y)
AT91BOOTSTRAP3_TARBALL = $(call qstrip,$(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_TARBALL_LOCATION))
AT91BOOTSTRAP3_SITE = $(patsubst %/,%,$(dir $(AT91BOOTSTRAP3_TARBALL)))
AT91BOOTSTRAP3_SOURCE = $(notdir $(AT91BOOTSTRAP3_TARBALL))
BR_NO_CHECK_HASH_FOR += $(AT91BOOTSTRAP3_SOURCE)
else ifeq ($(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT),y)
AT91BOOTSTRAP3_SITE = $(call qstrip,$(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL))
AT91BOOTSTRAP3_SITE_METHOD = git
BR_NO_CHECK_HASH_FOR += $(AT91BOOTSTRAP3_SOURCE)
else
AT91BOOTSTRAP3_SITE = $(call github,linux4sam,at91bootstrap,$(AT91BOOTSTRAP3_VERSION))
endif

So if you're adding a new case for
BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_SVN, it should also define
AT91BOOTSTRAP3_SITE.

Am I missing something ? Did you test this change ?

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2021-10-24 16:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20211019080514.6189-1-xiangyu.chen.ref@aol.com>
2021-10-19  8:05 ` [Buildroot] [PATCH] boot/at91bootstrap3: add svn repository method CHEN Xiangyu via buildroot
2021-10-24 16:49   ` Thomas Petazzoni [this message]
     [not found] <810116346.3867627.1634462494722.ref@mail.yahoo.com>
2021-10-17  9:21 ` Xiangyu Chen via buildroot
     [not found] <1553939413.3863322.1634461967644.ref@mail.yahoo.com>
2021-10-17  9:12 ` Xiangyu Chen via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211024184923.6a70028a@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@buildroot.org \
    --cc=spdawson@gmail.com \
    --cc=xiangyu.chen@aol.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.