From: Christoph Hellwig <hch@lst.de>
To: dsterba@suse.cz, Josef Bacik <josef@toxicpanda.com>,
hch@lst.de, linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH v2 1/2] fs: export an inode_update_time helper
Date: Mon, 25 Oct 2021 09:45:09 +0200 [thread overview]
Message-ID: <20211025074509.GA10347@lst.de> (raw)
In-Reply-To: <20211021163817.GH20319@twin.jikos.cz>
On Thu, Oct 21, 2021 at 06:38:17PM +0200, David Sterba wrote:
> On Thu, Oct 14, 2021 at 01:11:00PM -0400, Josef Bacik wrote:
> > If you already have an inode and need to update the time on the inode
> > there is no way to do this properly. Export this helper to allow file
> > systems to update time on the inode so the appropriate handler is
> > called, either ->update_time or generic_update_time.
> >
> > Signed-off-by: Josef Bacik <josef@toxicpanda.com>
>
> I'd like to get ack from Christoph, though it's a simple change it's
> still in another subsystem.
Not a big fan, but compared to the other options it seems like the
least bad option. That being said I'm not the VFS maintainer anyway.
next prev parent reply other threads:[~2021-10-25 7:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 17:10 [PATCH v2 0/2] Update device mod time fixes Josef Bacik
2021-10-14 17:11 ` [PATCH v2 1/2] fs: export an inode_update_time helper Josef Bacik
2021-10-21 16:38 ` David Sterba
2021-10-25 7:45 ` Christoph Hellwig [this message]
2021-10-25 17:36 ` David Sterba
2021-10-14 17:11 ` [PATCH v2 2/2] btrfs: update device path inode time instead of bd_inode Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211025074509.GA10347@lst.de \
--to=hch@lst.de \
--cc=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.