All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Marek Behún" <kabel@kernel.org>
To: Roman Bacik <roman.bacik@broadcom.com>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
	Bharat Gooty <bharat.gooty@broadcom.com>,
	Bin Meng <bmeng.cn@gmail.com>,
	Franck LENORMAND <franck.lenormand@nxp.com>,
	Heinrich Schuchardt <xypron.glpk@gmx.de>,
	Kory Maincent <kory.maincent@bootlin.com>,
	Michal Simek <michal.simek@xilinx.com>,
	Patrick Delaunay <patrick.delaunay@foss.st.com>,
	Peng Fan <peng.fan@nxp.com>,
	Priyanka Jain <priyanka.jain@nxp.com>,
	Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>,
	Sean Anderson <sean.anderson@seco.com>,
	Simon Glass <sjg@chromium.org>
Subject: Re: [PATCH v2 2/2] cmd: brcm: netXtreme commands
Date: Mon, 25 Oct 2021 16:01:24 +0200	[thread overview]
Message-ID: <20211025160124.3c423233@thinkpad> (raw)
In-Reply-To: <20211022162222.v2.2.I1edaad77041c1300213c307eef6741499504047@changeid>

On Fri, 22 Oct 2021 16:23:33 -0700
Roman Bacik <roman.bacik@broadcom.com> wrote:

> From: Bharat Gooty <bharat.gooty@broadcom.com>
> 
> Following netXtreme commands are supported:-
> Device probe, remove, supported speeds, get/set speeds and
> get/set MAC address.

NAK.

- "bnxt <bnxt_eth#> get mac

  U-Boot uses the ethaddr and ethNaddr environment variables for MAC
  addresses. You don't need a new custom command for that when there is
  a generic mechanism for this.

- "<bnxt_eth#> probe" / "<bnxt_eth#> remove"

  You also shouldn't need a command for driver probe / remove. DM should
  probe your driver automatically. And if you need it for debugging,
  please add such subcommand to the dm command.

- "bnxt <bnxt_eth#> get supported_speed"
  "bnxt <bnxt_eth#> get link_speed"

  These should be available via the mdio command when you register your
  PHY driver via appropriate API.

Marek

  parent reply	other threads:[~2021-10-25 14:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-22 23:23 [PATCH v2 1/2] net: brcm: netXtreme driver Roman Bacik
2021-10-22 23:23 ` [PATCH v2 2/2] cmd: brcm: netXtreme commands Roman Bacik
2021-10-23  8:02   ` Heinrich Schuchardt
2021-10-25 16:54     ` Roman Bacik
2021-10-25 14:01   ` Marek Behún [this message]
2021-10-25 16:34     ` Roman Bacik
2021-10-25 13:58 ` [PATCH v2 1/2] net: brcm: netXtreme driver Marek Behún
2021-10-25 21:35   ` Roman Bacik
2021-10-25 22:22     ` Marek Behún
2021-10-25 22:31       ` Roman Bacik
     [not found] <20211022161455.v2.1.I1edaad77041c1300213c307eef6741499504047@changeid>
2021-10-22 23:15 ` [PATCH v2 2/2] cmd: brcm: netXtreme commands Roman Bacik
2021-10-24 19:54   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211025160124.3c423233@thinkpad \
    --to=kabel@kernel.org \
    --cc=bharat.gooty@broadcom.com \
    --cc=bmeng.cn@gmail.com \
    --cc=franck.lenormand@nxp.com \
    --cc=kory.maincent@bootlin.com \
    --cc=michal.simek@xilinx.com \
    --cc=patrick.delaunay@foss.st.com \
    --cc=peng.fan@nxp.com \
    --cc=priyanka.jain@nxp.com \
    --cc=rayagonda.kokatanur@broadcom.com \
    --cc=roman.bacik@broadcom.com \
    --cc=sean.anderson@seco.com \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.