From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0331C433F5 for ; Mon, 25 Oct 2021 17:18:05 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AEE4660551 for ; Mon, 25 Oct 2021 17:18:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AEE4660551 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1F2B389EEB; Mon, 25 Oct 2021 17:18:02 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id F2A4889EAC; Mon, 25 Oct 2021 17:17:59 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10148"; a="229567902" X-IronPort-AV: E=Sophos;i="5.87,181,1631602800"; d="scan'208";a="229567902" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Oct 2021 10:17:59 -0700 X-IronPort-AV: E=Sophos;i="5.87,181,1631602800"; d="scan'208";a="536664172" Received: from jons-linux-dev-box.fm.intel.com (HELO jons-linux-dev-box) ([10.1.27.20]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Oct 2021 10:17:59 -0700 Date: Mon, 25 Oct 2021 10:13:22 -0700 From: Matthew Brost To: Joonas Lahtinen Cc: Thomas =?iso-8859-1?Q?Hellstr=F6m?= , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, daniele.ceraolospurio@intel.com, john.c.harrison@intel.com Message-ID: <20211025171321.GA9338@jons-linux-dev-box> References: <20211020192147.8048-1-matthew.brost@intel.com> <163516458029.3804.14322548249266136569@jlahtine-mobl.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <163516458029.3804.14322548249266136569@jlahtine-mobl.ger.corp.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [Intel-gfx] [PATCH] drm/i915/guc: Fix recursive lock in GuC submission X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, Oct 25, 2021 at 03:23:00PM +0300, Joonas Lahtinen wrote: > Quoting Thomas Hellström (2021-10-21 08:39:48) > > On Wed, 2021-10-20 at 12:21 -0700, Matthew Brost wrote: > > > > > > Fixes: 1a52faed31311 ("drm/i915/guc: Take engine PM when a context is > > > pinned with GuC submission") > > > Signed-off-by: Matthew Brost > > > Cc: stable@vger.kernel.org > > This Cc: stable annotation is unnecessary. > > Please always use "dim fixes 1a52faed31311" for helping to decide which > Cc's are needed. In this case stable is not needed. If it was, there > would be an indication of kernel version. In this case this is fine to > be picked up by in drm-intel-next-fixes PR. > > Let's pay attention to the right Fixes: annotation while submitting and > reviewing patches. > Will do. Working on getting push rights. Is there any documentation with all the rules when pushing as it seems like there are a lot of rules. Matt > Regards, Joonas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D48FCC433F5 for ; Mon, 25 Oct 2021 17:18:02 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 88AE260C49 for ; Mon, 25 Oct 2021 17:18:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 88AE260C49 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B5CDB89EAC; Mon, 25 Oct 2021 17:18:01 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id F2A4889EAC; Mon, 25 Oct 2021 17:17:59 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10148"; a="229567902" X-IronPort-AV: E=Sophos;i="5.87,181,1631602800"; d="scan'208";a="229567902" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Oct 2021 10:17:59 -0700 X-IronPort-AV: E=Sophos;i="5.87,181,1631602800"; d="scan'208";a="536664172" Received: from jons-linux-dev-box.fm.intel.com (HELO jons-linux-dev-box) ([10.1.27.20]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Oct 2021 10:17:59 -0700 Date: Mon, 25 Oct 2021 10:13:22 -0700 From: Matthew Brost To: Joonas Lahtinen Cc: Thomas =?iso-8859-1?Q?Hellstr=F6m?= , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, daniele.ceraolospurio@intel.com, john.c.harrison@intel.com Subject: Re: [PATCH] drm/i915/guc: Fix recursive lock in GuC submission Message-ID: <20211025171321.GA9338@jons-linux-dev-box> References: <20211020192147.8048-1-matthew.brost@intel.com> <163516458029.3804.14322548249266136569@jlahtine-mobl.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <163516458029.3804.14322548249266136569@jlahtine-mobl.ger.corp.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Oct 25, 2021 at 03:23:00PM +0300, Joonas Lahtinen wrote: > Quoting Thomas Hellström (2021-10-21 08:39:48) > > On Wed, 2021-10-20 at 12:21 -0700, Matthew Brost wrote: > > > > > > Fixes: 1a52faed31311 ("drm/i915/guc: Take engine PM when a context is > > > pinned with GuC submission") > > > Signed-off-by: Matthew Brost > > > Cc: stable@vger.kernel.org > > This Cc: stable annotation is unnecessary. > > Please always use "dim fixes 1a52faed31311" for helping to decide which > Cc's are needed. In this case stable is not needed. If it was, there > would be an indication of kernel version. In this case this is fine to > be picked up by in drm-intel-next-fixes PR. > > Let's pay attention to the right Fixes: annotation while submitting and > reviewing patches. > Will do. Working on getting push rights. Is there any documentation with all the rules when pushing as it seems like there are a lot of rules. Matt > Regards, Joonas