From: Yucong Sun <fallentree@fb.com>
To: <bpf@vger.kernel.org>
Cc: <andrii@kernel.org>, Yucong Sun <sunyucong@gmail.com>
Subject: [PATCH bpf-next 4/4] selftests/bpf: adding a namespace reset for tc_redirect
Date: Mon, 25 Oct 2021 15:33:45 -0700 [thread overview]
Message-ID: <20211025223345.2136168-5-fallentree@fb.com> (raw)
In-Reply-To: <20211025223345.2136168-1-fallentree@fb.com>
From: Yucong Sun <sunyucong@gmail.com>
This patch delete ns_src/ns_dst/ns_redir namespaces before recreating
them, making the test more robust.
Signed-off-by: Yucong Sun <sunyucong@gmail.com>
---
.../testing/selftests/bpf/prog_tests/tc_redirect.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/tools/testing/selftests/bpf/prog_tests/tc_redirect.c b/tools/testing/selftests/bpf/prog_tests/tc_redirect.c
index 53672634bc52..4b18b73df10b 100644
--- a/tools/testing/selftests/bpf/prog_tests/tc_redirect.c
+++ b/tools/testing/selftests/bpf/prog_tests/tc_redirect.c
@@ -176,6 +176,18 @@ static int netns_setup_namespaces(const char *verb)
return 0;
}
+static void netns_setup_namespaces_nofail(const char *verb)
+{
+ const char * const *ns = namespaces;
+ char cmd[128];
+
+ while (*ns) {
+ snprintf(cmd, sizeof(cmd), "ip netns %s %s > /dev/null 2>&1", verb, *ns);
+ system(cmd);
+ ns++;
+ }
+}
+
struct netns_setup_result {
int ifindex_veth_src_fwd;
int ifindex_veth_dst_fwd;
@@ -762,6 +774,8 @@ static void test_tc_redirect_peer_l3(struct netns_setup_result *setup_result)
static void *test_tc_redirect_run_tests(void *arg)
{
+ netns_setup_namespaces_nofail("delete");
+
RUN_TEST(tc_redirect_peer);
RUN_TEST(tc_redirect_peer_l3);
RUN_TEST(tc_redirect_neigh);
--
2.30.2
next prev parent reply other threads:[~2021-10-25 22:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 22:33 [PATCH bpf-next 0/4] selftests/bpf: parallel mode improvement Yucong Sun
2021-10-25 22:33 ` [PATCH bpf-next 1/4] selfetests/bpf: Update vmtest.sh defaults Yucong Sun
2021-10-25 22:33 ` [PATCH bpf-next 2/4] selftests/bpf: print subtest status line Yucong Sun
2021-10-26 4:09 ` Andrii Nakryiko
2021-10-26 17:24 ` sunyucong
2021-10-27 16:46 ` Andrii Nakryiko
2021-10-25 22:33 ` [PATCH bpf-next 3/4] selftests/bpf: fix attach_probe in parallel mode Yucong Sun
2021-10-26 4:11 ` Andrii Nakryiko
2021-10-25 22:33 ` Yucong Sun [this message]
2021-10-27 19:18 ` [PATCH bpf-next 0/4] selftests/bpf: parallel mode improvement Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211025223345.2136168-5-fallentree@fb.com \
--to=fallentree@fb.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=sunyucong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.